Fixing cmake developer warning (#972)

Here is the warning currently being produced:

CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.19/Modules/GNUInstallDirs.cmake:223 (message):
  Unable to determine default CMAKE_INSTALL_LIBDIR directory because no
  target architecture is known.  Please enable at least one language before
  including GNUInstallDirs.
Call Stack (most recent call first):
  cmake/guidelineSupportLibrary.cmake:20 (include)
  CMakeLists.txt:4 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

I noted how I fixed the error. This is caused by GNUInstallDirs automatically executing code just by including it.

I also added -Werror=dev to the CI to ensure this never happens again.

Co-authored-by: Juan Ramos <juanr0911@gmail.com>
This commit is contained in:
jpr89andJuan Ramos authored and GitHub committed 2021-01-19 13:41:25 -08:00
1 parent d9fa328f89
commit 84aeb59f26
5 files changed
+6 -5

No files matched your search

-3
View File
@@ -16,9 +16,6 @@ endif()
# Necessary for 'write_basic_package_version_file'
include(CMakePackageConfigHelpers)
# Use GNUInstallDirs to provide the right locations on all platforms
include(GNUInstallDirs)
function(gsl_set_default_cxx_standard min_cxx_standard)
set(GSL_CXX_STANDARD "${min_cxx_standard}" CACHE STRING "Use c++ standard")