reviewed the pr in its entirety and made some slight modifications. Removed all members and fields marked as deprecated.

This commit is contained in:
Jordan Maples [MSFT]
2020-02-11 16:36:07 -08:00
parent cce6ee563e
commit 926aaeca56
4 changed files with 11 additions and 29 deletions
+4 -4
View File
@@ -1485,7 +1485,7 @@ TEST(span_test, from_array_constructor)
}
}
TEST(span_test, as_writeable_bytes)
TEST(span_test, as_writable_bytes)
{
int a[] = {1, 2, 3, 4};
@@ -1494,7 +1494,7 @@ TEST(span_test, from_array_constructor)
// you should not be able to get writeable bytes for const objects
span<const int> s = a;
EXPECT_TRUE(s.size() == 4);
span<const byte> bs = as_writeable_bytes(s);
span<const byte> bs = as_writable_bytes(s);
EXPECT_TRUE(static_cast<void*>(bs.data()) == static_cast<void*>(s.data()));
EXPECT_TRUE(bs.size() == s.size_bytes());
#endif
@@ -1502,7 +1502,7 @@ TEST(span_test, from_array_constructor)
{
span<int> s;
const auto bs = as_writeable_bytes(s);
const auto bs = as_writable_bytes(s);
EXPECT_TRUE(bs.size() == s.size());
EXPECT_TRUE(bs.size() == 0);
EXPECT_TRUE(bs.size_bytes() == 0);
@@ -1512,7 +1512,7 @@ TEST(span_test, from_array_constructor)
{
span<int> s = a;
const auto bs = as_writeable_bytes(s);
const auto bs = as_writable_bytes(s);
EXPECT_TRUE(static_cast<void*>(bs.data()) == static_cast<void*>(s.data()));
EXPECT_TRUE(bs.size() == s.size_bytes());
}