Dev/annagrin/remove explicit not null constructor (#743)

* Added c++17 test configurations for clang5.0 and clang6.0

* Removed explicit not_null constructor, sloppy_not_null, added strict_not_null

We added explicit not_null constructor in version 2.0.0.
It proved very difficult to switch to the new version for
large code bases that adopted previous versions of gsl,
due to not_null used extensively in the code. Still, using
explicit constructor is very benefitial for new code, since
it encorages better API design and make null checks intentional.

To resolve the issue, this change:
- removes explicit keyword from not_null constructor
- removes unneded sloppy_not_null type
- adds strict_not_null type to behave the same way as v2 not_null
- updates tests

* Removed explicit not_null constructor, sloppy_not_null, added strict_not_null

We added explicit not_null constructor in version 2.0.0.
It proved very difficult to switch to the new version for
large code bases that adopted previous versions of gsl,
due to not_null used extensively in the code. Still, using
explicit constructor is very benefitial for new code, since
it encorages better API design and make null checks intentional.

To resolve the issue, this change:
- removes explicit keyword from not_null constructor
- removes unneded sloppy_not_null type
- adds strict_not_null type to behave the same way as v2 not_null
- updates tests

* fixed build break for gcc7

* added more tests

* added more non-compiling tests

* Addressed PR comments and suppressed a code analysis warning

* Fixed test failure in not_null tests

This commit is contained in:

Anna Gringauze

2019-01-14 16:45:47 -08:00

committed by

GitHub

parent 7a7d025ffa

commit 9ff6e19ea9

8 changed files with 384 additions and 291 deletions

									
										tests/test.cpp
									
		+2
		-1
	
												View File
												
				@@ -20,7 +20,8 @@

				// blanket turn off warnings from CppCoreCheck from catch

				// so people aren't annoyed by them when running the tool.

				#pragma warning(disable : 26401 26409 26415 26418 26426 26429 26432 26433 26434 26435 26436 26439 26440 26443 26444 26446 26447 26451 26460 26461 26466 26472 26481 26482 26485 26492 26493 26494 26495 26496 26497) // from catch

				#include <CodeAnalysis/Warnings.h>

				#pragma warning(disable : ALL_CODE_ANALYSIS_WARNINGS) // from catch

				#endif // _MSC_VER

				#include <catch/catch.hpp>