From f42649adc368bc9182ac0e6bbca15399560d6404 Mon Sep 17 00:00:00 2001 From: Brokkonaut Date: Fri, 29 Jan 2021 20:10:43 +0100 Subject: [PATCH] Do not forget to close connection when upgrading a table fails --- src/main/java/de/diddiz/LogBlock/Updater.java | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/main/java/de/diddiz/LogBlock/Updater.java b/src/main/java/de/diddiz/LogBlock/Updater.java index a521659..fcd2b70 100644 --- a/src/main/java/de/diddiz/LogBlock/Updater.java +++ b/src/main/java/de/diddiz/LogBlock/Updater.java @@ -738,9 +738,14 @@ class Updater { st.execute("ALTER TABLE `" + wcfg.table + "-entities` ADD KEY entityid (entityid)"); logblock.getLogger().info("Added index for table " + wcfg.table + "-entities"); st.close(); - conn.close(); } catch (final SQLException ex) { - logblock.getLogger().log(Level.SEVERE, "[Updater] Error: ", ex); + logblock.getLogger().log(Level.SEVERE, "[Updater] Warning: Could not upgrade the database: " + ex.getMessage()); + } finally { + try { + conn.close(); + } catch (SQLException e) { + // ignored + } } } config.set("version", "1.16.0");