From 2e69567096de312609fb4fe0696fca99a8d7afd7 Mon Sep 17 00:00:00 2001 From: 0xFEEDC0DE <0xfeedc0de64@gmail.com> Date: Sun, 11 Mar 2018 15:37:47 +0100 Subject: [PATCH] Implemented isValid and apply() of LunchMealSettingsWidget (Fixes #67) --- plugins/lunchmealplugin/lunchmealsettingswidget.cpp | 11 +++++++++-- plugins/weatherplugin/weathersettingswidget.cpp | 4 +++- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/plugins/lunchmealplugin/lunchmealsettingswidget.cpp b/plugins/lunchmealplugin/lunchmealsettingswidget.cpp index b6fe25e..0fff7b3 100644 --- a/plugins/lunchmealplugin/lunchmealsettingswidget.cpp +++ b/plugins/lunchmealplugin/lunchmealsettingswidget.cpp @@ -21,12 +21,19 @@ LunchMealSettingsWidget::LunchMealSettingsWidget(ZeiterfassungSettings &settings bool LunchMealSettingsWidget::isValid(QString &message) const { - Q_UNUSED(message) + auto valid = QUrl::fromUserInput(m_lineEditUrl->text()).isValid(); - return true; + if(!valid) + message = tr("The lunch meal api url is invalid!"); + + return valid; } void LunchMealSettingsWidget::apply() { + auto url = QUrl::fromUserInput(m_lineEditUrl->text()); + if(m_settings.url() != url) + m_settings.setUrl(url); + m_settings.setDateFormat(m_lineEditDateFormat->text()); } diff --git a/plugins/weatherplugin/weathersettingswidget.cpp b/plugins/weatherplugin/weathersettingswidget.cpp index 2e14db6..5be082a 100644 --- a/plugins/weatherplugin/weathersettingswidget.cpp +++ b/plugins/weatherplugin/weathersettingswidget.cpp @@ -28,5 +28,7 @@ bool WeatherSettingsWidget::isValid(QString &message) const void WeatherSettingsWidget::apply() { - m_settings.setUrl(QUrl::fromUserInput(m_lineEdit->text())); + auto url = QUrl::fromUserInput(m_lineEdit->text()); + if(m_settings.url() != url) + m_settings.setUrl(url); }