feedc0de/arduino-esp32
1
0
Fork 0
forked from espressif/arduino-esp32
Code Pull Requests Activity

Resolve WString TODO (#6190)

Browse Source 
Resolve TODO (XXX) by logging warning message.
This commit is contained in:
mrengineer7777
2022-01-31 05:07:37 -06:00
committed by GitHub
parent cbeb7c4df8
commit 9fe34f6553
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cores/esp32/WString.cpp
View File

@ -24,6 +24,7 @@
#include <Arduino.h> #include <Arduino.h>
#include "WString.h" #include "WString.h"
#include "stdlib_noniso.h" #include "stdlib_noniso.h"
#include "esp32-hal-log.h"
/*********************************************/ /*********************************************/
/* Constructors */ /* Constructors */
@ -774,7 +775,8 @@ void String::replace(const String& find, const String& replace) {
if(size == len()) if(size == len())
return; return;
if(size > capacity() && !changeBuffer(size)) if(size > capacity() && !changeBuffer(size))
return; // XXX: tell user! log_w("String.Replace() Insufficient space to replace string");
return;
int index = len() - 1; int index = len() - 1;
while(index >= 0 && (index = lastIndexOf(find, index)) >= 0) { while(index >= 0 && (index = lastIndexOf(find, index)) >= 0) {
readFrom = wbuffer() + index + find.len(); readFrom = wbuffer() + index + find.len();