feedc0de/arduinoWebSockets
1
0
Fork 0
forked from Links2004/arduinoWebSockets
Code Pull Requests Activity

- Fix memory leak by calling delete _server in the WebSocketsServer destructor.

Browse Source 
- Improve performance by looking for match to existing socket before creating a new one
This commit is contained in:
patrick
2023-11-22 20:35:40 -05:00
committed by Markus
parent 241c73a806
commit 3352c833b8
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/WebSocketsServer.cpp
View File

@ -65,6 +65,7 @@ WebSocketsServerCore::~WebSocketsServerCore() {
} }
WebSocketsServer::~WebSocketsServer() { WebSocketsServer::~WebSocketsServer() {
delete _server;
} }
/** /**
@ -428,8 +429,16 @@ WSclient_t * WebSocketsServerCore::newClient(WEBSOCKETS_NETWORK_CLASS * TCPclien
for(uint8_t i = 0; i < WEBSOCKETS_SERVER_CLIENT_MAX; i++) { for(uint8_t i = 0; i < WEBSOCKETS_SERVER_CLIENT_MAX; i++) {
client = &_clients[i]; client = &_clients[i];
// look for match to existing socket before creating a new one
if (clientIsConnected(client))
{
// Check to see if it is the same socket - if so, return it
if (client->tcp->getSocketNumber() == TCPclient->getSocketNumber())
{
return client;
}
} else {
// state is not connected or tcp connection is lost // state is not connected or tcp connection is lost
if(!clientIsConnected(client)) {
client->tcp = TCPclient; client->tcp = TCPclient;
#if(WEBSOCKETS_NETWORK_TYPE == NETWORK_ESP8266) || (WEBSOCKETS_NETWORK_TYPE == NETWORK_ESP32) #if(WEBSOCKETS_NETWORK_TYPE == NETWORK_ESP8266) || (WEBSOCKETS_NETWORK_TYPE == NETWORK_ESP32)