feedc0de/bobbycar-boardcomputer-firmware
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix FEATURE_LEDSTRIP crashing when turning on (uninitialized memory)

Browse Source
This commit is contained in:
CommanderRedYT
2022-02-14 22:27:50 +01:00
parent 89779c4648
commit e17e7ba5f8
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
main/ledstrip.cpp
View File

@ -18,6 +18,9 @@ uint8_t gHue = 0;
uint16_t blinkAnimation = LEDSTRIP_OVERWRITE_NONE; uint16_t blinkAnimation = LEDSTRIP_OVERWRITE_NONE;
namespace {
bool initialized{false};
} // namespace
void initLedStrip() void initLedStrip()
{ {
@ -26,13 +29,23 @@ void initLedStrip()
leds.resize(configs.ledstrip.ledsCount.value); leds.resize(configs.ledstrip.ledsCount.value);
FastLED.addLeds<NEOPIXEL, PINS_LEDSTRIP>(&*std::begin(leds), leds.size()) FastLED.addLeds<NEOPIXEL, PINS_LEDSTRIP>(&*std::begin(leds), leds.size())
.setCorrection(TypicalSMD5050); .setCorrection(TypicalSMD5050);
initialized = true;
} }
} }
void updateLedStrip() void updateLedStrip()
{ {
if(!configs.feature.ledstrip.value) if (configs.feature.ledstrip.value && !initialized)
return; initLedStrip();
else if (!configs.feature.ledstrip.value && initialized)
{
std::fill(std::begin(leds), std::end(leds), CRGB::Black);
FastLED.show();
initialized = false;
return;
}
else if (!configs.feature.ledstrip.value)
return;
EVERY_N_MILLISECONDS( 20 ) { gHue++; } EVERY_N_MILLISECONDS( 20 ) { gHue++; }
static bool have_disabled_beeper = false; static bool have_disabled_beeper = false;