feedc0de/bobbycar-controller-firmware
1
0
Fork 0
Code Issues 8 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Fix data type of a_phaAdvMax in CAN protocol #19

Merged
mickdermack merged 1 commits from fix-can-phaadvmax into master 2022-10-02 16:49:36 +02:00
Conversation 2 Commits 1 Files Changed 1 +3 -2
mickdermack commented 2022-10-02 02:08:58 +02:00 (Migrated from github.com)
Copy Link

Before this,a_phaAdvMax was sent over the wire as 1 byte (uint8_t) but parsed as 2 bytes (uint16_t). When testing the v1.3 boards, this has lead to unexpectedly high speeds when field weakening in sinusoidal mode.

This bug has not caused a problem in the past, possibly because the CAN controller zeroed out the following bytes. We now use a GD32 chip instead of STM32 which may have a slightly different CAN controller. Another possible causes might be a difference in compiler version.

Before this,`a_phaAdvMax` was sent over the wire as 1 byte (`uint8_t`) but parsed as 2 bytes (`uint16_t`). When testing the v1.3 boards, this has lead to unexpectedly high speeds when field weakening in sinusoidal mode. This bug has not caused a problem in the past, possibly because the CAN controller zeroed out the following bytes. We now use a GD32 chip instead of STM32 which may have a slightly different CAN controller. Another possible causes might be a difference in compiler version.
0xFEEDC0DE64 (Migrated from github.com) reviewed 2022-10-02 02:08:58 +02:00
CommanderRedYT (Migrated from github.com) approved these changes 2022-10-02 08:14:56 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
0xFEEDC0DE64
CommanderRedYT
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
needs-testing
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
feedc0de
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: feedc0de/bobbycar-controller-firmware#19
No description provided.
Delete Branch "fix-can-phaadvmax"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?