Fix data type of a_phaAdvMax in CAN protocol #19

2022-10-02T02:08:58+02:00

mickdermack commented

2022-10-02 02:08:58 +02:00

(Migrated from github.com)

Before this,a_phaAdvMax was sent over the wire as 1 byte (uint8_t) but parsed as 2 bytes (uint16_t). When testing the v1.3 boards, this has lead to unexpectedly high speeds when field weakening in sinusoidal mode.

This bug has not caused a problem in the past, possibly because the CAN controller zeroed out the following bytes. We now use a GD32 chip instead of STM32 which may have a slightly different CAN controller. Another possible causes might be a difference in compiler version.

Before this,`a_phaAdvMax` was sent over the wire as 1 byte (`uint8_t`) but parsed as 2 bytes (`uint16_t`). When testing the v1.3 boards, this has lead to unexpectedly high speeds when field weakening in sinusoidal mode. This bug has not caused a problem in the past, possibly because the CAN controller zeroed out the following bytes. We now use a GD32 chip instead of STM32 which may have a slightly different CAN controller. Another possible causes might be a difference in compiler version.

0xFEEDC0DE64 (Migrated from github.com) reviewed 2022-10-02 02:08:58 +02:00

CommanderRedYT (Migrated from github.com) approved these changes 2022-10-02 08:14:56 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: feedc0de/bobbycar-controller-firmware#19