feedc0de/boost_beast
1
0 Fork 0
forked from boostorg/beast
Code Pull Requests Activity

Files return errc::bad_file_descriptor (API Change):

Browse Source 
fix #1356

* File functions return errc::bad_file_descriptor
  instead of errc::invalid_argument.

Actions Required:

* Callers checking for errc::invalid_argument from calls to
  file APIs should check for errc::bad_file_descriptor instead.
This commit is contained in:
Vinnie Falco committed 2018-12-12 19:32:21 -08:00
1 parent 8262405064
commit 4fec064ad8
5 files changed
+29 -20
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

include/boost/beast/core/impl/file_posix.ipp
+5 -5
View File
@@ -224,7 +224,7 @@ size(error_code& ec) const
{
if(fd_ == -1)
{
ec = make_error_code(errc::invalid_argument);
ec = make_error_code(errc::bad_file_descriptor);
return 0;
}
struct stat st;
@@ -244,7 +244,7 @@ pos(error_code& ec) const
{
if(fd_ == -1)
{
ec = make_error_code(errc::invalid_argument);
ec = make_error_code(errc::bad_file_descriptor);
return 0;
}
auto const result = ::lseek(fd_, 0, SEEK_CUR);
@@ -264,7 +264,7 @@ seek(std::uint64_t offset, error_code& ec)
{
if(fd_ == -1)
{
ec = make_error_code(errc::invalid_argument);
ec = make_error_code(errc::bad_file_descriptor);
return;
}
auto const result = ::lseek(fd_, offset, SEEK_SET);
@@ -283,7 +283,7 @@ read(void* buffer, std::size_t n, error_code& ec) const
{
if(fd_ == -1)
{
ec = make_error_code(errc::invalid_argument);
ec = make_error_code(errc::bad_file_descriptor);
return 0;
}
std::size_t nread = 0;
@@ -319,7 +319,7 @@ write(void const* buffer, std::size_t n, error_code& ec)
{
if(fd_ == -1)
{
ec = make_error_code(errc::invalid_argument);
ec = make_error_code(errc::bad_file_descriptor);
return 0;
}
std::size_t nwritten = 0;
include/boost/beast/core/impl/file_stdio.ipp
+5 -5
View File
@@ -122,7 +122,7 @@ size(error_code& ec) const
{
if(! f_)
{
ec = make_error_code(errc::invalid_argument);
ec = make_error_code(errc::bad_file_descriptor);
return 0;
}
long pos = std::ftell(f_);
@@ -159,7 +159,7 @@ pos(error_code& ec) const
{
if(! f_)
{
ec = make_error_code(errc::invalid_argument);
ec = make_error_code(errc::bad_file_descriptor);
return 0;
}
long pos = std::ftell(f_);
@@ -179,7 +179,7 @@ seek(std::uint64_t offset, error_code& ec)
{
if(! f_)
{
ec = make_error_code(errc::invalid_argument);
ec = make_error_code(errc::bad_file_descriptor);
return;
}
if(offset > (std::numeric_limits<long>::max)())
@@ -202,7 +202,7 @@ read(void* buffer, std::size_t n, error_code& ec) const
{
if(! f_)
{
ec = make_error_code(errc::invalid_argument);
ec = make_error_code(errc::bad_file_descriptor);
return 0;
}
auto nread = std::fread(buffer, 1, n, f_);
@@ -221,7 +221,7 @@ write(void const* buffer, std::size_t n, error_code& ec)
{
if(! f_)
{
ec = make_error_code(errc::invalid_argument);
ec = make_error_code(errc::bad_file_descriptor);
return 0;
}
auto nwritten = std::fwrite(buffer, 1, n, f_);
include/boost/beast/core/impl/file_win32.ipp
+5 -5
View File
@@ -216,7 +216,7 @@ size(error_code& ec) const
{
if(h_ == boost::winapi::INVALID_HANDLE_VALUE_)
{
ec = make_error_code(errc::invalid_argument);
ec = make_error_code(errc::bad_file_descriptor);
return 0;
}
boost::winapi::LARGE_INTEGER_ fileSize;
@@ -237,7 +237,7 @@ pos(error_code& ec)
{
if(h_ == boost::winapi::INVALID_HANDLE_VALUE_)
{
ec = make_error_code(errc::invalid_argument);
ec = make_error_code(errc::bad_file_descriptor);
return 0;
}
boost::winapi::LARGE_INTEGER_ in;
@@ -261,7 +261,7 @@ seek(std::uint64_t offset, error_code& ec)
{
if(h_ == boost::winapi::INVALID_HANDLE_VALUE_)
{
ec = make_error_code(errc::invalid_argument);
ec = make_error_code(errc::bad_file_descriptor);
return;
}
boost::winapi::LARGE_INTEGER_ in;
@@ -283,7 +283,7 @@ read(void* buffer, std::size_t n, error_code& ec)
{
if(h_ == boost::winapi::INVALID_HANDLE_VALUE_)
{
ec = make_error_code(errc::invalid_argument);
ec = make_error_code(errc::bad_file_descriptor);
return 0;
}
std::size_t nread = 0;
@@ -324,7 +324,7 @@ write(void const* buffer, std::size_t n, error_code& ec)
{
if(h_ == boost::winapi::INVALID_HANDLE_VALUE_)
{
ec = make_error_code(errc::invalid_argument);
ec = make_error_code(errc::bad_file_descriptor);
return 0;
}
std::size_t nwritten = 0;