feedc0de/boost_beast
1
0
Fork 0
forked from boostorg/beast
Code Pull Requests Activity

Fix nullptr implicit cast on fields::set()

Browse Source 
fixes #2085
This commit is contained in:
Richard Hodges
2020-09-13 16:19:27 +02:00
parent 91d9457ab9
commit bea31bfff6
3 changed files with 88 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/beast/http/fields.cpp
+67
View File
@@ -1004,6 +1004,72 @@ public:
BEAST_EXPECT(req.count("abc") == 3);
}
template<class Arg1, class InArg>
struct set_test
{
static auto test(...) ->
std::false_type;
template<class U = InArg>
static auto test(U arg) ->
decltype(std::declval<fields>().
set(std::declval<Arg1>(),
std::declval<U>()),
std::true_type());
static constexpr bool value =
decltype(test(std::declval<InArg>()))::value;
};
template<class Arg1, class InArg>
struct insert_test
{
static auto test(...) ->
std::false_type;
template<class U = InArg>
static auto test(U arg) ->
decltype(std::declval<fields>().
insert(std::declval<Arg1>(),
std::declval<U>()),
std::true_type());
static constexpr bool value =
decltype(test(std::declval<InArg>()))::value;
};
void
testIssue2085()
{
BOOST_STATIC_ASSERT((! set_test<field, int>::value));
BOOST_STATIC_ASSERT((! set_test<field, std::nullptr_t>::value));
BOOST_STATIC_ASSERT((! set_test<field, double>::value));
BOOST_STATIC_ASSERT((! set_test<string_view, int>::value));
BOOST_STATIC_ASSERT((! set_test<string_view, std::nullptr_t>::value));
BOOST_STATIC_ASSERT((! set_test<string_view, double>::value));
BOOST_STATIC_ASSERT(( set_test<field, const char*>::value));
BOOST_STATIC_ASSERT(( set_test<field, string_view>::value));
BOOST_STATIC_ASSERT(( set_test<field, const char(&)[10]>::value));
BOOST_STATIC_ASSERT(( set_test<string_view, const char*>::value));
BOOST_STATIC_ASSERT(( set_test<string_view, string_view>::value));
BOOST_STATIC_ASSERT(( set_test<string_view, const char(&)[10]>::value));
BOOST_STATIC_ASSERT((! insert_test<field, int>::value));
BOOST_STATIC_ASSERT((! insert_test<field, std::nullptr_t>::value));
BOOST_STATIC_ASSERT((! insert_test<field, double>::value));
BOOST_STATIC_ASSERT((! insert_test<string_view, int>::value));
BOOST_STATIC_ASSERT((! insert_test<string_view, std::nullptr_t>::value));
BOOST_STATIC_ASSERT((! insert_test<string_view, double>::value));
BOOST_STATIC_ASSERT(( insert_test<field, const char*>::value));
BOOST_STATIC_ASSERT(( insert_test<field, string_view>::value));
BOOST_STATIC_ASSERT(( insert_test<field, const char(&)[10]>::value));
BOOST_STATIC_ASSERT(( insert_test<string_view, const char*>::value));
BOOST_STATIC_ASSERT(( insert_test<string_view, string_view>::value));
BOOST_STATIC_ASSERT(( insert_test<string_view, const char(&)[10]>::value));
}
void
run() override
{
@@ -1020,6 +1086,7 @@ public:
testChunked();
testIssue1828();
boost::ignore_unused(&fields_test::testIssue2085);
}
};