feedc0de/boost_mqtt5
1
0
Fork 0
forked from boostorg/mqtt5
Code Pull Requests Activity

Remove unnecessary casts to unsigned types

Browse Source 
Summary: related to T12015

Reviewers: ivica

Reviewed By: ivica

Subscribers: miljen, iljazovic

Differential Revision: https://repo.mireo.local/D27927
This commit is contained in:
Korina Šimičević
2024-02-15 09:19:21 +01:00
parent 3454a180ff
commit 9cb54f73a4
5 changed files with 12 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
include/async_mqtt5/impl/assemble_op.hpp
View File

@ -153,13 +153,12 @@ public:
return complete(client::error::malformed_packet, 0, {}, {}); return complete(client::error::malformed_packet, 0, {}, {});
} }
auto recv_size = static_cast<size_t>( auto recv_size = _svc.connect_property(prop::maximum_packet_size)
_svc.connect_property(prop::maximum_packet_size).value_or(max_recv_size) .value_or(max_recv_size);
); if (static_cast<uint32_t>(*varlen) > recv_size - std::distance(_data_span.first(), first))
if (*varlen > recv_size - std::distance(_data_span.first(), first))
return complete(client::error::malformed_packet, 0, {}, {}); return complete(client::error::malformed_packet, 0, {}, {});
if (static_cast<uint32_t>(std::distance(first, _data_span.last())) < *varlen) if (std::distance(first, _data_span.last()) < *varlen)
return perform(asio::transfer_at_least(1)); return perform(asio::transfer_at_least(1));
_data_span.remove_prefix( _data_span.remove_prefix(

6
include/async_mqtt5/impl/disconnect_op.hpp
View File

@ -71,10 +71,8 @@ public:
static_cast<uint8_t>(_context.reason_code), _context.props static_cast<uint8_t>(_context.reason_code), _context.props
); );
auto max_packet_size = static_cast<size_t>( auto max_packet_size = _svc_ptr->connack_property(prop::maximum_packet_size)
_svc_ptr->connack_property(prop::maximum_packet_size) .value_or(default_max_send_size);
.value_or(default_max_send_size)
);
if (disconnect.size() > max_packet_size) if (disconnect.size() > max_packet_size)
// drop properties // drop properties
return send_disconnect(control_packet<allocator_type>::of( return send_disconnect(control_packet<allocator_type>::of(

6
include/async_mqtt5/impl/publish_send_op.hpp
View File

@ -116,10 +116,8 @@ public:
qos_type, retain, dup_e::no, props qos_type, retain, dup_e::no, props
); );
auto max_packet_size = static_cast<size_t>( auto max_packet_size = _svc_ptr->connack_property(prop::maximum_packet_size)
_svc_ptr->connack_property(prop::maximum_packet_size) .value_or(default_max_send_size);
.value_or(default_max_send_size)
);
if (publish.size() > max_packet_size) if (publish.size() > max_packet_size)
return complete_post(client::error::packet_too_large, packet_id); return complete_post(client::error::packet_too_large, packet_id);

6
include/async_mqtt5/impl/subscribe_op.hpp
View File

@ -92,10 +92,8 @@ public:
topics, props topics, props
); );
auto max_packet_size = static_cast<size_t>( auto max_packet_size = _svc_ptr->connack_property(prop::maximum_packet_size)
_svc_ptr->connack_property(prop::maximum_packet_size) .value_or(default_max_send_size);
.value_or(default_max_send_size)
);
if (subscribe.size() > max_packet_size) if (subscribe.size() > max_packet_size)
return complete_post(client::error::packet_too_large, packet_id); return complete_post(client::error::packet_too_large, packet_id);

6
include/async_mqtt5/impl/unsubscribe_op.hpp
View File

@ -87,10 +87,8 @@ public:
topics, props topics, props
); );
auto max_packet_size = static_cast<size_t>( auto max_packet_size = _svc_ptr->connack_property(prop::maximum_packet_size)
_svc_ptr->connack_property(prop::maximum_packet_size) .value_or(default_max_send_size);
.value_or(default_max_send_size)
);
if (unsubscribe.size() > max_packet_size) if (unsubscribe.size() > max_packet_size)
return complete_post(client::error::packet_too_large, packet_id); return complete_post(client::error::packet_too_large, packet_id);