Remove unused cnf parameter in client_service

Summary: related to T13709

Reviewers: ivica

Reviewed By: ivica

Subscribers: miljen, iljazovic

Differential Revision: https://repo.mireo.local/D27895

test/integration/async_sender.cpp

@@ -77,7 +77,7 @@ BOOST_FIXTURE_TEST_CASE(ordering_after_reconnect, shared_test_data) {
 	);
 
 	using client_type = mqtt_client<test::test_stream>;
-	client_type c(executor, "");
+	client_type c(executor);
 	c.brokers("127.0.0.1,127.0.0.1") // to avoid reconnect backoff
 		.async_run(asio::detached);
 
@@ -160,7 +160,7 @@ BOOST_FIXTURE_TEST_CASE(throttling, shared_test_data) {
 	);
 
 	using client_type = mqtt_client<test::test_stream>;
-	client_type c(executor, "");
+	client_type c(executor);
 	c.brokers("127.0.0.1")
 		.async_run(asio::detached);
 
@@ -218,7 +218,7 @@ BOOST_FIXTURE_TEST_CASE(prioritize_disconnect, shared_test_data) {
 	);
 
 	using client_type = mqtt_client<test::test_stream>;
-	client_type c(executor, "");
+	client_type c(executor);
 	c.brokers("127.0.0.1,127.0.0.1") // to avoid reconnect backoff
 		.async_run(asio::detached);
 

test/integration/cancellation.cpp

@@ -154,7 +154,7 @@ void run_cancel_op_test() {
 
 	asio::io_context ioc;
 	asio::cancellation_signal signal;
-	client_type c(ioc, "");
+	client_type c(ioc);
 	c.brokers("127.0.0.1");
 
 	setup_cancel_op_test_case<op_type>(c, signal, handlers_called);
@@ -271,7 +271,7 @@ BOOST_FIXTURE_TEST_CASE(rerunning_the_client, shared_test_data) {
 
 	co_spawn(ioc,
 		[&]() -> asio::awaitable<void> {
-			mqtt_client<test::test_stream> c(ioc, "");
+			mqtt_client<test::test_stream> c(ioc);
 			c.brokers("127.0.0.1,127.0.0.1", 1883) // to avoid reconnect backoff
 				.async_run(asio::detached);
 

test/integration/coroutine.cpp

@@ -110,7 +110,7 @@ BOOST_AUTO_TEST_CASE(tcp_client_check) {
 
 	using stream_type = asio::ip::tcp::socket;
 	using client_type = mqtt_client<stream_type>;
-	client_type c(ioc, "");
+	client_type c(ioc);
 
 	c.brokers("broker.hivemq.com", 1883)
 		.will({ "test/mqtt-test", "Client disconnected!", qos_e::at_least_once })
@@ -145,7 +145,7 @@ BOOST_AUTO_TEST_CASE(websocket_tcp_client_check) {
 	>;
 
 	using client_type = mqtt_client<stream_type>;
-	client_type c(ioc, "");
+	client_type c(ioc);
 
 	c.brokers("broker.hivemq.com/mqtt", 8000)
 		.will({ "test/mqtt-test", "Client disconnected!", qos_e::at_least_once })
@@ -180,7 +180,7 @@ BOOST_AUTO_TEST_CASE(openssl_tls_client_check) {
 	asio::ssl::context tls_context(asio::ssl::context::tls_client);
 
 	using client_type = mqtt_client<stream_type, decltype(tls_context)>;
-	client_type c(ioc, "", std::move(tls_context));
+	client_type c(ioc, std::move(tls_context));
 
 	c.brokers("broker.hivemq.com", 8883)
 		.will({ "test/mqtt-test", "Client disconnected!", qos_e::at_least_once })
@@ -217,7 +217,7 @@ BOOST_AUTO_TEST_CASE(websocket_tls_client_check) {
 	asio::ssl::context tls_context(asio::ssl::context::tls_client);
 
 	using client_type = mqtt_client<stream_type, decltype(tls_context)>;
-	client_type c(ioc, "", std::move(tls_context));
+	client_type c(ioc, std::move(tls_context));
 
 	c.brokers("broker.hivemq.com/mqtt", 8884)
 		.will({ "test/mqtt-test", "Client disconnected!", qos_e::at_least_once })

test/integration/executors.cpp

@@ -100,7 +100,7 @@ BOOST_AUTO_TEST_CASE(async_run) {
 	auto strand = asio::make_strand(ioc);
 
 	using client_type = mqtt_client<test::test_stream>;
-	client_type c(executor, "");
+	client_type c(executor);
 	c.brokers("127.0.0.1")
 		.async_run(asio::bind_executor(
 			strand,

test/integration/ping.cpp

@@ -56,7 +56,7 @@ void run_test(
 	);
 
 	using client_type = mqtt_client<test::test_stream>;
-	client_type c(executor, "");
+	client_type c(executor);
 	c.brokers("127.0.0.1,127.0.0.1") // to avoid reconnect backoff
 		.keep_alive(keep_alive)
 		.async_run(asio::detached);

test/integration/re_authentication.cpp

@@ -65,7 +65,7 @@ void run_test(
 	);
 
 	using client_type = mqtt_client<test::test_stream>;
-	client_type c(executor, "");
+	client_type c(executor);
 	c.brokers("127.0.0.1");
 
 	if constexpr (!std::is_same_v<Authenticator, std::monostate>)

test/integration/read_message.cpp

@@ -53,7 +53,7 @@ void test_receive_malformed_packet(
 	);
 
 	using client_type = mqtt_client<test::test_stream>;
-	client_type c(executor, "");
+	client_type c(executor);
 	c.brokers("127.0.0.1,127.0.0.1") // to avoid reconnect backoff
 		.async_run(asio::detached);
 
@@ -146,7 +146,7 @@ BOOST_FIXTURE_TEST_CASE(receive_disconnect, shared_test_data) {
 	);
 
 	using client_type = mqtt_client<test::test_stream>;
-	client_type c(executor, "");
+	client_type c(executor);
 	c.brokers("127.0.0.1,127.0.0.1") // to avoid reconnect backoff
 		.async_run(asio::detached);
 
@@ -173,7 +173,7 @@ void run_receive_test(
 	);
 
 	using client_type = mqtt_client<test::test_stream>;
-	client_type c(executor, "");
+	client_type c(executor);
 	c.brokers("127.0.0.1,127.0.0.1") // to avoid reconnect backoff
 		.async_run(asio::detached);
 

test/integration/receive_publish.cpp

@@ -63,7 +63,7 @@ void run_test(
 	);
 
 	using client_type = mqtt_client<test::test_stream>;
-	client_type c(executor, "");
+	client_type c(executor);
 	c.brokers("127.0.0.1,127.0.0.1") // to avoid reconnect backoff
 		.connect_properties(cprops)
 		.async_run(asio::detached);
@@ -376,7 +376,7 @@ BOOST_FIXTURE_TEST_CASE(receive_buffer_overflow, shared_test_data) {
 	);
 
 	using client_type = mqtt_client<test::test_stream>;
-	client_type c(executor, "");
+	client_type c(executor);
 	c.brokers("127.0.0.1")
 		.async_run(asio::detached);
 

test/integration/send_publish.cpp

@@ -62,7 +62,7 @@ void run_test(
 	);
 
 	using client_type = mqtt_client<test::test_stream>;
-	client_type c(executor, "");
+	client_type c(executor);
 	c.brokers("127.0.0.1,127.0.0.1") // to avoid reconnect backoff
 		.async_run(asio::detached);
 
@@ -506,7 +506,7 @@ BOOST_FIXTURE_TEST_CASE(cancel_resending_publish, shared_test_data) {
 	);
 
 	using client_type = mqtt_client<test::test_stream>;
-	client_type c(executor, "");
+	client_type c(executor);
 	c.brokers("127.0.0.1,127.0.0.1") // to avoid reconnect backoff
 		.async_run(asio::detached);
 
@@ -585,7 +585,7 @@ BOOST_FIXTURE_TEST_CASE(send_big_publish, shared_test_data) {
 	);
 
 	using client_type = mqtt_client<test::test_stream>;
-	client_type c(executor, "");
+	client_type c(executor);
 	c.brokers("127.0.0.1") // to avoid reconnect backoff
 		.async_run(asio::detached);
 

test/integration/sub_unsub.cpp

@@ -68,7 +68,7 @@ void run_test(test::msg_exchange broker_side) {
 	);
 
 	using client_type = mqtt_client<test::test_stream>;
-	client_type c(executor, "");
+	client_type c(executor);
 	c.brokers("127.0.0.1,127.0.0.1") // to avoid reconnect backoff
 		.async_run(asio::detached);
 
@@ -395,7 +395,7 @@ void run_cancellation_test(test::msg_exchange broker_side) {
 	);
 
 	using client_type = mqtt_client<test::test_stream>;
-	client_type c(executor, "");
+	client_type c(executor);
 	c.brokers("127.0.0.1,127.0.0.1") // to avoid reconnect backoff
 		.async_run(asio::detached);