feedc0de/boost_system
1
0
Fork 0
forked from boostorg/system
Code Pull Requests Activity

Enable -Wsuggest-override in warnings_test; add BOOST_OVERRIDE appropriately

Browse Source
This commit is contained in:
Peter Dimov
2020-06-17 01:06:40 +03:00
parent 63ac7fb9bc
commit 73bf30ae04
3 changed files with 16 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
include/boost/system/detail/std_interoperability.hpp
View File

@ -47,23 +47,23 @@ public:
} }
} }
virtual const char * name() const BOOST_NOEXCEPT const char * name() const BOOST_NOEXCEPT BOOST_OVERRIDE
{ {
return pc_->name(); return pc_->name();
} }
virtual std::string message( int ev ) const std::string message( int ev ) const BOOST_OVERRIDE
{ {
return pc_->message( ev ); return pc_->message( ev );
} }
virtual std::error_condition default_error_condition( int ev ) const BOOST_NOEXCEPT std::error_condition default_error_condition( int ev ) const BOOST_NOEXCEPT BOOST_OVERRIDE
{ {
return pc_->default_error_condition( ev ); return pc_->default_error_condition( ev );
} }
virtual bool equivalent( int code, const std::error_condition & condition ) const BOOST_NOEXCEPT; bool equivalent( int code, const std::error_condition & condition ) const BOOST_NOEXCEPT BOOST_OVERRIDE;
virtual bool equivalent( const std::error_code & code, int condition ) const BOOST_NOEXCEPT; bool equivalent( const std::error_code & code, int condition ) const BOOST_NOEXCEPT BOOST_OVERRIDE;
}; };
#if !defined(__SUNPRO_CC) // trailing __global is not supported #if !defined(__SUNPRO_CC) // trailing __global is not supported

14
include/boost/system/error_code.hpp
View File

@ -287,13 +287,13 @@ public:
{ {
} }
const char * name() const BOOST_NOEXCEPT const char * name() const BOOST_NOEXCEPT BOOST_OVERRIDE
{ {
return "generic"; return "generic";
} }
std::string message( int ev ) const; std::string message( int ev ) const BOOST_OVERRIDE;
char const * message( int ev, char * buffer, std::size_t len ) const BOOST_NOEXCEPT; char const * message( int ev, char * buffer, std::size_t len ) const BOOST_NOEXCEPT BOOST_OVERRIDE;
}; };
class BOOST_SYMBOL_VISIBLE system_error_category: public error_category class BOOST_SYMBOL_VISIBLE system_error_category: public error_category
@ -305,15 +305,15 @@ public:
{ {
} }
const char * name() const BOOST_NOEXCEPT const char * name() const BOOST_NOEXCEPT BOOST_OVERRIDE
{ {
return "system"; return "system";
} }
error_condition default_error_condition( int ev ) const BOOST_NOEXCEPT; error_condition default_error_condition( int ev ) const BOOST_NOEXCEPT BOOST_OVERRIDE;
std::string message( int ev ) const; std::string message( int ev ) const BOOST_OVERRIDE;
char const * message( int ev, char * buffer, std::size_t len ) const BOOST_NOEXCEPT; char const * message( int ev, char * buffer, std::size_t len ) const BOOST_NOEXCEPT BOOST_OVERRIDE;
}; };
} // namespace detail } // namespace detail

4
test/warnings_test.cpp
View File

@ -8,6 +8,10 @@
// See library home page at http://www.boost.org/libs/system // See library home page at http://www.boost.org/libs/system
#if defined(__GNUC__) && __GNUC__ >= 5 && __cplusplus >= 201103L
# pragma GCC diagnostic error "-Wsuggest-override"
#endif
#include <boost/config.hpp> #include <boost/config.hpp>
#if defined( BOOST_GCC ) && BOOST_GCC < 40600 #if defined( BOOST_GCC ) && BOOST_GCC < 40600