feedc0de/boost_unordered
1
0
Fork 0
forked from boostorg/unordered
Code Pull Requests Activity

Fix a bug that was causing unnecessary rehahes.

Browse Source 
[SVN r56348]
This commit is contained in:
Daniel James
2009-09-21 21:18:01 +00:00
parent ff6e457651
commit 08d533cb88
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
include/boost/unordered/detail/table.hpp
View File

@ -443,23 +443,19 @@ namespace boost { namespace unordered_detail {
this->create_buckets(); this->create_buckets();
this->init_buckets(); this->init_buckets();
} }
// TODO: Another bug: else {
else if(min_buckets != this->bucket_count_) {
// no throw: // no throw:
// TODO: Needlessly calling next_prime twice. // TODO: Needlessly calling next_prime twice.
std::size_t min_size = this->min_buckets_for_size(this->size_); std::size_t min_size = this->min_buckets_for_size(this->size_);
min_buckets = next_prime(min_buckets); min_buckets = next_prime(min_buckets);
min_buckets = min_size > min_buckets ? min_size : min_buckets; min_buckets = min_size > min_buckets ? min_size : min_buckets;
if(min_buckets != this->bucket_count_) rehash_impl(min_buckets);
rehash_impl(min_buckets);
} }
} }
// if hash function throws, basic exception safety // if hash function throws, basic exception safety
// strong otherwise // strong otherwise
// TODO: Rewrite so that it doesn't need to keep updating size_.
template <class H, class P, class A, class G, class K> template <class H, class P, class A, class G, class K>
void hash_table<H, P, A, G, K> void hash_table<H, P, A, G, K>
::rehash_impl(std::size_t num_buckets) ::rehash_impl(std::size_t num_buckets)