feedc0de/boost_unordered
1
0
Fork 0
forked from boostorg/unordered
Code Pull Requests Activity

Add policy check that excludes unsequenced policies

Browse Source 
It's technically UB for the callable in an unsequenced policy to acquire a lock so we add static_assert()s to catch potential user error.
This commit is contained in:
Christian Mazakas
2023-05-01 11:58:58 -07:00
parent 615ce1e9b6
commit c52ad849ea
3 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/cfoa/erase_tests.cpp
+1 -1
View File
@@ -281,7 +281,7 @@ namespace {
thread_runner(values, [&num_invokes, &x, threshold](boost::span<T> s) {
(void)s;
x.erase_if(
std::execution::par_unseq, [&num_invokes, threshold](value_type& v) {
std::execution::par, [&num_invokes, threshold](value_type& v) {
++num_invokes;
return v.second.x_ > threshold;
});
test/cfoa/visit_tests.cpp
+3 -3
View File
@@ -299,7 +299,7 @@ namespace {
thread_runner(values, [&x, &mut_visitor](boost::span<T>) {
std::atomic<std::uint64_t> num_visits{0};
x.visit_all(std::execution::par_unseq, mut_visitor(num_visits));
x.visit_all(std::execution::par, mut_visitor(num_visits));
BOOST_TEST_EQ(x.size(), num_visits);
});
}
@@ -309,7 +309,7 @@ namespace {
std::atomic<std::uint64_t> num_visits{0};
auto const& y = x;
y.visit_all(std::execution::par_unseq, const_visitor(num_visits));
y.visit_all(std::execution::par, const_visitor(num_visits));
BOOST_TEST_EQ(x.size(), num_visits);
});
}
@@ -317,7 +317,7 @@ namespace {
{
thread_runner(values, [&x, &const_visitor](boost::span<T>) {
std::atomic<std::uint64_t> num_visits{0};
x.cvisit_all(std::execution::par_unseq, const_visitor(num_visits));
x.cvisit_all(std::execution::par, const_visitor(num_visits));
BOOST_TEST_EQ(x.size(), num_visits);
});
}