feedc0de/date
1
0
Fork 0
forked from HowardHinnant/date
Code Pull Requests Activity

Removed undefined behavioir from year_mont_day_last::day (#456)

Browse Source 
This is done to make the result of calling day() on
year_month_day_last object that is !ok() unspecified.
Checked only months, are there are needed to avoid UB.
This commit is contained in:
tomaszkam
2019-05-28 15:01:14 +02:00
committed by Howard Hinnant
parent 7817ebf45a
commit 27d1e1e54e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/date/date.h
View File

@@ -7,7 +7,7 @@
// Copyright (c) 2016 Adrian Colomitchi // Copyright (c) 2016 Adrian Colomitchi
// Copyright (c) 2017 Florian Dang // Copyright (c) 2017 Florian Dang
// Copyright (c) 2017 Paul Thompson // Copyright (c) 2017 Paul Thompson
// Copyright (c) 2018 Tomasz Kamiński // Copyright (c) 2018, 2019 Tomasz Kamiński
// //
// Permission is hereby granted, free of charge, to any person obtaining a copy // Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal // of this software and associated documentation files (the "Software"), to deal
@@ -2536,7 +2536,7 @@ year_month_day_last::day() const NOEXCEPT
date::day(31), date::day(31), date::day(30), date::day(31), date::day(31), date::day(30),
date::day(31), date::day(30), date::day(31) date::day(31), date::day(30), date::day(31)
}; };
return month() != February || !y_.is_leap() ? return (month() != February || !y_.is_leap()) && mdl_.ok() ?
d[static_cast<unsigned>(month()) - 1] : date::day{29}; d[static_cast<unsigned>(month()) - 1] : date::day{29};
} }