2014-11-13 23:26:49 +01:00
|
|
|
// Copyright 2014 Dolphin Emulator Project
|
2021-07-05 03:22:19 +02:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
2014-11-13 23:26:49 +01:00
|
|
|
|
2020-09-15 05:00:24 -07:00
|
|
|
#include "VideoBackends/OGL/OGLBoundingBox.h"
|
2021-06-09 07:42:21 -04:00
|
|
|
|
2020-09-15 05:00:24 -07:00
|
|
|
#include "VideoBackends/OGL/OGLRender.h"
|
2016-05-11 22:19:59 +10:00
|
|
|
#include "VideoCommon/DriverDetails.h"
|
2014-11-13 23:26:49 +01:00
|
|
|
|
|
|
|
|
namespace OGL
|
|
|
|
|
{
|
2021-06-09 07:42:21 -04:00
|
|
|
OGLBoundingBox::~OGLBoundingBox()
|
OGL: implement Bounding Box on systems w/o SSBO
This commit should have zero performance effect if SSBOs are supported.
If they aren't (e.g. on all Macs), this commit alters FramebufferManager
to attach a new stencil buffer and VertexManager to draw to it when
bounding box is active. `BBoxRead` gets the pixel data from the buffer
and dumbly loops through it to find the bounding box.
This patch can run Paper Mario: The Thousand-Year Door at almost full
speed (50–60 FPS) without Dual-Core enabled for all common bounding
box-using actions I tested (going through pipes, Plane Mode, Paper
Mode, Prof. Frankly's gate, combat, walking around the overworld, etc.)
on my computer (macOS 10.12.3, 2.8 GHz Intel Core i7, 16 GB 1600 MHz
DDR3, and Intel Iris 1536 MB).
A few more demanding scenes (e.g. the self-building bridge on the way
to Petalburg) slow to ~15% of their speed without this patch (though
they don't run quite at full speed even on master). The slowdown is
caused almost solely by `glReadPixels` in `OGL::BoundingBox::Get`.
Other implementation ideas:
- Use a stencil buffer that's separate from the depth buffer. This would
require ARB_texture_stencil8 / OpenGL 4.4, which isn't available on
macOS.
- Use `glGetTexImage` instead of `glReadPixels`. This is ~5 FPS slower
on my computer, presumably because it has to transfer the entire
combined depth-stencil buffer instead of only the stencil data.
Getting only stencil data from `glGetTexImage` requires
ARB_texture_stencil8 / OpenGL 4.4, which (again) is not available on
macOS.
- Don't use a PBO, and use `glReadPixels` synchronously. This has no
visible performance effect on my computer, and is theoretically
slower.
2017-03-05 15:34:30 -08:00
|
|
|
{
|
2021-06-09 07:42:21 -04:00
|
|
|
if (m_buffer_id)
|
|
|
|
|
glDeleteBuffers(1, &m_buffer_id);
|
|
|
|
|
}
|
OGL: implement Bounding Box on systems w/o SSBO
This commit should have zero performance effect if SSBOs are supported.
If they aren't (e.g. on all Macs), this commit alters FramebufferManager
to attach a new stencil buffer and VertexManager to draw to it when
bounding box is active. `BBoxRead` gets the pixel data from the buffer
and dumbly loops through it to find the bounding box.
This patch can run Paper Mario: The Thousand-Year Door at almost full
speed (50–60 FPS) without Dual-Core enabled for all common bounding
box-using actions I tested (going through pipes, Plane Mode, Paper
Mode, Prof. Frankly's gate, combat, walking around the overworld, etc.)
on my computer (macOS 10.12.3, 2.8 GHz Intel Core i7, 16 GB 1600 MHz
DDR3, and Intel Iris 1536 MB).
A few more demanding scenes (e.g. the self-building bridge on the way
to Petalburg) slow to ~15% of their speed without this patch (though
they don't run quite at full speed even on master). The slowdown is
caused almost solely by `glReadPixels` in `OGL::BoundingBox::Get`.
Other implementation ideas:
- Use a stencil buffer that's separate from the depth buffer. This would
require ARB_texture_stencil8 / OpenGL 4.4, which isn't available on
macOS.
- Use `glGetTexImage` instead of `glReadPixels`. This is ~5 FPS slower
on my computer, presumably because it has to transfer the entire
combined depth-stencil buffer instead of only the stencil data.
Getting only stencil data from `glGetTexImage` requires
ARB_texture_stencil8 / OpenGL 4.4, which (again) is not available on
macOS.
- Don't use a PBO, and use `glReadPixels` synchronously. This has no
visible performance effect on my computer, and is theoretically
slower.
2017-03-05 15:34:30 -08:00
|
|
|
|
2021-06-09 07:42:21 -04:00
|
|
|
bool OGLBoundingBox::Initialize()
|
|
|
|
|
{
|
|
|
|
|
const BBoxType initial_values[NUM_BBOX_VALUES] = {0, 0, 0, 0};
|
2021-04-18 03:14:52 +10:00
|
|
|
|
2021-06-09 07:42:21 -04:00
|
|
|
glGenBuffers(1, &m_buffer_id);
|
|
|
|
|
glBindBuffer(GL_SHADER_STORAGE_BUFFER, m_buffer_id);
|
2021-04-18 03:14:52 +10:00
|
|
|
glBufferData(GL_SHADER_STORAGE_BUFFER, sizeof(initial_values), initial_values, GL_DYNAMIC_DRAW);
|
2021-06-09 07:42:21 -04:00
|
|
|
glBindBufferBase(GL_SHADER_STORAGE_BUFFER, 0, m_buffer_id);
|
|
|
|
|
|
|
|
|
|
return true;
|
2014-11-13 23:26:49 +01:00
|
|
|
}
|
|
|
|
|
|
2021-06-09 07:42:21 -04:00
|
|
|
std::vector<BBoxType> OGLBoundingBox::Read(u32 index, u32 length)
|
2014-11-13 23:26:49 +01:00
|
|
|
{
|
2021-06-09 07:42:21 -04:00
|
|
|
std::vector<BBoxType> values(length);
|
|
|
|
|
glBindBuffer(GL_SHADER_STORAGE_BUFFER, m_buffer_id);
|
2021-05-29 16:50:33 +10:00
|
|
|
|
|
|
|
|
// Using glMapBufferRange to read back the contents of the SSBO is extremely slow
|
|
|
|
|
// on nVidia drivers. This is more noticeable at higher internal resolutions.
|
|
|
|
|
// Using glGetBufferSubData instead does not seem to exhibit this slowdown.
|
2019-02-15 11:59:50 +10:00
|
|
|
if (!DriverDetails::HasBug(DriverDetails::BUG_SLOW_GETBUFFERSUBDATA) &&
|
|
|
|
|
!static_cast<Renderer*>(g_renderer.get())->IsGLES())
|
2014-11-13 23:26:49 +01:00
|
|
|
{
|
2021-05-29 16:50:33 +10:00
|
|
|
// We also need to ensure the the CPU does not receive stale values which have been updated by
|
|
|
|
|
// the GPU. Apparently the buffer here is not coherent on NVIDIA drivers. Not sure if this is a
|
|
|
|
|
// driver bug/spec violation or not, one would think that glGetBufferSubData() would invalidate
|
|
|
|
|
// any caches as needed, but this path is only used on NVIDIA anyway, so it's fine. A point to
|
|
|
|
|
// note is that according to ARB_debug_report, it's moved from video to host memory, which would
|
|
|
|
|
// explain why it needs the cache invalidate.
|
|
|
|
|
glMemoryBarrier(GL_SHADER_STORAGE_BARRIER_BIT);
|
|
|
|
|
|
2021-06-09 07:42:21 -04:00
|
|
|
glGetBufferSubData(GL_SHADER_STORAGE_BUFFER, sizeof(BBoxType) * index,
|
|
|
|
|
sizeof(BBoxType) * length, values.data());
|
2014-11-13 23:26:49 +01:00
|
|
|
}
|
2016-05-11 22:19:59 +10:00
|
|
|
else
|
|
|
|
|
{
|
2019-02-15 11:59:50 +10:00
|
|
|
// Using glMapBufferRange is faster on AMD cards by a measurable margin.
|
2021-06-09 07:42:21 -04:00
|
|
|
void* ptr = glMapBufferRange(GL_SHADER_STORAGE_BUFFER, 0, sizeof(BBoxType) * NUM_BBOX_VALUES,
|
2019-02-15 11:59:50 +10:00
|
|
|
GL_MAP_READ_BIT);
|
|
|
|
|
if (ptr)
|
2016-05-11 22:19:59 +10:00
|
|
|
{
|
2021-06-09 07:42:21 -04:00
|
|
|
std::memcpy(values.data(), reinterpret_cast<const u8*>(ptr) + sizeof(BBoxType) * index,
|
|
|
|
|
sizeof(BBoxType) * length);
|
2021-04-18 03:14:52 +10:00
|
|
|
|
2019-02-15 11:59:50 +10:00
|
|
|
glUnmapBuffer(GL_SHADER_STORAGE_BUFFER);
|
OGL: implement Bounding Box on systems w/o SSBO
This commit should have zero performance effect if SSBOs are supported.
If they aren't (e.g. on all Macs), this commit alters FramebufferManager
to attach a new stencil buffer and VertexManager to draw to it when
bounding box is active. `BBoxRead` gets the pixel data from the buffer
and dumbly loops through it to find the bounding box.
This patch can run Paper Mario: The Thousand-Year Door at almost full
speed (50–60 FPS) without Dual-Core enabled for all common bounding
box-using actions I tested (going through pipes, Plane Mode, Paper
Mode, Prof. Frankly's gate, combat, walking around the overworld, etc.)
on my computer (macOS 10.12.3, 2.8 GHz Intel Core i7, 16 GB 1600 MHz
DDR3, and Intel Iris 1536 MB).
A few more demanding scenes (e.g. the self-building bridge on the way
to Petalburg) slow to ~15% of their speed without this patch (though
they don't run quite at full speed even on master). The slowdown is
caused almost solely by `glReadPixels` in `OGL::BoundingBox::Get`.
Other implementation ideas:
- Use a stencil buffer that's separate from the depth buffer. This would
require ARB_texture_stencil8 / OpenGL 4.4, which isn't available on
macOS.
- Use `glGetTexImage` instead of `glReadPixels`. This is ~5 FPS slower
on my computer, presumably because it has to transfer the entire
combined depth-stencil buffer instead of only the stencil data.
Getting only stencil data from `glGetTexImage` requires
ARB_texture_stencil8 / OpenGL 4.4, which (again) is not available on
macOS.
- Don't use a PBO, and use `glReadPixels` synchronously. This has no
visible performance effect on my computer, and is theoretically
slower.
2017-03-05 15:34:30 -08:00
|
|
|
}
|
|
|
|
|
}
|
2021-06-09 07:42:21 -04:00
|
|
|
|
2019-02-15 11:59:50 +10:00
|
|
|
glBindBuffer(GL_SHADER_STORAGE_BUFFER, 0);
|
2021-06-09 07:42:21 -04:00
|
|
|
return values;
|
2021-04-18 03:14:52 +10:00
|
|
|
}
|
|
|
|
|
|
2021-06-09 07:42:21 -04:00
|
|
|
void OGLBoundingBox::Write(u32 index, const std::vector<BBoxType>& values)
|
2021-04-18 03:14:52 +10:00
|
|
|
{
|
2021-06-09 07:42:21 -04:00
|
|
|
glBindBuffer(GL_SHADER_STORAGE_BUFFER, m_buffer_id);
|
|
|
|
|
glBufferSubData(GL_SHADER_STORAGE_BUFFER, sizeof(BBoxType) * index,
|
|
|
|
|
sizeof(BBoxType) * values.size(), values.data());
|
|
|
|
|
glBindBuffer(GL_SHADER_STORAGE_BUFFER, 0);
|
2021-04-18 03:14:52 +10:00
|
|
|
}
|
|
|
|
|
|
2021-06-09 07:42:21 -04:00
|
|
|
} // namespace OGL
|