diff --git a/components/esp_wifi/lib b/components/esp_wifi/lib index a7fd728686..7e0183b653 160000 --- a/components/esp_wifi/lib +++ b/components/esp_wifi/lib @@ -1 +1 @@ -Subproject commit a7fd728686a430d7834fffd1264e43f2f2e4383e +Subproject commit 7e0183b653a13e800eeddaa9c2682ee131e1435c diff --git a/components/wpa_supplicant/src/common/defs.h b/components/wpa_supplicant/src/common/defs.h index 4906ff6123..78d6665848 100644 --- a/components/wpa_supplicant/src/common/defs.h +++ b/components/wpa_supplicant/src/common/defs.h @@ -114,6 +114,13 @@ static inline int wpa_key_mgmt_cckm(int akm) return akm == WPA_KEY_MGMT_CCKM; } +#ifdef ESP_SUPPLICANT +static inline int wpa_key_mgmt_supports_caching(int akm) +{ + return wpa_key_mgmt_wpa_ieee8021x(akm) || + wpa_key_mgmt_sae(akm); +} +#endif #define WPA_PROTO_WPA BIT(0) #define WPA_PROTO_RSN BIT(1) diff --git a/components/wpa_supplicant/src/esp_supplicant/esp_wpa3.c b/components/wpa_supplicant/src/esp_supplicant/esp_wpa3.c index 6bb5bd87d2..dfa5ce31f4 100644 --- a/components/wpa_supplicant/src/esp_supplicant/esp_wpa3.c +++ b/components/wpa_supplicant/src/esp_supplicant/esp_wpa3.c @@ -25,7 +25,7 @@ static struct wpabuf *g_sae_commit = NULL; static struct wpabuf *g_sae_confirm = NULL; int g_allowed_groups[] = { IANA_SECP256R1, 0 }; -static esp_err_t wpa3_build_sae_commit(u8 *bssid) +static esp_err_t wpa3_build_sae_commit(u8 *bssid, size_t *sae_msg_len) { int default_group = IANA_SECP256R1; u32 len = 0; @@ -34,6 +34,7 @@ static esp_err_t wpa3_build_sae_commit(u8 *bssid) if (wpa_sta_cur_pmksa_matches_akm()) { wpa_printf(MSG_INFO, "wpa3: Skip SAE and use cached PMK instead"); + *sae_msg_len = 0; return ESP_FAIL; } @@ -140,7 +141,7 @@ static u8 *wpa3_build_sae_msg(u8 *bssid, u32 sae_msg_type, u32 *sae_msg_len) if (esp_wifi_get_wps_status_internal() != WPS_STATUS_DISABLE) { return NULL; } - if (ESP_OK != wpa3_build_sae_commit(bssid)) + if (ESP_OK != wpa3_build_sae_commit(bssid, sae_msg_len)) return NULL; *sae_msg_len = (u32)wpabuf_len(g_sae_commit); buf = wpabuf_mhead_u8(g_sae_commit); diff --git a/components/wpa_supplicant/src/rsn_supp/wpa.c b/components/wpa_supplicant/src/rsn_supp/wpa.c index 5e2c79888f..b8cd3da2c5 100644 --- a/components/wpa_supplicant/src/rsn_supp/wpa.c +++ b/components/wpa_supplicant/src/rsn_supp/wpa.c @@ -2144,7 +2144,7 @@ int wpa_set_bss(char *macddr, char * bssid, u8 pairwise_cipher, u8 group_cipher, { int res = 0; struct wpa_sm *sm = &gWpaSm; - bool use_pmk_cache = true; + bool use_pmk_cache = !esp_wifi_skip_supp_pmkcaching(); /* Incase AP has changed it's SSID, don't try with PMK caching for SAE connection */ if ((sm->key_mgmt == WPA_KEY_MGMT_SAE) && @@ -2163,27 +2163,19 @@ int wpa_set_bss(char *macddr, char * bssid, u8 pairwise_cipher, u8 group_cipher, sm->ap_notify_completed_rsne = esp_wifi_sta_is_ap_notify_completed_rsne_internal(); sm->use_ext_key_id = (sm->proto == WPA_PROTO_WPA); - if (sm->key_mgmt == WPA_KEY_MGMT_SAE || - is_wpa2_enterprise_connection()) { - if (!esp_wifi_skip_supp_pmkcaching() && use_pmk_cache) { - if (pmksa_cache_set_current(sm, NULL, (const u8*) bssid, 0, 0) == 0) { - struct rsn_pmksa_cache_entry *pmksa = pmksa_cache_get_current(sm); - if (pmksa && (pmksa->akmp != sm->key_mgmt)) { - pmksa_cache_clear_current(sm); - pmksa_cache_flush(sm->pmksa, NULL, pmksa->pmk, pmksa->pmk_len); - } - } else { - wpa_sm_set_pmk_from_pmksa(sm); - } - } else { - struct rsn_pmksa_cache_entry *entry = NULL; - - if (sm->pmksa) { - entry = pmksa_cache_get(sm->pmksa, (const u8 *)bssid, NULL, NULL); - } - if (entry) { - pmksa_cache_flush(sm->pmksa, NULL, entry->pmk, entry->pmk_len); - } + struct rsn_pmksa_cache_entry *pmksa = NULL; + if (use_pmk_cache) { + pmksa = pmksa_cache_get(sm->pmksa, (const u8 *)bssid, NULL, NULL); + if (pmksa && (pmksa->akmp != sm->key_mgmt)) { + use_pmk_cache = false; + } + } + if (wpa_key_mgmt_supports_caching(sm->key_mgmt) && use_pmk_cache) { + pmksa_cache_set_current(sm, NULL, (const u8*) bssid, 0, 0); + wpa_sm_set_pmk_from_pmksa(sm); + } else { + if (pmksa) { + pmksa_cache_flush(sm->pmksa, NULL, pmksa->pmk, pmksa->pmk_len); } }