From 9c0cd10d4885a03d4cb97a323c88ca7dd96555eb Mon Sep 17 00:00:00 2001
From: Angus Gratton <angus@espressif.com>
Date: Tue, 4 Oct 2016 12:37:10 +1100
Subject: [PATCH 1/8] Build system tests: Add test cases for out-of-tree builds
 (currently failing)

See github #38
---
 make/test_build_system.sh | 24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)

diff --git a/make/test_build_system.sh b/make/test_build_system.sh
index 5be1504e3d..b6aaa9e58f 100755
--- a/make/test_build_system.sh
+++ b/make/test_build_system.sh
@@ -62,7 +62,7 @@ function run_tests()
 	print_status "Partition CSV file rebuilds partitions"
 	take_build_snapshot
 	touch ${IDF_PATH}/components/partition_table/partitions_singleapp.csv
-	make partition_table
+	make partition_table || failure "Failed to build partition table"
 	assert_rebuilt partitions_singleapp.bin
 	assert_not_rebuilt app-template.bin app-template.elf ${BOOTLOADER_BINS}
 
@@ -70,18 +70,31 @@ function run_tests()
 	take_build_snapshot
 	# verify no build files are refreshed by a partial make
 	ALL_BUILD_FILES=$(find ${BUILD} -type f | sed "s@${BUILD}/@@")
-	make
+	make || failure "Partial build failed"
 	assert_not_rebuilt ${ALL_BUILD_FILES}
 
 	print_status "Cleaning should remove all files from build"
-	make clean
+	make clean || failure "Failed to make clean"
 	ALL_BUILD_FILES=$(find ${BUILD} -type f)
 	if [ -n "${ALL_BUILD_FILES}" ]; then
 		 failure "Files weren't cleaned: ${ALL_BUILD_FILES}"
 	fi
 
+	print_status "Moving BUILD_DIR_BASE out of tree should still build OK"
+	rm -rf --preserve-root ${BUILD}/*
+	OUTOFTREE_BUILD=${TESTDIR}/alt_build
+	make BUILD_DIR_BASE=${OUTOFTREE_BUILD} || failure "Failed to build with BUILD_DIR_BASE overriden"
+	NEW_BUILD_FILES=$(find ${OUTOFREE_BUILD} -type f)
+	if [ -z "${NEW_BUILD_FILES}" ]; then
+		failure "No files found in new build directory!"
+	fi
+	DEFAULT_BUILD_FILES=$(find ${BUILD} -mindepth 1)
+	if [ -n "${DEFAULT_BUILD_FILES}" ]; then
+		failure "Some files were incorrectly put into the default build directory: ${DEFAULT_BUILD_FILES}"
+	fi
+
 	print_status "Can still clean build if all text files are CRLFs"
-	make clean
+	make clean || failure "Unexpected failure to make clean"
 	find . -exec unix2dos {} \; # CRLFify template dir
 	# make a copy of esp-idf and CRLFify it
 	CRLF_ESPIDF=${TESTDIR}/esp-idf-crlf
@@ -89,12 +102,11 @@ function run_tests()
 	cp -rv ${IDF_PATH}/* ${CRLF_ESPIDF}
 	# don't CRLFify executable files, as Linux will fail to execute them
 	find ${CRLF_ESPIDF} -type f ! -perm 755 -exec unix2dos {} \;
-	make IDF_PATH=${CRLF_ESPIDF}
+	make IDF_PATH=${CRLF_ESPIDF} || failure "Failed to build with CRLFs in source"
 	# do the same checks we do for the clean build
 	assert_built ${APP_BINS} ${BOOTLOADER_BINS} partitions_singleapp.bin
 	[ -f ${BUILD}/partition*.bin ] || failure "A partition table should have been built in CRLF mode"
 
-	# NOTE: If adding new tests, add them above this CRLF test...
 
 	print_status "All tests completed"
 	if [ -n "${FAILURES}" ]; then

From 66882347e86e142ba0c72c8c3e6fe1a946a25a78 Mon Sep 17 00:00:00 2001
From: Angus Gratton <angus@espressif.com>
Date: Tue, 4 Oct 2016 15:03:48 +1100
Subject: [PATCH 2/8] build system: Fix out-of-tree building via BUILD_DIR_BASE

Closes #38
---
 components/bootloader/Makefile.projbuild | 16 +++++-----
 components/esp32/component.mk            |  4 ++-
 make/common.mk                           |  2 +-
 make/project.mk                          |  3 +-
 make/project_config.mk                   | 38 ++++++++++--------------
 5 files changed, 31 insertions(+), 32 deletions(-)

diff --git a/components/bootloader/Makefile.projbuild b/components/bootloader/Makefile.projbuild
index d45cf144e7..7c5cde3b8c 100644
--- a/components/bootloader/Makefile.projbuild
+++ b/components/bootloader/Makefile.projbuild
@@ -14,17 +14,18 @@ BOOTLOADER_COMPONENT_PATH := $(COMPONENT_PATH)
 BOOTLOADER_BUILD_DIR=$(BUILD_DIR_BASE)/bootloader
 BOOTLOADER_BIN=$(BOOTLOADER_BUILD_DIR)/bootloader.bin
 
+# Custom recursive make for bootloader sub-project
+BOOTLOADER_MAKE=$(MAKE) -C $(BOOTLOADER_COMPONENT_PATH)/src \
+	MAKEFLAGS= V=$(V) \
+	BUILD_DIR_BASE=$(BOOTLOADER_BUILD_DIR) \
+
 .PHONY: bootloader-clean bootloader-flash bootloader $(BOOTLOADER_BIN)
 
 $(BOOTLOADER_BIN): $(COMPONENT_PATH)/src/sdkconfig
-	$(Q) PROJECT_PATH= \
-	BUILD_DIR_BASE=$(BOOTLOADER_BUILD_DIR) \
-	$(MAKE) -C $(BOOTLOADER_COMPONENT_PATH)/src MAKEFLAGS= V=$(V) TARGET_BIN_LAYOUT="$(BOOTLOADER_TARGET_BIN_LAYOUT)" $(BOOTLOADER_BIN)
+	$(Q) $(BOOTLOADER_MAKE) $@
 
 bootloader-clean:
-	$(Q) PROJECT_PATH= \
-	BUILD_DIR_BASE=$(BOOTLOADER_BUILD_DIR) \
-	$(MAKE) -C $(BOOTLOADER_COMPONENT_PATH)/src app-clean MAKEFLAGS= V=$(V)
+	$(Q) $(BOOTLOADER_MAKE) app-clean
 
 clean: bootloader-clean
 
@@ -43,7 +44,8 @@ $(COMPONENT_PATH)/src/sdkconfig: $(PROJECT_PATH)/sdkconfig
 
 # bootloader-flash calls flash in the bootloader dummy project
 bootloader-flash: $(BOOTLOADER_BIN)
-	$(MAKE) -C $(BOOTLOADER_COMPONENT_PATH)/src flash MAKEFLAGS= V=$(V)
+	$(BOOTLOADER_MAKE) flash
+
 
 else
 CFLAGS += -D BOOTLOADER_BUILD=1 -I $(IDF_PATH)/components/esp32/include 
diff --git a/components/esp32/component.mk b/components/esp32/component.mk
index 6eac77afd3..85040d77a0 100644
--- a/components/esp32/component.mk
+++ b/components/esp32/component.mk
@@ -6,7 +6,7 @@
 # lib(subdirectory_name).a in the build directory. This behaviour is entirely configurable,
 # please read the esp-idf build system document if you need to do this.
 #
--include $(PROJECT_PATH)/build/include/config/auto.conf
+-include $(BUILD_DIR_BASE)/include/config/auto.conf
 
 COMPONENT_SRCDIRS := . hwcrypto
 
@@ -44,6 +44,8 @@ $(COMPONENT_LIBRARY): $(ALL_LIB_FILES)
 # saves us from having to add the target to a Makefile.projbuild
 $(COMPONENT_LIBRARY): esp32_out.ld
 
+# .. is BUILD_DIR_BASE here, as component makefiles
+# are evaluated with CWD=component build dir
 esp32_out.ld: $(COMPONENT_PATH)/ld/esp32.ld ../include/sdkconfig.h
 	$(CC) -I ../include -C -P -x c -E $< -o $@
 
diff --git a/make/common.mk b/make/common.mk
index a515584a9b..b2917d5c96 100644
--- a/make/common.mk
+++ b/make/common.mk
@@ -6,7 +6,7 @@
 #
 # (Note that we only rebuild auto.conf automatically for some targets,
 # see project_config.mk for details.)
--include $(PROJECT_PATH)/build/include/config/auto.conf
+-include $(BUILD_DIR_BASE)/include/config/auto.conf
 
 #Handling of V=1/VERBOSE=1 flag
 #
diff --git a/make/project.mk b/make/project.mk
index 35dccaf248..74943334a6 100644
--- a/make/project.mk
+++ b/make/project.mk
@@ -50,6 +50,7 @@ endif
 #The directory where we put all objects/libraries/binaries. The project Makefile can
 #configure this if needed.
 BUILD_DIR_BASE ?= $(PROJECT_PATH)/build
+export BUILD_DIR_BASE
 
 #Component directories. These directories are searched for components.
 #The project Makefile can override these component dirs, or define extra component directories.
@@ -105,7 +106,7 @@ COMPONENT_INCLUDES := $(abspath $(foreach comp,$(COMPONENT_PATHS_BUILDABLE),$(ad
 	$(call GetVariable,$(comp),COMPONENT_ADD_INCLUDEDIRS))))
 
 #Also add project include path, for sdk includes
-COMPONENT_INCLUDES += $(PROJECT_PATH)/build/include/
+COMPONENT_INCLUDES += $(BUILD_DIR_BASE)/include/
 export COMPONENT_INCLUDES
 
 #COMPONENT_LDFLAGS has a list of all flags that are needed to link the components together. It's collected
diff --git a/make/project_config.mk b/make/project_config.mk
index d2909bb308..92937e8bfe 100644
--- a/make/project_config.mk
+++ b/make/project_config.mk
@@ -13,13 +13,15 @@ $(KCONFIG_TOOL_DIR)/mconf $(KCONFIG_TOOL_DIR)/conf:
 	CC=$(HOSTCC) LD=$(HOSTLD) \
 	$(MAKE) -C $(KCONFIG_TOOL_DIR)
 
-menuconfig: $(KCONFIG_TOOL_DIR)/mconf $(IDF_PATH)/Kconfig $(BUILD_DIR_BASE)
-	$(summary) MENUCONFIG
-	$(Q) KCONFIG_AUTOHEADER=$(PROJECT_PATH)/build/include/sdkconfig.h \
+# use a wrapper environment for where we run Kconfig tools
+KCONFIG_TOOL_ENV=KCONFIG_AUTOHEADER=$(BUILD_DIR_BASE)/include/sdkconfig.h \
 	KCONFIG_CONFIG=$(PROJECT_PATH)/sdkconfig \
 	COMPONENT_KCONFIGS="$(COMPONENT_KCONFIGS)" \
-	COMPONENT_KCONFIGS_PROJBUILD="$(COMPONENT_KCONFIGS_PROJBUILD)" \
-	$(KCONFIG_TOOL_DIR)/mconf $(IDF_PATH)/Kconfig
+	COMPONENT_KCONFIGS_PROJBUILD="$(COMPONENT_KCONFIGS_PROJBUILD)"
+
+menuconfig: $(KCONFIG_TOOL_DIR)/mconf $(IDF_PATH)/Kconfig $(BUILD_DIR_BASE)
+	$(summary) MENUCONFIG
+	$(Q) $(KCONFIG_TOOL_ENV) $(KCONFIG_TOOL_DIR)/mconf $(IDF_PATH)/Kconfig
 
 ifeq ("$(wildcard $(PROJECT_PATH)/sdkconfig)","")
 #No sdkconfig found. Need to run menuconfig to make this if we need it.
@@ -28,17 +30,13 @@ endif
 
 defconfig: $(KCONFIG_TOOL_DIR)/mconf $(IDF_PATH)/Kconfig $(BUILD_DIR_BASE)
 	$(summary) DEFCONFIG
-	$(Q) mkdir -p $(PROJECT_PATH)/build/include/config
-	$(Q) KCONFIG_AUTOHEADER=$(PROJECT_PATH)/build/include/sdkconfig.h \
-	KCONFIG_CONFIG=$(PROJECT_PATH)/sdkconfig \
-	COMPONENT_KCONFIGS="$(COMPONENT_KCONFIGS)" \
-	COMPONENT_KCONFIGS_PROJBUILD="$(COMPONENT_KCONFIGS_PROJBUILD)" \
-	$(KCONFIG_TOOL_DIR)/conf --olddefconfig $(IDF_PATH)/Kconfig
+	$(Q) mkdir -p $(BUILD_DIR_BASE)/include/config
+	$(Q) $(KCONFIG_TOOL_ENV) $(KCONFIG_TOOL_DIR)/conf --olddefconfig $(IDF_PATH)/Kconfig
 
 # Work out of whether we have to build the Kconfig makefile
 # (auto.conf), or if we're in a situation where we don't need it
 NON_CONFIG_TARGETS := clean %-clean get_variable help menuconfig defconfig
-AUTO_CONF_REGEN_TARGET := $(PROJECT_PATH)/build/include/config/auto.conf
+AUTO_CONF_REGEN_TARGET := $(BUILD_DIR_BASE)/include/config/auto.conf
 
 # disable AUTO_CONF_REGEN_TARGET if all targets are non-config targets
 # (and not building default target)
@@ -46,19 +44,15 @@ ifneq ("$(MAKECMDGOALS)","")
 ifeq ($(filter $(NON_CONFIG_TARGETS), $(MAKECMDGOALS)),$(MAKECMDGOALS))
 AUTO_CONF_REGEN_TARGET :=
 # dummy target
-$(PROJECT_PATH)/build/include/config/auto.conf:
+$(BUILD_DIR_BASE)/include/config/auto.conf:
 endif
 endif
 
-$(AUTO_CONF_REGEN_TARGET) $(PROJECT_PATH)/build/include/sdkconfig.h: $(PROJECT_PATH)/sdkconfig $(KCONFIG_TOOL_DIR)/conf $(COMPONENT_KCONFIGS) $(COMPONENT_KCONFIGS_PROJBUILD)
+$(AUTO_CONF_REGEN_TARGET) $(BUILD_DIR_BASE)/include/sdkconfig.h: $(PROJECT_PATH)/sdkconfig $(KCONFIG_TOOL_DIR)/conf $(COMPONENT_KCONFIGS) $(COMPONENT_KCONFIGS_PROJBUILD)
 	$(summary) GENCONFIG
-	$(Q) mkdir -p $(PROJECT_PATH)/build/include/config
-	$(Q) cd build; KCONFIG_AUTOHEADER="$(PROJECT_PATH)/build/include/sdkconfig.h" \
-	KCONFIG_CONFIG=$(PROJECT_PATH)/sdkconfig \
-	COMPONENT_KCONFIGS="$(COMPONENT_KCONFIGS)" \
-	COMPONENT_KCONFIGS_PROJBUILD="$(COMPONENT_KCONFIGS_PROJBUILD)" \
-	$(KCONFIG_TOOL_DIR)/conf --silentoldconfig $(IDF_PATH)/Kconfig
-	$(Q) touch $(AUTO_CONF_REGEN_TARGET) $(PROJECT_PATH)/build/include/sdkconfig.h
+	$(Q) mkdir -p $(BUILD_DIR_BASE)/include/config
+	$(Q) cd $(BUILD_DIR_BASE); $(KCONFIG_TOOL_ENV) $(KCONFIG_TOOL_DIR)/conf --silentoldconfig $(IDF_PATH)/Kconfig
+	$(Q) touch $(AUTO_CONF_REGEN_TARGET) $(BUILD_DIR_BASE)/include/sdkconfig.h
 # touch to ensure both output files are newer - as 'conf' can also update sdkconfig (a dependency). Without this,
 # sometimes you can get an infinite make loop on Windows where sdkconfig always gets regenerated newer
 # than the target(!)
@@ -68,4 +62,4 @@ clean: config-clean
 config-clean:
 	$(summary RM CONFIG)
 	$(MAKE) -C $(KCONFIG_TOOL_DIR) clean
-	$(Q) rm -rf $(PROJECT_PATH)/build/include/config $(PROJECT_PATH)/build/include/sdkconfig.h
+	$(Q) rm -rf $(BUILD_DIR_BASE)/include/config $(BUILD_DIR_BASE)/include/sdkconfig.h

From 477d71e589a18af96472199caf918097c22ed0bc Mon Sep 17 00:00:00 2001
From: Angus Gratton <angus@espressif.com>
Date: Tue, 4 Oct 2016 15:38:20 +1100
Subject: [PATCH 3/8] config system: Fix configuration when BUILD_DIR_BASE
 out-of-tree

Ref #38. Also no longer generates bootloader sdkconfig in source tree.
---
 .gitignore                               |  3 ---
 components/bootloader/Makefile.projbuild | 20 ++++++++++++--------
 make/project_config.mk                   | 13 ++++++++-----
 3 files changed, 20 insertions(+), 16 deletions(-)

diff --git a/.gitignore b/.gitignore
index 85027773b6..5ec57a167f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -19,6 +19,3 @@ GPATH
 examples/*/sdkconfig
 examples/*/sdkconfig.old
 examples/*/build
-
-# Bootloader files
-components/bootloader/src/sdkconfig.old
\ No newline at end of file
diff --git a/components/bootloader/Makefile.projbuild b/components/bootloader/Makefile.projbuild
index 7c5cde3b8c..559769957c 100644
--- a/components/bootloader/Makefile.projbuild
+++ b/components/bootloader/Makefile.projbuild
@@ -13,19 +13,21 @@ ifeq ("$(IS_BOOTLOADER_BUILD)","")
 BOOTLOADER_COMPONENT_PATH := $(COMPONENT_PATH)
 BOOTLOADER_BUILD_DIR=$(BUILD_DIR_BASE)/bootloader
 BOOTLOADER_BIN=$(BOOTLOADER_BUILD_DIR)/bootloader.bin
+BOOTLOADER_SDKCONFIG=$(BOOTLOADER_BUILD_DIR)/sdkconfig
 
 # Custom recursive make for bootloader sub-project
 BOOTLOADER_MAKE=$(MAKE) -C $(BOOTLOADER_COMPONENT_PATH)/src \
-	MAKEFLAGS= V=$(V) \
+	MAKEFLAGS= V=$(V) SDKCONFIG=$(BOOTLOADER_SDKCONFIG) \
 	BUILD_DIR_BASE=$(BOOTLOADER_BUILD_DIR) \
 
 .PHONY: bootloader-clean bootloader-flash bootloader $(BOOTLOADER_BIN)
 
-$(BOOTLOADER_BIN): $(COMPONENT_PATH)/src/sdkconfig
+$(BOOTLOADER_BIN): | $(BOOTLOADER_BUILD_DIR)/sdkconfig
 	$(Q) $(BOOTLOADER_MAKE) $@
 
 bootloader-clean:
-	$(Q) $(BOOTLOADER_MAKE) app-clean
+	$(Q) $(BOOTLOADER_MAKE) app-clean config-clean
+	$(Q) rm -f $(BOOTLOADER_SDKCONFIG) $(BOOTLOADER_SDKCONFIG).old
 
 clean: bootloader-clean
 
@@ -37,15 +39,17 @@ all_binaries: $(BOOTLOADER_BIN)
 
 ESPTOOL_ALL_FLASH_ARGS += 0x1000 $(BOOTLOADER_BIN)
 
-# synchronise the project level config to the component's
-# config
-$(COMPONENT_PATH)/src/sdkconfig: $(PROJECT_PATH)/sdkconfig
-	$(Q) cp $< $@
-
 # bootloader-flash calls flash in the bootloader dummy project
 bootloader-flash: $(BOOTLOADER_BIN)
 	$(BOOTLOADER_MAKE) flash
 
+# synchronise the project level config to the bootloader's
+# config
+$(BOOTLOADER_SDKCONFIG): $(PROJECT_PATH)/sdkconfig | $(BOOTLOADER_BUILD_DIR)
+	$(Q) cp $< $@
+
+$(BOOTLOADER_BUILD_DIR):
+	$(Q) mkdir -p $@
 
 else
 CFLAGS += -D BOOTLOADER_BUILD=1 -I $(IDF_PATH)/components/esp32/include 
diff --git a/make/project_config.mk b/make/project_config.mk
index 92937e8bfe..40f51ff8ff 100644
--- a/make/project_config.mk
+++ b/make/project_config.mk
@@ -7,6 +7,10 @@ COMPONENT_KCONFIGS_PROJBUILD := $(foreach component,$(COMPONENT_PATHS),$(wildcar
 #For doing make menuconfig etc
 KCONFIG_TOOL_DIR=$(IDF_PATH)/tools/kconfig
 
+# set SDKCONFIG to the project's sdkconfig,
+# unless it's overriden (happens for bootloader)
+SDKCONFIG ?= $(PROJECT_PATH)/sdkconfig
+
 # clear MAKEFLAGS as the menuconfig makefile uses implicit compile rules
 $(KCONFIG_TOOL_DIR)/mconf $(KCONFIG_TOOL_DIR)/conf:
 	MAKEFLAGS="" \
@@ -15,17 +19,16 @@ $(KCONFIG_TOOL_DIR)/mconf $(KCONFIG_TOOL_DIR)/conf:
 
 # use a wrapper environment for where we run Kconfig tools
 KCONFIG_TOOL_ENV=KCONFIG_AUTOHEADER=$(BUILD_DIR_BASE)/include/sdkconfig.h \
-	KCONFIG_CONFIG=$(PROJECT_PATH)/sdkconfig \
-	COMPONENT_KCONFIGS="$(COMPONENT_KCONFIGS)" \
+	COMPONENT_KCONFIGS="$(COMPONENT_KCONFIGS)" KCONFIG_CONFIG=$(SDKCONFIG) \
 	COMPONENT_KCONFIGS_PROJBUILD="$(COMPONENT_KCONFIGS_PROJBUILD)"
 
 menuconfig: $(KCONFIG_TOOL_DIR)/mconf $(IDF_PATH)/Kconfig $(BUILD_DIR_BASE)
 	$(summary) MENUCONFIG
 	$(Q) $(KCONFIG_TOOL_ENV) $(KCONFIG_TOOL_DIR)/mconf $(IDF_PATH)/Kconfig
 
-ifeq ("$(wildcard $(PROJECT_PATH)/sdkconfig)","")
+ifeq ("$(wildcard $(SDKCONFIG))","")
 #No sdkconfig found. Need to run menuconfig to make this if we need it.
-$(PROJECT_PATH)/sdkconfig: menuconfig
+$(SDKCONFIG): menuconfig
 endif
 
 defconfig: $(KCONFIG_TOOL_DIR)/mconf $(IDF_PATH)/Kconfig $(BUILD_DIR_BASE)
@@ -48,7 +51,7 @@ $(BUILD_DIR_BASE)/include/config/auto.conf:
 endif
 endif
 
-$(AUTO_CONF_REGEN_TARGET) $(BUILD_DIR_BASE)/include/sdkconfig.h: $(PROJECT_PATH)/sdkconfig $(KCONFIG_TOOL_DIR)/conf $(COMPONENT_KCONFIGS) $(COMPONENT_KCONFIGS_PROJBUILD)
+$(AUTO_CONF_REGEN_TARGET) $(BUILD_DIR_BASE)/include/sdkconfig.h: $(SDKCONFIG) $(KCONFIG_TOOL_DIR)/conf $(COMPONENT_KCONFIGS) $(COMPONENT_KCONFIGS_PROJBUILD)
 	$(summary) GENCONFIG
 	$(Q) mkdir -p $(BUILD_DIR_BASE)/include/config
 	$(Q) cd $(BUILD_DIR_BASE); $(KCONFIG_TOOL_ENV) $(KCONFIG_TOOL_DIR)/conf --silentoldconfig $(IDF_PATH)/Kconfig

From eccf54b93969396d991012e453fa187cb8684c15 Mon Sep 17 00:00:00 2001
From: Angus Gratton <angus@espressif.com>
Date: Tue, 4 Oct 2016 15:54:27 +1100
Subject: [PATCH 4/8] build system tests: Add some more notes about test
 internals

---
 make/test_build_system.sh | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/make/test_build_system.sh b/make/test_build_system.sh
index b6aaa9e58f..401c8376cb 100755
--- a/make/test_build_system.sh
+++ b/make/test_build_system.sh
@@ -2,7 +2,7 @@
 #
 # Test the build system for basic consistency
 #
-# Just a bash script that tests some likely make failure scenarios in a row
+# A bash script that tests some likely make failure scenarios in a row
 # Creates its own test build directory under TMP and cleans it up when done.
 #
 # Environment variables:
@@ -11,6 +11,17 @@
 # ESP_IDF_TEMPLATE_GIT - Can override git clone source for template app. Otherwise github.
 # NOCLEANUP - Set to '1' if you want the script to leave its temporary directory when done, for post-mortem.
 #
+#
+# Internals:
+# * The tests run in sequence & the system keeps track of all failures to print at the end.
+# * BUILD directory is set to default BUILD_DIR_BASE
+# * The "print_status" function both prints a status line to the log and keeps track of which test is running.
+# * Calling the "failure" function prints a failure message to the log and also adds to the list of failures to print at the end.
+# * The function "assert_built" tests for a file relative to the BUILD directory.
+# * The function "take_build_snapshot" can be paired with the functions "assert_rebuilt" and "assert_not_rebuilt" to compare file timestamps and verify if they were rebuilt or not since the snapshot was taken.
+#
+# To add a new test case, add it to the end of the run_tests function. Note that not all test cases do comprehensive cleanup
+# (although very invasive ones like appending CRLFs to all files take a copy of the esp-idf tree.)
 
 # Set up some variables
 #

From f720e82d403a8a09cf94a176067aea71263c307f Mon Sep 17 00:00:00 2001
From: Angus Gratton <angus@espressif.com>
Date: Thu, 6 Oct 2016 18:05:51 +1100
Subject: [PATCH 5/8] build system: Allow BUILD_DIR_BASE to be a relative
 directory (see github #38)

---
 components/bootloader/Makefile.projbuild |  2 +-
 components/esp32/component.mk            |  2 +-
 make/project.mk                          |  2 +-
 make/project_config.mk                   |  2 +-
 make/test_build_system.sh                | 10 +++++++++-
 5 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/components/bootloader/Makefile.projbuild b/components/bootloader/Makefile.projbuild
index 559769957c..02135e1c64 100644
--- a/components/bootloader/Makefile.projbuild
+++ b/components/bootloader/Makefile.projbuild
@@ -11,7 +11,7 @@
 ifeq ("$(IS_BOOTLOADER_BUILD)","")
 
 BOOTLOADER_COMPONENT_PATH := $(COMPONENT_PATH)
-BOOTLOADER_BUILD_DIR=$(BUILD_DIR_BASE)/bootloader
+BOOTLOADER_BUILD_DIR=$(abspath $(BUILD_DIR_BASE)/bootloader)
 BOOTLOADER_BIN=$(BOOTLOADER_BUILD_DIR)/bootloader.bin
 BOOTLOADER_SDKCONFIG=$(BOOTLOADER_BUILD_DIR)/sdkconfig
 
diff --git a/components/esp32/component.mk b/components/esp32/component.mk
index 85040d77a0..b3d95f1b19 100644
--- a/components/esp32/component.mk
+++ b/components/esp32/component.mk
@@ -6,7 +6,7 @@
 # lib(subdirectory_name).a in the build directory. This behaviour is entirely configurable,
 # please read the esp-idf build system document if you need to do this.
 #
--include $(BUILD_DIR_BASE)/include/config/auto.conf
+-include include/config/auto.conf
 
 COMPONENT_SRCDIRS := . hwcrypto
 
diff --git a/make/project.mk b/make/project.mk
index 74943334a6..c4bf68db63 100644
--- a/make/project.mk
+++ b/make/project.mk
@@ -106,7 +106,7 @@ COMPONENT_INCLUDES := $(abspath $(foreach comp,$(COMPONENT_PATHS_BUILDABLE),$(ad
 	$(call GetVariable,$(comp),COMPONENT_ADD_INCLUDEDIRS))))
 
 #Also add project include path, for sdk includes
-COMPONENT_INCLUDES += $(BUILD_DIR_BASE)/include/
+COMPONENT_INCLUDES += $(abspath $(BUILD_DIR_BASE)/include/)
 export COMPONENT_INCLUDES
 
 #COMPONENT_LDFLAGS has a list of all flags that are needed to link the components together. It's collected
diff --git a/make/project_config.mk b/make/project_config.mk
index 40f51ff8ff..00452dda4d 100644
--- a/make/project_config.mk
+++ b/make/project_config.mk
@@ -18,7 +18,7 @@ $(KCONFIG_TOOL_DIR)/mconf $(KCONFIG_TOOL_DIR)/conf:
 	$(MAKE) -C $(KCONFIG_TOOL_DIR)
 
 # use a wrapper environment for where we run Kconfig tools
-KCONFIG_TOOL_ENV=KCONFIG_AUTOHEADER=$(BUILD_DIR_BASE)/include/sdkconfig.h \
+KCONFIG_TOOL_ENV=KCONFIG_AUTOHEADER=$(abspath $(BUILD_DIR_BASE)/include/sdkconfig.h) \
 	COMPONENT_KCONFIGS="$(COMPONENT_KCONFIGS)" KCONFIG_CONFIG=$(SDKCONFIG) \
 	COMPONENT_KCONFIGS_PROJBUILD="$(COMPONENT_KCONFIGS_PROJBUILD)"
 
diff --git a/make/test_build_system.sh b/make/test_build_system.sh
index 401c8376cb..b7004eece1 100755
--- a/make/test_build_system.sh
+++ b/make/test_build_system.sh
@@ -91,7 +91,7 @@ function run_tests()
 		 failure "Files weren't cleaned: ${ALL_BUILD_FILES}"
 	fi
 
-	print_status "Moving BUILD_DIR_BASE out of tree should still build OK"
+	print_status "Moving BUILD_DIR_BASE out of tree"
 	rm -rf --preserve-root ${BUILD}/*
 	OUTOFTREE_BUILD=${TESTDIR}/alt_build
 	make BUILD_DIR_BASE=${OUTOFTREE_BUILD} || failure "Failed to build with BUILD_DIR_BASE overriden"
@@ -104,6 +104,14 @@ function run_tests()
 		failure "Some files were incorrectly put into the default build directory: ${DEFAULT_BUILD_FILES}"
 	fi
 
+	print_status "BUILD_DIR_BASE inside default build directory"
+	rm -rf --preserve-root ${BUILD}/*
+	make BUILD_DIR_BASE=build/subdirectory || failure "Failed to build with BUILD_DIR_BASE as subdir"
+	NEW_BUILD_FILES=$(find ${BUILD}/subdirectory -type f)
+	if [ -z "${NEW_BUILD_FILES}" ]; then
+		failure "No files found in new build directory!"
+	fi
+
 	print_status "Can still clean build if all text files are CRLFs"
 	make clean || failure "Unexpected failure to make clean"
 	find . -exec unix2dos {} \; # CRLFify template dir

From 6a890e6c49d1b4b00080fe9544f730b4b517331e Mon Sep 17 00:00:00 2001
From: Angus Gratton <angus@espressif.com>
Date: Thu, 6 Oct 2016 18:06:52 +1100
Subject: [PATCH 6/8] build system tests: Untabify shell script

---
 make/test_build_system.sh | 260 +++++++++++++++++++-------------------
 1 file changed, 130 insertions(+), 130 deletions(-)

diff --git a/make/test_build_system.sh b/make/test_build_system.sh
index b7004eece1..f721588383 100755
--- a/make/test_build_system.sh
+++ b/make/test_build_system.sh
@@ -32,123 +32,123 @@ export V=1
 
 function run_tests()
 {
-	FAILURES=
-	STATUS="Starting"
-	print_status "Checking prerequisites"
-	[ -z ${IDF_PATH} ] && echo "IDF_PATH is not set. Need path to esp-idf installation." && exit 2
+    FAILURES=
+    STATUS="Starting"
+    print_status "Checking prerequisites"
+    [ -z ${IDF_PATH} ] && echo "IDF_PATH is not set. Need path to esp-idf installation." && exit 2
 
-	print_status "Cloning template from ${ESP_IDF_TEMPLATE_GIT}..."
-	git clone ${ESP_IDF_TEMPLATE_GIT} template
-	cd template
-	git checkout ${CI_BUILD_REF_NAME} || echo "Using esp-idf-template default branch..."
+    print_status "Cloning template from ${ESP_IDF_TEMPLATE_GIT}..."
+    git clone ${ESP_IDF_TEMPLATE_GIT} template
+    cd template
+    git checkout ${CI_BUILD_REF_NAME} || echo "Using esp-idf-template default branch..."
 
-	print_status "Updating template config..."
-	make defconfig || exit $?
+    print_status "Updating template config..."
+    make defconfig || exit $?
 
-	BOOTLOADER_BINS="bootloader/bootloader.elf bootloader/bootloader.bin"
-	APP_BINS="app-template.elf app-template.bin"
+    BOOTLOADER_BINS="bootloader/bootloader.elf bootloader/bootloader.bin"
+    APP_BINS="app-template.elf app-template.bin"
 
-	print_status "Initial clean build"
-	# if make fails here, everything fails
-	make || exit $?
-	# check all the expected build artifacts from the clean build
-	assert_built ${APP_BINS} ${BOOTLOADER_BINS} partitions_singleapp.bin
-	[ -f ${BUILD}/partition*.bin ] || failure "A partition table should have been built"
+    print_status "Initial clean build"
+    # if make fails here, everything fails
+    make || exit $?
+    # check all the expected build artifacts from the clean build
+    assert_built ${APP_BINS} ${BOOTLOADER_BINS} partitions_singleapp.bin
+    [ -f ${BUILD}/partition*.bin ] || failure "A partition table should have been built"
 
-	print_status "Updating component source file rebuilds component"
-	# touch a file & do a build
-	take_build_snapshot
-	touch ${IDF_PATH}/components/esp32/syscalls.c
-	make || failure "Failed to partial build"
-	assert_rebuilt ${APP_BINS} esp32/libesp32.a esp32/syscalls.o
-	assert_not_rebuilt lwip/liblwip.a freertos/libfreertos.a ${BOOTLOADER_BINS} partitions_singleapp.bin
+    print_status "Updating component source file rebuilds component"
+    # touch a file & do a build
+    take_build_snapshot
+    touch ${IDF_PATH}/components/esp32/syscalls.c
+    make || failure "Failed to partial build"
+    assert_rebuilt ${APP_BINS} esp32/libesp32.a esp32/syscalls.o
+    assert_not_rebuilt lwip/liblwip.a freertos/libfreertos.a ${BOOTLOADER_BINS} partitions_singleapp.bin
 
-	print_status "Bootloader source file rebuilds bootloader"
-	take_build_snapshot
-	touch ${IDF_PATH}/components/bootloader/src/main/bootloader_start.c
-	make bootloader || failure "Failed to partial build bootloader"
-	assert_rebuilt ${BOOTLOADER_BINS} bootloader/main/bootloader_start.o
-	assert_not_rebuilt ${APP_BINS} partitions_singleapp.bin
+    print_status "Bootloader source file rebuilds bootloader"
+    take_build_snapshot
+    touch ${IDF_PATH}/components/bootloader/src/main/bootloader_start.c
+    make bootloader || failure "Failed to partial build bootloader"
+    assert_rebuilt ${BOOTLOADER_BINS} bootloader/main/bootloader_start.o
+    assert_not_rebuilt ${APP_BINS} partitions_singleapp.bin
 
-	print_status "Partition CSV file rebuilds partitions"
-	take_build_snapshot
-	touch ${IDF_PATH}/components/partition_table/partitions_singleapp.csv
-	make partition_table || failure "Failed to build partition table"
-	assert_rebuilt partitions_singleapp.bin
-	assert_not_rebuilt app-template.bin app-template.elf ${BOOTLOADER_BINS}
+    print_status "Partition CSV file rebuilds partitions"
+    take_build_snapshot
+    touch ${IDF_PATH}/components/partition_table/partitions_singleapp.csv
+    make partition_table || failure "Failed to build partition table"
+    assert_rebuilt partitions_singleapp.bin
+    assert_not_rebuilt app-template.bin app-template.elf ${BOOTLOADER_BINS}
 
-	print_status "Partial build doesn't compile anything by default"
-	take_build_snapshot
-	# verify no build files are refreshed by a partial make
-	ALL_BUILD_FILES=$(find ${BUILD} -type f | sed "s@${BUILD}/@@")
-	make || failure "Partial build failed"
-	assert_not_rebuilt ${ALL_BUILD_FILES}
+    print_status "Partial build doesn't compile anything by default"
+    take_build_snapshot
+    # verify no build files are refreshed by a partial make
+    ALL_BUILD_FILES=$(find ${BUILD} -type f | sed "s@${BUILD}/@@")
+    make || failure "Partial build failed"
+    assert_not_rebuilt ${ALL_BUILD_FILES}
 
-	print_status "Cleaning should remove all files from build"
-	make clean || failure "Failed to make clean"
-	ALL_BUILD_FILES=$(find ${BUILD} -type f)
-	if [ -n "${ALL_BUILD_FILES}" ]; then
-		 failure "Files weren't cleaned: ${ALL_BUILD_FILES}"
-	fi
+    print_status "Cleaning should remove all files from build"
+    make clean || failure "Failed to make clean"
+    ALL_BUILD_FILES=$(find ${BUILD} -type f)
+    if [ -n "${ALL_BUILD_FILES}" ]; then
+         failure "Files weren't cleaned: ${ALL_BUILD_FILES}"
+    fi
 
-	print_status "Moving BUILD_DIR_BASE out of tree"
-	rm -rf --preserve-root ${BUILD}/*
-	OUTOFTREE_BUILD=${TESTDIR}/alt_build
-	make BUILD_DIR_BASE=${OUTOFTREE_BUILD} || failure "Failed to build with BUILD_DIR_BASE overriden"
-	NEW_BUILD_FILES=$(find ${OUTOFREE_BUILD} -type f)
-	if [ -z "${NEW_BUILD_FILES}" ]; then
-		failure "No files found in new build directory!"
-	fi
-	DEFAULT_BUILD_FILES=$(find ${BUILD} -mindepth 1)
-	if [ -n "${DEFAULT_BUILD_FILES}" ]; then
-		failure "Some files were incorrectly put into the default build directory: ${DEFAULT_BUILD_FILES}"
-	fi
+    print_status "Moving BUILD_DIR_BASE out of tree"
+    rm -rf --preserve-root ${BUILD}/*
+    OUTOFTREE_BUILD=${TESTDIR}/alt_build
+    make BUILD_DIR_BASE=${OUTOFTREE_BUILD} || failure "Failed to build with BUILD_DIR_BASE overriden"
+    NEW_BUILD_FILES=$(find ${OUTOFREE_BUILD} -type f)
+    if [ -z "${NEW_BUILD_FILES}" ]; then
+        failure "No files found in new build directory!"
+    fi
+    DEFAULT_BUILD_FILES=$(find ${BUILD} -mindepth 1)
+    if [ -n "${DEFAULT_BUILD_FILES}" ]; then
+        failure "Some files were incorrectly put into the default build directory: ${DEFAULT_BUILD_FILES}"
+    fi
 
-	print_status "BUILD_DIR_BASE inside default build directory"
-	rm -rf --preserve-root ${BUILD}/*
-	make BUILD_DIR_BASE=build/subdirectory || failure "Failed to build with BUILD_DIR_BASE as subdir"
-	NEW_BUILD_FILES=$(find ${BUILD}/subdirectory -type f)
-	if [ -z "${NEW_BUILD_FILES}" ]; then
-		failure "No files found in new build directory!"
-	fi
+    print_status "BUILD_DIR_BASE inside default build directory"
+    rm -rf --preserve-root ${BUILD}/*
+    make BUILD_DIR_BASE=build/subdirectory || failure "Failed to build with BUILD_DIR_BASE as subdir"
+    NEW_BUILD_FILES=$(find ${BUILD}/subdirectory -type f)
+    if [ -z "${NEW_BUILD_FILES}" ]; then
+        failure "No files found in new build directory!"
+    fi
 
-	print_status "Can still clean build if all text files are CRLFs"
-	make clean || failure "Unexpected failure to make clean"
-	find . -exec unix2dos {} \; # CRLFify template dir
-	# make a copy of esp-idf and CRLFify it
-	CRLF_ESPIDF=${TESTDIR}/esp-idf-crlf
-	mkdir -p ${CRLF_ESPIDF}
-	cp -rv ${IDF_PATH}/* ${CRLF_ESPIDF}
-	# don't CRLFify executable files, as Linux will fail to execute them
-	find ${CRLF_ESPIDF} -type f ! -perm 755 -exec unix2dos {} \;
-	make IDF_PATH=${CRLF_ESPIDF} || failure "Failed to build with CRLFs in source"
-	# do the same checks we do for the clean build
-	assert_built ${APP_BINS} ${BOOTLOADER_BINS} partitions_singleapp.bin
-	[ -f ${BUILD}/partition*.bin ] || failure "A partition table should have been built in CRLF mode"
+    print_status "Can still clean build if all text files are CRLFs"
+    make clean || failure "Unexpected failure to make clean"
+    find . -exec unix2dos {} \; # CRLFify template dir
+    # make a copy of esp-idf and CRLFify it
+    CRLF_ESPIDF=${TESTDIR}/esp-idf-crlf
+    mkdir -p ${CRLF_ESPIDF}
+    cp -rv ${IDF_PATH}/* ${CRLF_ESPIDF}
+    # don't CRLFify executable files, as Linux will fail to execute them
+    find ${CRLF_ESPIDF} -type f ! -perm 755 -exec unix2dos {} \;
+    make IDF_PATH=${CRLF_ESPIDF} || failure "Failed to build with CRLFs in source"
+    # do the same checks we do for the clean build
+    assert_built ${APP_BINS} ${BOOTLOADER_BINS} partitions_singleapp.bin
+    [ -f ${BUILD}/partition*.bin ] || failure "A partition table should have been built in CRLF mode"
 
 
-	print_status "All tests completed"
-	if [ -n "${FAILURES}" ]; then
-		echo "Some failures were detected:"
-		echo -e "${FAILURES}"
-		exit 1
-	else
-		echo "Build tests passed."
-	fi
+    print_status "All tests completed"
+    if [ -n "${FAILURES}" ]; then
+        echo "Some failures were detected:"
+        echo -e "${FAILURES}"
+        exit 1
+    else
+        echo "Build tests passed."
+    fi
 }
 
 function print_status()
 {
-	echo "******** $1"
-	STATUS="$1"
+    echo "******** $1"
+    STATUS="$1"
 }
 
 function failure()
 {
-	echo "!!!!!!!!!!!!!!!!!!!"
-	echo "FAILURE: $1"
-	echo "!!!!!!!!!!!!!!!!!!!"
-	FAILURES="${FAILURES}${STATUS} :: $1\n"
+    echo "!!!!!!!!!!!!!!!!!!!"
+    echo "FAILURE: $1"
+    echo "!!!!!!!!!!!!!!!!!!!"
+    FAILURES="${FAILURES}${STATUS} :: $1\n"
 }
 
 TESTDIR=${TMP}/build_system_tests_$$
@@ -164,62 +164,62 @@ BUILD=${TESTDIR}/template/build
 # copy all the build output to a snapshot directory
 function take_build_snapshot()
 {
-	rm -rf ${SNAPSHOT}
-	cp -ap ${TESTDIR}/template/build ${SNAPSHOT}
+    rm -rf ${SNAPSHOT}
+    cp -ap ${TESTDIR}/template/build ${SNAPSHOT}
 }
 
 # verify that all the arguments are present in the build output directory
 function assert_built()
 {
-	until [ -z "$1" ]; do
-		if [ ! -f "${BUILD}/$1" ]; then
-			failure "File $1 should be in the build output directory"
-		fi
-		shift
-	done
+    until [ -z "$1" ]; do
+        if [ ! -f "${BUILD}/$1" ]; then
+            failure "File $1 should be in the build output directory"
+        fi
+        shift
+    done
 }
 
 # Test if a file has been rebuilt.
 function file_was_rebuilt()
 {
-	# can't use [ a -ot b ] here as -ot only gives second resolution
-	# but stat -c %y seems to be microsecond at least for tmpfs, ext4..
-	if [ "$(stat -c %y ${SNAPSHOT}/$1)" != "$(stat -c %y ${BUILD}/$1)" ]; then
-		return 0
-	else
-		return 1
-	fi
+    # can't use [ a -ot b ] here as -ot only gives second resolution
+    # but stat -c %y seems to be microsecond at least for tmpfs, ext4..
+    if [ "$(stat -c %y ${SNAPSHOT}/$1)" != "$(stat -c %y ${BUILD}/$1)" ]; then
+        return 0
+    else
+        return 1
+    fi
 }
 
 # verify all the arguments passed in were rebuilt relative to the snapshot
 function assert_rebuilt()
 {
-	until [ -z "$1" ]; do
-		assert_built "$1"
-		if [ ! -f "${SNAPSHOT}/$1" ]; then
-			failure "File $1 should have been original build snapshot"
-		fi
-		if ! file_was_rebuilt "$1"; then
-			failure "File $1 should have been rebuilt"
-		fi
-		shift
-	done
+    until [ -z "$1" ]; do
+        assert_built "$1"
+        if [ ! -f "${SNAPSHOT}/$1" ]; then
+            failure "File $1 should have been original build snapshot"
+        fi
+        if ! file_was_rebuilt "$1"; then
+            failure "File $1 should have been rebuilt"
+        fi
+        shift
+    done
 }
 
 # verify all the arguments are in the build directory & snapshot,
 # but were not rebuilt
 function assert_not_rebuilt()
 {
-	until [ -z "$1" ]; do
-		assert_built "$1"
-		if [ ! -f "${SNAPSHOT}/$1" ]; then
-			failure "File $1 should be in snapshot build directory"
-		fi
-		if file_was_rebuilt "$1"; then
-			failure "File $1 should not have been rebuilt"
-		fi
-		shift
-	done
+    until [ -z "$1" ]; do
+        assert_built "$1"
+        if [ ! -f "${SNAPSHOT}/$1" ]; then
+            failure "File $1 should be in snapshot build directory"
+        fi
+        if file_was_rebuilt "$1"; then
+            failure "File $1 should not have been rebuilt"
+        fi
+        shift
+    done
 }
 
 cd ${TESTDIR}

From 305bc9fd9c532286a23a281231c23e4673566a23 Mon Sep 17 00:00:00 2001
From: Angus Gratton <angus@espressif.com>
Date: Thu, 6 Oct 2016 18:29:34 +1100
Subject: [PATCH 7/8] build system: Run parallel builds without warnings

Ref github #38
---
 components/bootloader/Makefile.projbuild |  4 ++--
 make/project.mk                          |  3 ++-
 make/project_config.mk                   |  5 ++---
 make/test_build_system.sh                | 17 +++++++++++++++--
 4 files changed, 21 insertions(+), 8 deletions(-)

diff --git a/components/bootloader/Makefile.projbuild b/components/bootloader/Makefile.projbuild
index 02135e1c64..91be3a6d6e 100644
--- a/components/bootloader/Makefile.projbuild
+++ b/components/bootloader/Makefile.projbuild
@@ -16,8 +16,8 @@ BOOTLOADER_BIN=$(BOOTLOADER_BUILD_DIR)/bootloader.bin
 BOOTLOADER_SDKCONFIG=$(BOOTLOADER_BUILD_DIR)/sdkconfig
 
 # Custom recursive make for bootloader sub-project
-BOOTLOADER_MAKE=$(MAKE) -C $(BOOTLOADER_COMPONENT_PATH)/src \
-	MAKEFLAGS= V=$(V) SDKCONFIG=$(BOOTLOADER_SDKCONFIG) \
+BOOTLOADER_MAKE=+$(MAKE) -C $(BOOTLOADER_COMPONENT_PATH)/src \
+	V=$(V) SDKCONFIG=$(BOOTLOADER_SDKCONFIG) \
 	BUILD_DIR_BASE=$(BOOTLOADER_BUILD_DIR) \
 
 .PHONY: bootloader-clean bootloader-flash bootloader $(BOOTLOADER_BIN)
diff --git a/make/project.mk b/make/project.mk
index c4bf68db63..5797889868 100644
--- a/make/project.mk
+++ b/make/project.mk
@@ -37,6 +37,7 @@ help:
 	@echo "'make partition_table', etc, etc."
 
 # disable built-in make rules, makes debugging saner
+MAKEFLAGS_OLD := $(MAKEFLAGS)
 MAKEFLAGS +=-rR
 
 # Figure out PROJECT_PATH if not set
@@ -231,7 +232,7 @@ define GenerateComponentPhonyTarget
 # $(2) - target to generate (build, clean)
 .PHONY: $(notdir $(1))-$(2)
 $(notdir $(1))-$(2): | $(BUILD_DIR_BASE)/$(notdir $(1))
-	@+$(MAKE) -C $(BUILD_DIR_BASE)/$(notdir $(1)) -f $(1)/component.mk COMPONENT_BUILD_DIR=$(BUILD_DIR_BASE)/$(notdir $(1)) $(2)
+	$(Q) +$(MAKE) -C $(BUILD_DIR_BASE)/$(notdir $(1)) -f $(1)/component.mk COMPONENT_BUILD_DIR=$(BUILD_DIR_BASE)/$(notdir $(1)) $(2)
 endef
 
 define GenerateComponentTargets
diff --git a/make/project_config.mk b/make/project_config.mk
index 00452dda4d..7ca83ce5af 100644
--- a/make/project_config.mk
+++ b/make/project_config.mk
@@ -11,10 +11,9 @@ KCONFIG_TOOL_DIR=$(IDF_PATH)/tools/kconfig
 # unless it's overriden (happens for bootloader)
 SDKCONFIG ?= $(PROJECT_PATH)/sdkconfig
 
-# clear MAKEFLAGS as the menuconfig makefile uses implicit compile rules
+# reset MAKEFLAGS as the menuconfig makefile uses implicit compile rules
 $(KCONFIG_TOOL_DIR)/mconf $(KCONFIG_TOOL_DIR)/conf:
-	MAKEFLAGS="" \
-	CC=$(HOSTCC) LD=$(HOSTLD) \
+	MAKEFLAGS=$(ORIGINAL_MAKEFLAGS) CC=$(HOSTCC) LD=$(HOSTLD) \
 	$(MAKE) -C $(KCONFIG_TOOL_DIR)
 
 # use a wrapper environment for where we run Kconfig tools
diff --git a/make/test_build_system.sh b/make/test_build_system.sh
index f721588383..c6e54d9222 100755
--- a/make/test_build_system.sh
+++ b/make/test_build_system.sh
@@ -92,7 +92,7 @@ function run_tests()
     fi
 
     print_status "Moving BUILD_DIR_BASE out of tree"
-    rm -rf --preserve-root ${BUILD}/*
+    clean_build_dir
     OUTOFTREE_BUILD=${TESTDIR}/alt_build
     make BUILD_DIR_BASE=${OUTOFTREE_BUILD} || failure "Failed to build with BUILD_DIR_BASE overriden"
     NEW_BUILD_FILES=$(find ${OUTOFREE_BUILD} -type f)
@@ -105,13 +105,20 @@ function run_tests()
     fi
 
     print_status "BUILD_DIR_BASE inside default build directory"
-    rm -rf --preserve-root ${BUILD}/*
+    clean_build_dir
     make BUILD_DIR_BASE=build/subdirectory || failure "Failed to build with BUILD_DIR_BASE as subdir"
     NEW_BUILD_FILES=$(find ${BUILD}/subdirectory -type f)
     if [ -z "${NEW_BUILD_FILES}" ]; then
         failure "No files found in new build directory!"
     fi
 
+    print_status "Parallel builds should work OK"
+    clean_build_dir
+    (make -j5 2>&1 | tee ${TESTDIR}/parallel_build.log) || failure "Failed to build in parallel"
+    if grep -q "warning: jobserver unavailable" ${TESTDIR}/parallel_build.log; then
+        failure "Parallel build prints 'warning: jobserver unavailable' errors"
+    fi
+
     print_status "Can still clean build if all text files are CRLFs"
     make clean || failure "Unexpected failure to make clean"
     find . -exec unix2dos {} \; # CRLFify template dir
@@ -222,5 +229,11 @@ function assert_not_rebuilt()
     done
 }
 
+# do a "clean" that doesn't depend on 'make clean'
+function clean_build_dir()
+{
+    rm -rf --preserve-root ${BUILD}/*
+}
+
 cd ${TESTDIR}
 run_tests

From 746ad41d890f8e2e60b5ace63a7910b7c60b89e6 Mon Sep 17 00:00:00 2001
From: Angus Gratton <angus@espressif.com>
Date: Tue, 18 Oct 2016 15:35:17 +1100
Subject: [PATCH 8/8] Build tests: Use & document clean_build_dir

---
 make/test_build_system.sh | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/make/test_build_system.sh b/make/test_build_system.sh
index a6de14987b..7c8cbc1f1e 100755
--- a/make/test_build_system.sh
+++ b/make/test_build_system.sh
@@ -21,7 +21,8 @@
 # * The function "take_build_snapshot" can be paired with the functions "assert_rebuilt" and "assert_not_rebuilt" to compare file timestamps and verify if they were rebuilt or not since the snapshot was taken.
 #
 # To add a new test case, add it to the end of the run_tests function. Note that not all test cases do comprehensive cleanup
-# (although very invasive ones like appending CRLFs to all files take a copy of the esp-idf tree.)
+# (although very invasive ones like appending CRLFs to all files take a copy of the esp-idf tree), however the clean_build_dir
+# function can be used to force-delete all files from the build output directory.
 
 # Set up some variables
 #
@@ -92,7 +93,7 @@ function run_tests()
     fi
 
     print_status "Bootloader build shouldn't leave build output anywhere else"
-    rm -rf --preserve-root ${BUILD}
+    clean_build_dir
     make bootloader
     # find wizardry: find any file not named sdkconfig.h that
     # isn't in the "bootloader" or "config" directories