From 054770407e243b4ecc2eb9f0f3b3c08a03723e29 Mon Sep 17 00:00:00 2001 From: David Cermak Date: Wed, 19 May 2021 21:05:36 +0200 Subject: [PATCH] esp_netif: Fix failing ppp_set_auth() due to wrong arg check Closes https://github.com/espressif/esp-idf/issues/7047 --- components/esp_netif/lwip/esp_netif_lwip_ppp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/esp_netif/lwip/esp_netif_lwip_ppp.c b/components/esp_netif/lwip/esp_netif_lwip_ppp.c index 6513862481..de1dd0cab5 100644 --- a/components/esp_netif/lwip/esp_netif_lwip_ppp.c +++ b/components/esp_netif/lwip/esp_netif_lwip_ppp.c @@ -248,18 +248,18 @@ static uint32_t pppos_low_level_output(ppp_pcb *pcb, uint8_t *data, uint32_t len esp_err_t esp_netif_ppp_set_auth(esp_netif_t *netif, esp_netif_auth_type_t authtype, const char *user, const char *passwd) { - if (_IS_NETIF_POINT2POINT_TYPE(netif, PPP_LWIP_NETIF)) { + if (!_IS_NETIF_POINT2POINT_TYPE(netif, PPP_LWIP_NETIF)) { return ESP_ERR_ESP_NETIF_INVALID_PARAMS; } #if PPP_AUTH_SUPPORT lwip_peer2peer_ctx_t *ppp_ctx = (lwip_peer2peer_ctx_t *)netif->related_data; assert(ppp_ctx->base.netif_type == PPP_LWIP_NETIF); pppapi_set_auth(ppp_ctx->ppp, authtype, user, passwd); + return ESP_OK; #else ESP_LOGE(TAG, "%s failed: No authorisation enabled in menuconfig", __func__); return ESP_ERR_ESP_NETIF_IF_NOT_READY; #endif - return ESP_OK; } void esp_netif_ppp_set_default_netif(netif_related_data_t *netif_related)