feat(tools): Add shellcheck for shell scripts to CI

- shellcheck fixes in shell scripts
This commit is contained in:
Marek Fiala
2023-09-05 11:09:52 +02:00
parent c50dfa2374
commit 37c7c5b58d
4 changed files with 26 additions and 7 deletions

View File

@@ -65,6 +65,7 @@ __main() {
self_path="${BASH_SOURCE}"
elif [ -n "${ZSH_VERSION-}" ]
then
# shellcheck disable=SC2296 # ignore parameter starts with '{' because it's zsh
self_path="${(%):-%x}"
fi
@@ -138,7 +139,7 @@ __main() {
if [ -n "$BASH" ]
then
path_prefix=${PATH%%${old_path}}
path_prefix="${PATH%%"${old_path}"}"
# shellcheck disable=SC2169,SC2039 # unreachable with 'dash'
if [ -n "${path_prefix}" ]; then
__verbose "Added the following directories to PATH:"
@@ -201,7 +202,7 @@ __cleanup() {
# Not unsetting IDF_PYTHON_ENV_PATH, it can be used by IDF build system
# to check whether we are using a private Python environment
return $1
return "$1"
}
@@ -222,7 +223,7 @@ __enable_autocomplete() {
elif [ -n "${BASH_SOURCE-}" ]
then
WARNING_MSG="WARNING: Failed to load shell autocompletion for bash version: $BASH_VERSION!"
# shellcheck disable=SC3028,SC3054,SC2086 # code block for 'bash' only
# shellcheck disable=SC3028,SC3054,SC2086,SC2169 # code block for 'bash' only
[ ${BASH_VERSINFO[0]} -lt 4 ] && { echo "$WARNING_MSG"; return; }
eval "$(env LANG=en _IDF.PY_COMPLETE=$SOURCE_BASH idf.py)" || echo "$WARNING_MSG"
fi