forked from espressif/esp-idf
Merge branch 'bugfix/fatfs_optimize_stat_func' into 'master'
fix(fatfs): Optimizes vfs_fat_stat function to get stat structure after readdir See merge request espressif/esp-idf!28609
This commit is contained in:
@ -274,6 +274,13 @@ TEST_CASE("(WL) can opendir root directory of FS", "[fatfs][wear_levelling]")
|
|||||||
test_teardown();
|
test_teardown();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
TEST_CASE("(WL) readdir, stat work as expected", "[fatfs][wear_levelling]")
|
||||||
|
{
|
||||||
|
test_setup();
|
||||||
|
test_fatfs_readdir_stat("/spiflash/dir");
|
||||||
|
test_teardown();
|
||||||
|
}
|
||||||
|
|
||||||
TEST_CASE("(WL) opendir, readdir, rewinddir, seekdir work as expected", "[fatfs][wear_levelling]")
|
TEST_CASE("(WL) opendir, readdir, rewinddir, seekdir work as expected", "[fatfs][wear_levelling]")
|
||||||
{
|
{
|
||||||
test_setup();
|
test_setup();
|
||||||
|
@ -1,6 +1,6 @@
|
|||||||
idf_component_register(SRCS "test_fatfs_sdcard_main.c" "test_fatfs_sdspi.c"
|
idf_component_register(SRCS "test_fatfs_sdcard_main.c" "test_fatfs_sdspi.c"
|
||||||
INCLUDE_DIRS "."
|
INCLUDE_DIRS "."
|
||||||
PRIV_REQUIRES unity fatfs vfs sdmmc driver test_fatfs_common
|
PRIV_REQUIRES unity fatfs vfs sdmmc driver test_fatfs_common esp_timer
|
||||||
WHOLE_ARCHIVE)
|
WHOLE_ARCHIVE)
|
||||||
|
|
||||||
if(CONFIG_SOC_SDMMC_HOST_SUPPORTED)
|
if(CONFIG_SOC_SDMMC_HOST_SUPPORTED)
|
||||||
|
@ -13,6 +13,7 @@
|
|||||||
#include "unity.h"
|
#include "unity.h"
|
||||||
#include "esp_log.h"
|
#include "esp_log.h"
|
||||||
#include "esp_random.h"
|
#include "esp_random.h"
|
||||||
|
#include "esp_timer.h"
|
||||||
#include "esp_vfs.h"
|
#include "esp_vfs.h"
|
||||||
#include "esp_vfs_fat.h"
|
#include "esp_vfs_fat.h"
|
||||||
#include "freertos/FreeRTOS.h"
|
#include "freertos/FreeRTOS.h"
|
||||||
@ -51,6 +52,7 @@
|
|||||||
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S3)
|
#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32S3)
|
||||||
// No runner
|
// No runner
|
||||||
#include "driver/sdmmc_host.h"
|
#include "driver/sdmmc_host.h"
|
||||||
|
const char* base_path = "/sdcard";
|
||||||
|
|
||||||
static void test_setup_sdmmc(sdmmc_card_t **out_card)
|
static void test_setup_sdmmc(sdmmc_card_t **out_card)
|
||||||
{
|
{
|
||||||
@ -62,7 +64,7 @@ static void test_setup_sdmmc(sdmmc_card_t **out_card)
|
|||||||
.max_files = 5,
|
.max_files = 5,
|
||||||
.allocation_unit_size = 16 * 1024
|
.allocation_unit_size = 16 * 1024
|
||||||
};
|
};
|
||||||
TEST_ESP_OK(esp_vfs_fat_sdmmc_mount("/sdcard", &host, &slot_config, &mount_config, &card));
|
TEST_ESP_OK(esp_vfs_fat_sdmmc_mount(base_path, &host, &slot_config, &mount_config, &card));
|
||||||
*out_card = card;
|
*out_card = card;
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -315,6 +317,231 @@ static void sdmmc_speed_test(void *buf, size_t buf_size, size_t file_size, bool
|
|||||||
TEST_ESP_OK(esp_vfs_fat_sdcard_unmount("/sdcard", card));
|
TEST_ESP_OK(esp_vfs_fat_sdcard_unmount("/sdcard", card));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
TEST_CASE("(SD) mount FAT partitions and readdir to get stat structure", "[fatfs][sdmmc]")
|
||||||
|
{
|
||||||
|
char name_dir_file[64];
|
||||||
|
char name_dir_stat[64] = {0};
|
||||||
|
const char* dir_prefix = "/sdcard";
|
||||||
|
int dir_prefix_len = strlen(dir_prefix);
|
||||||
|
int file_num = 300;
|
||||||
|
|
||||||
|
/* Mount FATFS in SD can WL at the same time. Create a file on each FS */
|
||||||
|
sdmmc_card_t* card = NULL;
|
||||||
|
test_setup_sdmmc(&card);
|
||||||
|
TEST_ESP_OK(esp_vfs_fat_sdcard_format("/sdcard", card));
|
||||||
|
|
||||||
|
//Create multiple files with text on sdcard. Each file size is 14 bytes
|
||||||
|
//Total files created are file_num (300 in this case)
|
||||||
|
//So directory size will be 300*14 bytes
|
||||||
|
for(int i=0;i<file_num;i++) {
|
||||||
|
snprintf(name_dir_file, sizeof(name_dir_file), "%s/boo_%d.bin", dir_prefix, i);
|
||||||
|
test_fatfs_create_file_with_text(name_dir_file, fatfs_test_hello_str);
|
||||||
|
}
|
||||||
|
|
||||||
|
//Start the timer to get time needed to calculate the directory size
|
||||||
|
int64_t start = esp_timer_get_time();
|
||||||
|
DIR* dir = opendir(dir_prefix);
|
||||||
|
TEST_ASSERT_NOT_NULL(dir);
|
||||||
|
struct stat st;
|
||||||
|
struct dirent* de;
|
||||||
|
uint32_t dir_size = 0;
|
||||||
|
|
||||||
|
// Call readdir before stat function and record the time needed to calculate the directory size
|
||||||
|
while(1) {
|
||||||
|
de = readdir(dir);
|
||||||
|
if (!de) {
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
snprintf(name_dir_stat, dir_prefix_len+sizeof(de->d_name)+1, "%s/%s", dir_prefix, de->d_name);
|
||||||
|
TEST_ASSERT_EQUAL(0, stat(name_dir_stat, &st));
|
||||||
|
dir_size += st.st_size;
|
||||||
|
}
|
||||||
|
TEST_ASSERT_EQUAL(0, closedir(dir));
|
||||||
|
int64_t end = esp_timer_get_time();
|
||||||
|
int64_t total_time_readdir = end-start;
|
||||||
|
printf("Time in us for calculating directory size by calling readdir first and then stat func: %lld \n",total_time_readdir);
|
||||||
|
printf("Size of the directory %s is %"PRIu32"Kb\n", dir_prefix, (dir_size/1000));
|
||||||
|
TEST_ASSERT_EQUAL(file_num*strlen(fatfs_test_hello_str), dir_size); //each file size is 14 bytes
|
||||||
|
|
||||||
|
// Call stat function directly without calling readdir and record the time needed to calculate the directory size
|
||||||
|
dir_size = 0;
|
||||||
|
start = esp_timer_get_time();
|
||||||
|
for(int i=0;i<file_num;i++) {
|
||||||
|
snprintf(name_dir_file, sizeof(name_dir_file), "%s/boo_%d.bin", dir_prefix, i);
|
||||||
|
TEST_ASSERT_EQUAL(0, stat(name_dir_file, &st));
|
||||||
|
dir_size += st.st_size;
|
||||||
|
}
|
||||||
|
end = esp_timer_get_time();
|
||||||
|
int64_t total_time_stat = end-start;
|
||||||
|
printf("Time in us for calculating directory size by calling stat func: %lld \n",total_time_stat);
|
||||||
|
printf("Size of the directory %s is %"PRIu32"Kb\n", dir_prefix, (dir_size/1000));
|
||||||
|
printf("%d\n", strlen(fatfs_test_hello_str));
|
||||||
|
TEST_ASSERT_EQUAL(file_num*strlen(fatfs_test_hello_str), dir_size); //each file size is 14 bytes
|
||||||
|
|
||||||
|
for(int i=0;i<file_num;i++) {
|
||||||
|
snprintf(name_dir_file, sizeof(name_dir_file), "%s/boo_%d.bin", dir_prefix,i);
|
||||||
|
unlink(name_dir_file);
|
||||||
|
}
|
||||||
|
|
||||||
|
test_teardown_sdmmc(card);
|
||||||
|
}
|
||||||
|
|
||||||
|
typedef struct {
|
||||||
|
const char *dir;
|
||||||
|
const char *filename;
|
||||||
|
const char *str;
|
||||||
|
SemaphoreHandle_t sem;
|
||||||
|
} test_task_param_t;
|
||||||
|
|
||||||
|
static void test_task(void *param)
|
||||||
|
{
|
||||||
|
DIR* dir = NULL;
|
||||||
|
struct dirent* de = NULL;
|
||||||
|
struct stat st;
|
||||||
|
char name_dir_stat[64] = {0};
|
||||||
|
const test_task_param_t *test_task_param = param;
|
||||||
|
|
||||||
|
dir = opendir(test_task_param->dir);
|
||||||
|
TEST_ASSERT_NOT_NULL(dir);
|
||||||
|
while(1) {
|
||||||
|
de = readdir(dir);
|
||||||
|
if (!de) {
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
//Intentionally introduced a delay to ensure that the second task is triggered simultaneously.
|
||||||
|
vTaskDelay(10 / portTICK_PERIOD_MS);
|
||||||
|
snprintf(name_dir_stat, sizeof(test_task_param->dir)+sizeof(de->d_name), "%s/%s", test_task_param->dir, de->d_name);
|
||||||
|
TEST_ASSERT_EQUAL(0, stat(name_dir_stat, &st));
|
||||||
|
if (strcasecmp(de->d_name, test_task_param->filename) == 0) {
|
||||||
|
TEST_ASSERT_FALSE(st.st_mode & S_IFDIR);
|
||||||
|
TEST_ASSERT_EQUAL(strlen(test_task_param->str), st.st_size);
|
||||||
|
} else {
|
||||||
|
TEST_FAIL_MESSAGE("unexpected directory entry");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if (test_task_param->sem) {
|
||||||
|
xSemaphoreGive(test_task_param->sem);
|
||||||
|
}
|
||||||
|
vTaskDelete(NULL);
|
||||||
|
}
|
||||||
|
|
||||||
|
TEST_CASE("(SD) mount two FAT partitions, SDMMC and WL, at the same time and readdir to get stat structure", "[fatfs][sdmmc]")
|
||||||
|
{
|
||||||
|
esp_vfs_fat_sdmmc_mount_config_t mount_config = {
|
||||||
|
.format_if_mount_failed = true,
|
||||||
|
.max_files = 5
|
||||||
|
};
|
||||||
|
|
||||||
|
const char *dir_prefix[FF_VOLUMES] = {"/sdcard", "/spiflash"};
|
||||||
|
const char *dir_filename[FF_VOLUMES] = {"sd.txt", "wl.txt"};
|
||||||
|
const char* str[FF_VOLUMES] = {"this is sd\n", "this is spiflash\n"};
|
||||||
|
const char* filename_sd = "/sdcard/sd.txt";
|
||||||
|
const char* filename_wl = "/spiflash/wl.txt";
|
||||||
|
|
||||||
|
/* Erase flash before the first use */
|
||||||
|
const esp_partition_t *test_partition = esp_partition_find_first(ESP_PARTITION_TYPE_DATA, ESP_PARTITION_SUBTYPE_DATA_FAT, NULL);
|
||||||
|
TEST_ASSERT_NOT_NULL(test_partition);
|
||||||
|
esp_partition_erase_range(test_partition, 0, test_partition->size);
|
||||||
|
|
||||||
|
/* Mount FATFS in SD can WL at the same time. Create a file on each FS */
|
||||||
|
wl_handle_t wl_handle = WL_INVALID_HANDLE;
|
||||||
|
sdmmc_card_t *card = NULL;
|
||||||
|
test_setup_sdmmc(&card);
|
||||||
|
TEST_ESP_OK(esp_vfs_fat_spiflash_mount_rw_wl("/spiflash", NULL, &mount_config, &wl_handle));
|
||||||
|
unlink(filename_sd);
|
||||||
|
unlink(filename_wl);
|
||||||
|
test_fatfs_create_file_with_text(filename_sd, str[0]);
|
||||||
|
test_fatfs_create_file_with_text(filename_wl, str[1]);
|
||||||
|
|
||||||
|
test_task_param_t test_task_param_sd = {
|
||||||
|
.dir = dir_prefix[0],
|
||||||
|
.filename = dir_filename[0],
|
||||||
|
.str = str[0],
|
||||||
|
.sem = xSemaphoreCreateBinary(),
|
||||||
|
};
|
||||||
|
|
||||||
|
test_task_param_t test_task_param_spiflash = {
|
||||||
|
.dir = dir_prefix[1],
|
||||||
|
.filename = dir_filename[1],
|
||||||
|
.str = str[1],
|
||||||
|
.sem = xSemaphoreCreateBinary(),
|
||||||
|
};
|
||||||
|
|
||||||
|
//Create two tasks with same priority to check file size on two different FAT partitions at the same time
|
||||||
|
xTaskCreate(test_task, "test_task_1", 8*1024, (void *) &test_task_param_sd, 5, NULL);
|
||||||
|
xTaskCreate(test_task, "test_task_2", 8*1024, (void *) &test_task_param_spiflash, 5, NULL);
|
||||||
|
|
||||||
|
TEST_ASSERT_EQUAL(pdTRUE, xSemaphoreTake(test_task_param_sd.sem, 1000 / portTICK_PERIOD_MS));
|
||||||
|
vSemaphoreDelete(test_task_param_sd.sem);
|
||||||
|
TEST_ASSERT_EQUAL(pdTRUE, xSemaphoreTake(test_task_param_spiflash.sem, 1000 / portTICK_PERIOD_MS));
|
||||||
|
vSemaphoreDelete(test_task_param_spiflash.sem);
|
||||||
|
TEST_ESP_OK(esp_vfs_fat_spiflash_unmount_rw_wl("/spiflash", wl_handle));
|
||||||
|
test_teardown_sdmmc(card);
|
||||||
|
}
|
||||||
|
|
||||||
|
TEST_CASE("(SD) read two directories and get stat structure for respective file at the same time", "[fatfs][sdmmc]")
|
||||||
|
{
|
||||||
|
char name_dir_file[64];
|
||||||
|
char name_dir1_stat[64] = {0};
|
||||||
|
char name_dir2_stat[64] = {0};
|
||||||
|
const char* dir1_prefix = "/sdcard/dir1";
|
||||||
|
const char* dir2_prefix = "/sdcard/dir2";
|
||||||
|
int dir1_prefix_len = strlen(dir1_prefix);
|
||||||
|
int dir2_prefix_len = strlen(dir2_prefix);
|
||||||
|
const char* test_str1 = "Hello, World!\n";
|
||||||
|
const char* test_str2 = "Hello, ESP Community\n";
|
||||||
|
|
||||||
|
/* Mount FATFS in SD can WL at the same time. Create a file on each FS */
|
||||||
|
sdmmc_card_t* card = NULL;
|
||||||
|
test_setup_sdmmc(&card);
|
||||||
|
|
||||||
|
TEST_ASSERT_EQUAL(0, mkdir(dir1_prefix, 0755));
|
||||||
|
TEST_ASSERT_EQUAL(0, mkdir(dir2_prefix, 0755));
|
||||||
|
|
||||||
|
snprintf(name_dir_file, sizeof(name_dir_file), "%s/boo_1.bin", dir1_prefix);
|
||||||
|
test_fatfs_create_file_with_text(name_dir_file, test_str1);
|
||||||
|
snprintf(name_dir_file, sizeof(name_dir_file), "%s/boo_1.bin", dir2_prefix);
|
||||||
|
test_fatfs_create_file_with_text(name_dir_file, test_str2);
|
||||||
|
|
||||||
|
DIR* dir1 = opendir(dir1_prefix);
|
||||||
|
TEST_ASSERT_NOT_NULL(dir1);
|
||||||
|
DIR* dir2 = opendir(dir2_prefix);
|
||||||
|
TEST_ASSERT_NOT_NULL(dir2);
|
||||||
|
struct dirent* de1;
|
||||||
|
struct dirent* de2;
|
||||||
|
struct stat st1;
|
||||||
|
struct stat st2;
|
||||||
|
|
||||||
|
while(1) {
|
||||||
|
de1 = readdir(dir1);
|
||||||
|
if (!de1) {
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
de2 = readdir(dir2);
|
||||||
|
if (!de2) {
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
snprintf(name_dir1_stat, dir1_prefix_len+sizeof(de1->d_name)+1, "%s/%s", dir1_prefix, de1->d_name);
|
||||||
|
snprintf(name_dir2_stat, dir2_prefix_len+sizeof(de2->d_name)+1, "%s/%s", dir2_prefix, de2->d_name);
|
||||||
|
TEST_ASSERT_EQUAL(0, stat(name_dir1_stat, &st1));
|
||||||
|
TEST_ASSERT_EQUAL(0, stat(name_dir2_stat, &st2));
|
||||||
|
TEST_ASSERT_EQUAL(strlen(test_str1), st1.st_size); //size of dir1/boo_1.bin is 14
|
||||||
|
TEST_ASSERT_EQUAL(strlen(test_str2), st2.st_size); //size of dir2/boo_1.bin is 21
|
||||||
|
}
|
||||||
|
TEST_ASSERT_EQUAL(0, closedir(dir1));
|
||||||
|
TEST_ASSERT_EQUAL(0, closedir(dir2));
|
||||||
|
|
||||||
|
snprintf(name_dir_file, sizeof(name_dir_file), "%s/boo_1.bin", dir1_prefix);
|
||||||
|
unlink(name_dir_file);
|
||||||
|
snprintf(name_dir_file, sizeof(name_dir_file), "%s/boo_1.bin", dir2_prefix);
|
||||||
|
unlink(name_dir_file);
|
||||||
|
rmdir(dir1_prefix);
|
||||||
|
rmdir(dir2_prefix);
|
||||||
|
|
||||||
|
test_teardown_sdmmc(card);
|
||||||
|
}
|
||||||
|
|
||||||
TEST_CASE("(SD) mount two FAT partitions, SDMMC and WL, at the same time", "[fatfs][sdmmc]")
|
TEST_CASE("(SD) mount two FAT partitions, SDMMC and WL, at the same time", "[fatfs][sdmmc]")
|
||||||
{
|
{
|
||||||
esp_vfs_fat_sdmmc_mount_config_t mount_config = {
|
esp_vfs_fat_sdmmc_mount_config_t mount_config = {
|
||||||
|
@ -1,3 +1,3 @@
|
|||||||
idf_component_register(SRCS "test_fatfs_common.c"
|
idf_component_register(SRCS "test_fatfs_common.c"
|
||||||
INCLUDE_DIRS "."
|
INCLUDE_DIRS "."
|
||||||
PRIV_REQUIRES unity fatfs vfs unity)
|
PRIV_REQUIRES unity fatfs vfs unity esp_timer)
|
||||||
|
@ -17,6 +17,7 @@
|
|||||||
#include <utime.h>
|
#include <utime.h>
|
||||||
#include "unity.h"
|
#include "unity.h"
|
||||||
#include "esp_vfs.h"
|
#include "esp_vfs.h"
|
||||||
|
#include "esp_timer.h"
|
||||||
#include "esp_vfs_fat.h"
|
#include "esp_vfs_fat.h"
|
||||||
#include "freertos/FreeRTOS.h"
|
#include "freertos/FreeRTOS.h"
|
||||||
#include "freertos/task.h"
|
#include "freertos/task.h"
|
||||||
@ -756,6 +757,65 @@ void test_fatfs_can_opendir(const char* path)
|
|||||||
unlink(name_dir_file);
|
unlink(name_dir_file);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
void test_fatfs_readdir_stat(const char* dir_prefix)
|
||||||
|
{
|
||||||
|
char name_dir_file[64];
|
||||||
|
char name_dir_stat[64];
|
||||||
|
int file_num = 25;
|
||||||
|
|
||||||
|
rmdir(dir_prefix);
|
||||||
|
TEST_ASSERT_EQUAL(0, mkdir(dir_prefix, 0755));
|
||||||
|
|
||||||
|
for(int i=0;i<file_num;i++) {
|
||||||
|
snprintf(name_dir_file, sizeof(name_dir_file), "%s/boo_%d.bin", dir_prefix,i);
|
||||||
|
test_fatfs_create_file_with_text(name_dir_file, fatfs_test_hello_str);
|
||||||
|
}
|
||||||
|
|
||||||
|
printf("Start counting\n");
|
||||||
|
int64_t start = esp_timer_get_time();
|
||||||
|
DIR* dir = opendir(dir_prefix);
|
||||||
|
TEST_ASSERT_NOT_NULL(dir);
|
||||||
|
struct stat st;
|
||||||
|
struct dirent* de;
|
||||||
|
uint32_t dir_size = 0;
|
||||||
|
|
||||||
|
// Call readdir before stat function and record the time needed to calculate the directory size
|
||||||
|
while(1) {
|
||||||
|
de = readdir(dir);
|
||||||
|
if (!de) {
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
snprintf(name_dir_stat, sizeof(dir_prefix)+sizeof(de->d_name), "%s/%s", dir_prefix, de->d_name);
|
||||||
|
TEST_ASSERT_EQUAL(0, stat(name_dir_stat, &st));
|
||||||
|
dir_size += st.st_size;
|
||||||
|
}
|
||||||
|
TEST_ASSERT_EQUAL(0, closedir(dir));
|
||||||
|
int64_t end = esp_timer_get_time();
|
||||||
|
int64_t total_time_readdir = end-start;
|
||||||
|
printf("Time in us for calculating directory size by calling readdir first and then stat func: %lld \n",total_time_readdir);
|
||||||
|
printf("Size of the directory %s is %"PRIu32"bytes\n", dir_prefix, dir_size);
|
||||||
|
TEST_ASSERT_EQUAL(file_num*14, dir_size); //each file size is 14 bytes
|
||||||
|
|
||||||
|
// Call stat function directly and record the time needed to calculate the directory size
|
||||||
|
dir_size = 0;
|
||||||
|
start = esp_timer_get_time();
|
||||||
|
for(int i=0;i<file_num;i++) {
|
||||||
|
snprintf(name_dir_file, sizeof(name_dir_file), "%s/boo_%d.bin", dir_prefix, i);
|
||||||
|
TEST_ASSERT_EQUAL(0, stat(name_dir_file, &st));
|
||||||
|
dir_size += st.st_size;
|
||||||
|
}
|
||||||
|
end = esp_timer_get_time();
|
||||||
|
int64_t total_time_stat = end-start;
|
||||||
|
printf("Time in us for calculating directory size by calling stat func: %lld \n",total_time_stat);
|
||||||
|
printf("Size of the directory %s is %"PRIu32"bytes\n", dir_prefix, dir_size);
|
||||||
|
TEST_ASSERT_EQUAL(file_num*14, dir_size); //each file size is 14 bytes
|
||||||
|
|
||||||
|
for(int i=0;i<file_num;i++) {
|
||||||
|
snprintf(name_dir_file, sizeof(name_dir_file), "%s/boo_%d.bin", dir_prefix,i);
|
||||||
|
unlink(name_dir_file);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
void test_fatfs_opendir_readdir_rewinddir(const char* dir_prefix)
|
void test_fatfs_opendir_readdir_rewinddir(const char* dir_prefix)
|
||||||
{
|
{
|
||||||
char name_dir_inner_file[64];
|
char name_dir_inner_file[64];
|
||||||
|
@ -80,3 +80,5 @@ void test_fatfs_info(const char* base_path, const char* filepath);
|
|||||||
#if FF_USE_EXPAND
|
#if FF_USE_EXPAND
|
||||||
void test_fatfs_create_contiguous_file(const char* base_path, const char* full_path);
|
void test_fatfs_create_contiguous_file(const char* base_path, const char* full_path);
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
|
void test_fatfs_readdir_stat(const char* path);
|
||||||
|
@ -20,6 +20,17 @@
|
|||||||
|
|
||||||
#define F_WRITE_MALLOC_ZEROING_BUF_SIZE_LIMIT 512
|
#define F_WRITE_MALLOC_ZEROING_BUF_SIZE_LIMIT 512
|
||||||
|
|
||||||
|
#ifdef CONFIG_VFS_SUPPORT_DIR
|
||||||
|
struct cached_data{
|
||||||
|
#if FF_USE_LFN
|
||||||
|
char file_path[FILENAME_MAX+FF_LFN_BUF+1];
|
||||||
|
#else
|
||||||
|
char file_path[FILENAME_MAX+FF_SFN_BUF+1];
|
||||||
|
#endif
|
||||||
|
FILINFO fileinfo;
|
||||||
|
};
|
||||||
|
#endif
|
||||||
|
|
||||||
typedef struct {
|
typedef struct {
|
||||||
char fat_drive[8]; /* FAT drive name */
|
char fat_drive[8]; /* FAT drive name */
|
||||||
char base_path[ESP_VFS_PATH_MAX]; /* base path in VFS where partition is registered */
|
char base_path[ESP_VFS_PATH_MAX]; /* base path in VFS where partition is registered */
|
||||||
@ -29,6 +40,10 @@ typedef struct {
|
|||||||
char tmp_path_buf[FILENAME_MAX+3]; /* temporary buffer used to prepend drive name to the path */
|
char tmp_path_buf[FILENAME_MAX+3]; /* temporary buffer used to prepend drive name to the path */
|
||||||
char tmp_path_buf2[FILENAME_MAX+3]; /* as above; used in functions which take two path arguments */
|
char tmp_path_buf2[FILENAME_MAX+3]; /* as above; used in functions which take two path arguments */
|
||||||
bool *o_append; /* O_APPEND is stored here for each max_files entries (because O_APPEND is not compatible with FA_OPEN_APPEND) */
|
bool *o_append; /* O_APPEND is stored here for each max_files entries (because O_APPEND is not compatible with FA_OPEN_APPEND) */
|
||||||
|
#ifdef CONFIG_VFS_SUPPORT_DIR
|
||||||
|
char dir_path[FILENAME_MAX]; /* variable to store path of opened directory*/
|
||||||
|
struct cached_data cached_fileinfo;
|
||||||
|
#endif
|
||||||
FIL files[0]; /* array with max_files entries; must be the final member of the structure */
|
FIL files[0]; /* array with max_files entries; must be the final member of the structure */
|
||||||
} vfs_fat_ctx_t;
|
} vfs_fat_ctx_t;
|
||||||
|
|
||||||
@ -94,6 +109,7 @@ static vfs_fat_ctx_t* s_fat_ctxs[FF_VOLUMES] = { NULL };
|
|||||||
//backwards-compatibility with esp_vfs_fat_unregister()
|
//backwards-compatibility with esp_vfs_fat_unregister()
|
||||||
static vfs_fat_ctx_t* s_fat_ctx = NULL;
|
static vfs_fat_ctx_t* s_fat_ctx = NULL;
|
||||||
|
|
||||||
|
|
||||||
static size_t find_context_index_by_path(const char* base_path)
|
static size_t find_context_index_by_path(const char* base_path)
|
||||||
{
|
{
|
||||||
for(size_t i=0; i<FF_VOLUMES; i++) {
|
for(size_t i=0; i<FF_VOLUMES; i++) {
|
||||||
@ -659,34 +675,13 @@ static inline mode_t get_stat_mode(bool is_dir)
|
|||||||
((is_dir) ? S_IFDIR : S_IFREG);
|
((is_dir) ? S_IFDIR : S_IFREG);
|
||||||
}
|
}
|
||||||
|
|
||||||
static int vfs_fat_stat(void* ctx, const char * path, struct stat * st)
|
static void update_stat_struct(struct stat *st, FILINFO *info)
|
||||||
{
|
{
|
||||||
if (strcmp(path, "/") == 0) {
|
|
||||||
/* FatFS f_stat function does not work for the drive root.
|
|
||||||
* Just pretend that this is a directory.
|
|
||||||
*/
|
|
||||||
memset(st, 0, sizeof(*st));
|
|
||||||
st->st_mode = get_stat_mode(true);
|
|
||||||
return 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
vfs_fat_ctx_t* fat_ctx = (vfs_fat_ctx_t*) ctx;
|
|
||||||
_lock_acquire(&fat_ctx->lock);
|
|
||||||
prepend_drive_to_path(fat_ctx, &path, NULL);
|
|
||||||
FILINFO info;
|
|
||||||
FRESULT res = f_stat(path, &info);
|
|
||||||
_lock_release(&fat_ctx->lock);
|
|
||||||
if (res != FR_OK) {
|
|
||||||
ESP_LOGD(TAG, "%s: fresult=%d", __func__, res);
|
|
||||||
errno = fresult_to_errno(res);
|
|
||||||
return -1;
|
|
||||||
}
|
|
||||||
|
|
||||||
memset(st, 0, sizeof(*st));
|
memset(st, 0, sizeof(*st));
|
||||||
st->st_size = info.fsize;
|
st->st_size = info->fsize;
|
||||||
st->st_mode = get_stat_mode((info.fattrib & AM_DIR) != 0);
|
st->st_mode = get_stat_mode((info->fattrib & AM_DIR) != 0);
|
||||||
fat_date_t fdate = { .as_int = info.fdate };
|
fat_date_t fdate = { .as_int = info->fdate };
|
||||||
fat_time_t ftime = { .as_int = info.ftime };
|
fat_time_t ftime = { .as_int = info->ftime };
|
||||||
struct tm tm = {
|
struct tm tm = {
|
||||||
.tm_mday = fdate.mday,
|
.tm_mday = fdate.mday,
|
||||||
.tm_mon = fdate.mon - 1, /* unlike tm_mday, tm_mon is zero-based */
|
.tm_mon = fdate.mon - 1, /* unlike tm_mday, tm_mon is zero-based */
|
||||||
@ -704,6 +699,42 @@ static int vfs_fat_stat(void* ctx, const char * path, struct stat * st)
|
|||||||
st->st_mtime = mktime(&tm);
|
st->st_mtime = mktime(&tm);
|
||||||
st->st_atime = 0;
|
st->st_atime = 0;
|
||||||
st->st_ctime = 0;
|
st->st_ctime = 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
static int vfs_fat_stat(void* ctx, const char * path, struct stat * st)
|
||||||
|
{
|
||||||
|
if (strcmp(path, "/") == 0) {
|
||||||
|
/* FatFS f_stat function does not work for the drive root.
|
||||||
|
* Just pretend that this is a directory.
|
||||||
|
*/
|
||||||
|
memset(st, 0, sizeof(*st));
|
||||||
|
st->st_mode = get_stat_mode(true);
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
vfs_fat_ctx_t* fat_ctx = (vfs_fat_ctx_t*) ctx;
|
||||||
|
|
||||||
|
//If fileinfo is already cached by readdir for requested filename,
|
||||||
|
//then return the same info else obtain fileinfo with f_stat function
|
||||||
|
if (strcmp(path, fat_ctx->cached_fileinfo.file_path) == 0) {
|
||||||
|
update_stat_struct(st, &fat_ctx->cached_fileinfo.fileinfo);
|
||||||
|
memset(&fat_ctx->cached_fileinfo, 0 ,sizeof(FILINFO));
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
memset(&fat_ctx->cached_fileinfo, 0 ,sizeof(fat_ctx->cached_fileinfo));
|
||||||
|
_lock_acquire(&fat_ctx->lock);
|
||||||
|
prepend_drive_to_path(fat_ctx, &path, NULL);
|
||||||
|
FILINFO info;
|
||||||
|
FRESULT res = f_stat(path, &info);
|
||||||
|
_lock_release(&fat_ctx->lock);
|
||||||
|
if (res != FR_OK) {
|
||||||
|
ESP_LOGD(TAG, "%s: fresult=%d", __func__, res);
|
||||||
|
errno = fresult_to_errno(res);
|
||||||
|
return -1;
|
||||||
|
}
|
||||||
|
|
||||||
|
update_stat_struct(st, &info);
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -826,6 +857,7 @@ static int vfs_fat_rename(void* ctx, const char *src, const char *dst)
|
|||||||
static DIR* vfs_fat_opendir(void* ctx, const char* name)
|
static DIR* vfs_fat_opendir(void* ctx, const char* name)
|
||||||
{
|
{
|
||||||
vfs_fat_ctx_t* fat_ctx = (vfs_fat_ctx_t*) ctx;
|
vfs_fat_ctx_t* fat_ctx = (vfs_fat_ctx_t*) ctx;
|
||||||
|
strlcpy(fat_ctx->dir_path, name, FILENAME_MAX);
|
||||||
_lock_acquire(&fat_ctx->lock);
|
_lock_acquire(&fat_ctx->lock);
|
||||||
prepend_drive_to_path(fat_ctx, &name, NULL);
|
prepend_drive_to_path(fat_ctx, &name, NULL);
|
||||||
vfs_fat_dir_t* fat_dir = ff_memalloc(sizeof(vfs_fat_dir_t));
|
vfs_fat_dir_t* fat_dir = ff_memalloc(sizeof(vfs_fat_dir_t));
|
||||||
@ -863,6 +895,7 @@ static int vfs_fat_closedir(void* ctx, DIR* pdir)
|
|||||||
|
|
||||||
static struct dirent* vfs_fat_readdir(void* ctx, DIR* pdir)
|
static struct dirent* vfs_fat_readdir(void* ctx, DIR* pdir)
|
||||||
{
|
{
|
||||||
|
vfs_fat_ctx_t* fat_ctx = (vfs_fat_ctx_t*) ctx;
|
||||||
vfs_fat_dir_t* fat_dir = (vfs_fat_dir_t*) pdir;
|
vfs_fat_dir_t* fat_dir = (vfs_fat_dir_t*) pdir;
|
||||||
struct dirent* out_dirent;
|
struct dirent* out_dirent;
|
||||||
int err = vfs_fat_readdir_r(ctx, pdir, &fat_dir->cur_dirent, &out_dirent);
|
int err = vfs_fat_readdir_r(ctx, pdir, &fat_dir->cur_dirent, &out_dirent);
|
||||||
@ -870,6 +903,19 @@ static struct dirent* vfs_fat_readdir(void* ctx, DIR* pdir)
|
|||||||
errno = err;
|
errno = err;
|
||||||
return NULL;
|
return NULL;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
//Store the FILEINFO in the cached_fileinfo. If the stat function is invoked immediately afterward,
|
||||||
|
//the cached_fileinfo will provide the FILEINFO directly, as it was already obtained during the readdir operation.
|
||||||
|
//During directory size calculation, this optimization can reduce the computation time.
|
||||||
|
memset(&fat_ctx->cached_fileinfo, 0 ,sizeof(fat_ctx->cached_fileinfo));
|
||||||
|
if (strcmp(fat_ctx->dir_path, "/") == 0) {
|
||||||
|
snprintf(fat_ctx->cached_fileinfo.file_path, sizeof(fat_ctx->cached_fileinfo.file_path),
|
||||||
|
"/%s", fat_dir->filinfo.fname);
|
||||||
|
} else {
|
||||||
|
snprintf(fat_ctx->cached_fileinfo.file_path, sizeof(fat_ctx->cached_fileinfo.file_path),
|
||||||
|
"%s/%s", fat_ctx->dir_path, fat_dir->filinfo.fname);
|
||||||
|
}
|
||||||
|
fat_ctx->cached_fileinfo.fileinfo = fat_dir->filinfo;
|
||||||
return out_dirent;
|
return out_dirent;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user