feedc0de/esp-idf
1
0
Fork 0
forked from espressif/esp-idf
Code Pull Requests Activity

Merge branch 'bugfix/freertos_fix_unordered_event_list' into 'master'

Browse Source 
freertos: Updated vTaskRemoveFromUnorderedEventList() to consider scheduler state before adding task to ready list

Closes IDF-5785

See merge request espressif/esp-idf!23482
This commit is contained in:
Zim Kalinowski
2023-05-10 01:48:47 +08:00
parent a495f4729b abe5311a22
commit 54576b7528
1 changed files with 42 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
components/freertos/FreeRTOS-Kernel/tasks.c
View File

@@ -4064,25 +4064,49 @@ void vTaskRemoveFromUnorderedEventList( ListItem_t * pxEventListItem,
configASSERT( pxUnblockedTCB ); configASSERT( pxUnblockedTCB );
( void ) uxListRemove( pxEventListItem ); ( void ) uxListRemove( pxEventListItem );
#if ( configUSE_TICKLESS_IDLE != 0 ) /* Add the task to the ready list if a core with compatible affinity
{ * has NOT suspended its scheduler. This occurs when:
/* If a task is blocked on a kernel object then xNextTaskUnblockTime * - The task is pinned, and the pinned core's scheduler is running
* might be set to the blocked task's time out time. If the task is * - The task is unpinned, and at least one of the core's scheduler is running */
* unblocked for a reason other than a timeout xNextTaskUnblockTime is if( taskCAN_BE_SCHEDULED( pxUnblockedTCB ) )
* normally left unchanged, because it is automatically reset to a new {
* value when the tick count equals xNextTaskUnblockTime. However if ( void ) uxListRemove( &( pxUnblockedTCB->xStateListItem ) );
* tickless idling is used it might be more important to enter sleep mode prvAddTaskToReadyList( pxUnblockedTCB );
* at the earliest possible time - so reset xNextTaskUnblockTime here to
* ensure it is updated at the earliest possible time. */
prvResetNextTaskUnblockTime();
}
#endif
/* Remove the task from the delayed list and add it to the ready list. The #if ( configUSE_TICKLESS_IDLE != 0 )
* scheduler is suspended so interrupts will not be accessing the ready {
* lists. */ /* If a task is blocked on a kernel object then xNextTaskUnblockTime
( void ) uxListRemove( &( pxUnblockedTCB->xStateListItem ) ); * might be set to the blocked task's time out time. If the task is
prvAddTaskToReadyList( pxUnblockedTCB ); * unblocked for a reason other than a timeout xNextTaskUnblockTime is
* normally left unchanged, because it is automatically reset to a new
* value when the tick count equals xNextTaskUnblockTime. However if
* tickless idling is used it might be more important to enter sleep mode
* at the earliest possible time - so reset xNextTaskUnblockTime here to
* ensure it is updated at the earliest possible time. */
prvResetNextTaskUnblockTime();
}
#endif
}
else
{
/* We arrive here due to one of the following possibilities:
* - The task is pinned to core X and core X has suspended its scheduler
* - The task is unpinned and both cores have suspend their schedulers
* Therefore, we add the task to one of the pending lists:
* - If the task is pinned to core X, add it to core X's pending list
* - If the task is unpinned, add it to the current core's pending list */
BaseType_t xPendingListCore;
#if ( configNUM_CORES > 1 )
xPendingListCore = ( ( pxUnblockedTCB->xCoreID == tskNO_AFFINITY ) ? xCurCoreID : pxUnblockedTCB->xCoreID );
#else
xPendingListCore = 0;
#endif /* configNUM_CORES > 1 */
configASSERT( uxSchedulerSuspended[ xPendingListCore ] != ( UBaseType_t ) 0U );
/* The delayed and ready lists cannot be accessed, so hold this task
* pending until the scheduler is resumed. */
vListInsertEnd( &( xPendingReadyList[ xPendingListCore ] ), &( pxUnblockedTCB->xEventListItem ) );
}
if( prvCheckForYield( pxUnblockedTCB, xCurCoreID, pdFALSE ) ) if( prvCheckForYield( pxUnblockedTCB, xCurCoreID, pdFALSE ) )
{ {