feedc0de/esp-idf
1
0
Fork 0
forked from espressif/esp-idf
Code Pull Requests Activity

fix(newlib): fixed potential overflow in usleep

Browse Source 
If trying to usleep for 0xFFFF FFFF us the calculation of delay ticks would overflow
resulting in the system not sleeping at all.

Closes https://github.com/espressif/esp-idf/issues/14390
This commit is contained in:
Marius Vikhammer
2024-08-19 10:46:26 +08:00
parent c01ccd1f62
commit 596f635b28
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
components/newlib/time.c
View File

@@ -200,7 +200,10 @@ WEAK_UNLESS_TIMEFUNC_IMPL int settimeofday(const struct timeval *tv, const struc
int usleep(useconds_t us) int usleep(useconds_t us)
{ {
const int us_per_tick = portTICK_PERIOD_MS * 1000; /* Even at max tick rate, vTaskDelay can still delay for the max of the us argument,
we just need to make sure the tick calculation does not overflow
*/
const int64_t us_per_tick = portTICK_PERIOD_MS * 1000;
if (us < us_per_tick) { if (us < us_per_tick) {
esp_rom_delay_us((uint32_t) us); esp_rom_delay_us((uint32_t) us);
} else { } else {