diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index cb6b1cee62..6bd069fa18 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -22,8 +22,6 @@ repos: - id: end-of-file-fixer exclude: *whitespace_excludes - id: check-executables-have-shebangs - - id: file-contents-sorter - files: 'tools/ci/executable-list.txt' - id: mixed-line-ending args: ['-f=lf'] - id: double-quote-string-fixer @@ -75,3 +73,8 @@ repos: language: python files: '\.gitlab/CODEOWNERS' pass_filenames: false + - repo: https://github.com/pre-commit/pre-commit-hooks + rev: v3.4.0 + hooks: + - id: file-contents-sorter + files: 'tools/ci/executable-list.txt' diff --git a/tools/ci/idf_ci_utils.py b/tools/ci/idf_ci_utils.py index ee92b5db0d..c307af765f 100644 --- a/tools/ci/idf_ci_utils.py +++ b/tools/ci/idf_ci_utils.py @@ -55,8 +55,8 @@ def _check_git_filemode(full_path): # type: (str) -> bool mode = stdout.split(' ', 1)[0] # e.g. 100644 for a rw-r--r-- if any([int(i, 8) & 1 for i in mode[-3:]]): - return False - return True + return True + return False def is_executable(full_path): # type: (str) -> bool