feedc0de/esp-idf
1
0
Fork 0
forked from espressif/esp-idf
Code Pull Requests Activity

VFS: Fix memory access after free() in UART select()

Browse Source 
Closes https://github.com/espressif/esp-idf/issues/4030
This commit is contained in:
Roland Dobai
2019-09-09 15:02:38 +02:00
parent dbf2c3d480
commit 63c2834d7b
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
components/vfs/vfs_uart.c
View File

@@ -474,10 +474,6 @@ static esp_err_t uart_end_select(void *end_select_args)
{ {
uart_select_args_t *args = end_select_args; uart_select_args_t *args = end_select_args;
if (args) {
free(args);
}
portENTER_CRITICAL(uart_get_selectlock()); portENTER_CRITICAL(uart_get_selectlock());
esp_err_t ret = unregister_select(args); esp_err_t ret = unregister_select(args);
for (int i = 0; i < UART_NUM; ++i) { for (int i = 0; i < UART_NUM; ++i) {
@@ -485,6 +481,10 @@ static esp_err_t uart_end_select(void *end_select_args)
} }
portEXIT_CRITICAL(uart_get_selectlock()); portEXIT_CRITICAL(uart_get_selectlock());
if (args) {
free(args);
}
return ret; return ret;
} }