feedc0de/esp-idf
1
0
Fork 0
forked from espressif/esp-idf
Code Pull Requests Activity

Merge branch 'bugfix/ringbuf_coverity_issues' into 'master'

Browse Source 
esp_ringbuf: Fix "USE_AFTER_FREE" coverity issue

Closes IDF-7671

See merge request espressif/esp-idf!24530
This commit is contained in:
morris
2023-07-07 14:44:32 +08:00
parent ad4ab84fd8 4a15db126a
commit 65e1ced886
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
components/esp_ringbuf/ringbuf.c
View File

@@ -1244,15 +1244,12 @@ void vRingbufferDelete(RingbufHandle_t xRingbuffer)
Ringbuffer_t *pxRingbuffer = (Ringbuffer_t *)xRingbuffer; Ringbuffer_t *pxRingbuffer = (Ringbuffer_t *)xRingbuffer;
configASSERT(pxRingbuffer); configASSERT(pxRingbuffer);
#if ( configSUPPORT_STATIC_ALLOCATION == 1 ) //Ring buffer was not statically allocated. Free its memory.
if (pxRingbuffer->uxRingbufferFlags & rbBUFFER_STATIC_FLAG) { if ( !( pxRingbuffer->uxRingbufferFlags & rbBUFFER_STATIC_FLAG ) ) {
//Ring buffer was statically allocated, no need to free
return;
}
#endif
free(pxRingbuffer->pucHead); free(pxRingbuffer->pucHead);
free(pxRingbuffer); free(pxRingbuffer);
} }
}
size_t xRingbufferGetMaxItemSize(RingbufHandle_t xRingbuffer) size_t xRingbufferGetMaxItemSize(RingbufHandle_t xRingbuffer)
{ {