From 8d248d8903550cc036c0ebd63c6dd5494e3286ff Mon Sep 17 00:00:00 2001 From: Frantisek Hrbata Date: Thu, 26 Sep 2024 17:54:34 +0200 Subject: [PATCH] change(ci): disable MINIMAL_BUILD for check_public_headers.py The check_public_headers.py script does not function well with MINIMAL_BUILD enabled, as some headers from excluded components may be missing. While it might be possible to address this issue with exclusions, it is likely more effective and provides more coverage to include all components, not just those required by the blink example. Therefore, MINIMAL_BUILD has been disabled for this test, ensuring that all registered components are included in the build. If defined, the COMPONENTS variable takes precedence over the MINIMAL_BUILD property, so setting "-DCOMPONENTS=" overrides the MINIMAL_BUILD property. Signed-off-by: Frantisek Hrbata --- tools/ci/check_public_headers.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/ci/check_public_headers.py b/tools/ci/check_public_headers.py index 12cd61488b..2b21bae1e1 100644 --- a/tools/ci/check_public_headers.py +++ b/tools/ci/check_public_headers.py @@ -270,7 +270,8 @@ class PublicHeaderChecker: os.unlink(os.path.join(project_dir, 'sdkconfig')) except FileNotFoundError: pass - subprocess.check_call(['idf.py', '-B', build_dir, f'-DSDKCONFIG={sdkconfig}', 'reconfigure'], cwd=project_dir) + subprocess.check_call(['idf.py', '-B', build_dir, f'-DSDKCONFIG={sdkconfig}', '-DCOMPONENTS=', 'reconfigure'], + cwd=project_dir) def get_std(json: List, extension: str) -> str: # compile commands for the files with specified extension, containing C(XX) standard flag