From 9c8517045c207c6617bd4e34b263c4cf5c0fee1b Mon Sep 17 00:00:00 2001 From: Roman Leonov Date: Tue, 28 Jan 2025 10:31:39 +0100 Subject: [PATCH] fix(usb_phy): Removed pull resistors override configuration for Internal FSLS PHY --- components/usb/usb_phy.c | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/components/usb/usb_phy.c b/components/usb/usb_phy.c index c5d510e4a2..30d2faed76 100644 --- a/components/usb/usb_phy.c +++ b/components/usb/usb_phy.c @@ -180,23 +180,7 @@ esp_err_t usb_phy_otg_dev_set_speed(usb_phy_handle_t handle, usb_phy_speed_t spe ESP_RETURN_ON_FALSE((handle->target == USB_PHY_TARGET_UTMI) == (speed == USB_PHY_SPEED_HIGH), ESP_ERR_NOT_SUPPORTED, USBPHY_TAG, "UTMI can be HighSpeed only"); // This is our software limitation handle->otg_speed = speed; - if (handle->target == USB_PHY_TARGET_UTMI) { - return ESP_OK; // No need to configure anything for UTMI PHY - } - - // Configure pull resistors for device - usb_wrap_pull_override_vals_t vals = { - .dp_pd = false, - .dm_pd = false, - }; - if (speed == USB_PHY_SPEED_LOW) { - vals.dp_pu = false; - vals.dm_pu = true; - } else { - vals.dp_pu = true; - vals.dm_pu = false; - } - usb_wrap_hal_phy_enable_pull_override(&handle->wrap_hal, &vals); + // No need to configure anything neither for UTMI PHY nor for Internal USB FSLS PHY return ESP_OK; }