feedc0de/esp-idf
1
0
Fork 0
forked from espressif/esp-idf
Code Pull Requests Activity

fix(cmake): Prevent overwriting of component properties in output file

Browse Source 
While 'component_properties_text'
correctly accumulated properties from all processed components, each
iteration of the loop was overwriting the entire file content.

Move the file(WRITE ...) call outside the loop to ensure all accumulated
component properties are written once, preserving information for all
components.
This commit is contained in:
viayie
2024-10-16 11:32:40 +08:00
parent a97a7b0962
commit bdf0821f97
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tools/cmake/component.cmake
View File

@@ -122,6 +122,7 @@ endfunction()
# keeps a list of all its properties. # keeps a list of all its properties.
# #
function(__component_write_properties output_file) function(__component_write_properties output_file)
set(component_properties_text "")
idf_build_get_property(component_targets __COMPONENT_TARGETS) idf_build_get_property(component_targets __COMPONENT_TARGETS)
foreach(component_target ${component_targets}) foreach(component_target ${component_targets})
__component_get_property(component_properties ${component_target} __COMPONENT_PROPERTIES) __component_get_property(component_properties ${component_target} __COMPONENT_PROPERTIES)
@@ -130,8 +131,8 @@ function(__component_write_properties output_file)
set(component_properties_text set(component_properties_text
"${component_properties_text}\nset(__component_${component_target}_${property} \"${val}\")") "${component_properties_text}\nset(__component_${component_target}_${property} \"${val}\")")
endforeach() endforeach()
file(WRITE ${output_file} "${component_properties_text}")
endforeach() endforeach()
file(WRITE ${output_file} "${component_properties_text}")
endfunction() endfunction()
# #