feedc0de/esp-idf
1
0
Fork 0
forked from espressif/esp-idf
Code Pull Requests Activity

Fixed ssl_ctx not being freed at the time of error.

Browse Source 
Closes https://github.com/espressif/esp-idf/issues/6143
This commit is contained in:
Aditya Patwardhan
2020-11-25 13:02:41 +05:30
parent af992c26bc
commit c707d0d323
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
components/esp_https_server/src/https_server.c
View File

@@ -175,6 +175,7 @@ static httpd_ssl_ctx_t *create_secure_context(const struct httpd_ssl_config *con
if (!cfg->cacert_buf) { if (!cfg->cacert_buf) {
ESP_LOGE(TAG, "Could not allocate memory"); ESP_LOGE(TAG, "Could not allocate memory");
free(cfg); free(cfg);
free(ssl_ctx);
return NULL; return NULL;
} }
memcpy((char *)cfg->cacert_buf, config->client_verify_cert_pem, config->client_verify_cert_len); memcpy((char *)cfg->cacert_buf, config->client_verify_cert_pem, config->client_verify_cert_len);
@@ -186,6 +187,7 @@ static httpd_ssl_ctx_t *create_secure_context(const struct httpd_ssl_config *con
ESP_LOGE(TAG, "Could not allocate memory"); ESP_LOGE(TAG, "Could not allocate memory");
free((void *)cfg->cacert_buf); free((void *)cfg->cacert_buf);
free(cfg); free(cfg);
free(ssl_ctx);
return NULL; return NULL;
} }
memcpy((char *)cfg->servercert_buf, config->cacert_pem, config->cacert_len); memcpy((char *)cfg->servercert_buf, config->cacert_pem, config->cacert_len);
@@ -197,6 +199,7 @@ static httpd_ssl_ctx_t *create_secure_context(const struct httpd_ssl_config *con
free((void *)cfg->servercert_buf); free((void *)cfg->servercert_buf);
free((void *)cfg->cacert_buf); free((void *)cfg->cacert_buf);
free(cfg); free(cfg);
free(ssl_ctx);
return NULL; return NULL;
} }
memcpy((char *)cfg->serverkey_buf, config->prvtkey_pem, config->prvtkey_len); memcpy((char *)cfg->serverkey_buf, config->prvtkey_pem, config->prvtkey_len);