From d36b72ef2331e28c167595103ee704d9dac3ee47 Mon Sep 17 00:00:00 2001 From: Marius Vikhammer Date: Sat, 21 Oct 2023 12:23:07 +0800 Subject: [PATCH 1/2] fix(idf.py): fixed save-defconfig failing due to wrong argument name --- tools/idf_py_actions/core_ext.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/idf_py_actions/core_ext.py b/tools/idf_py_actions/core_ext.py index 5857257191..3466b0e953 100644 --- a/tools/idf_py_actions/core_ext.py +++ b/tools/idf_py_actions/core_ext.py @@ -77,8 +77,8 @@ def action_extensions(base_actions: Dict, project_path: str) -> Any: args.no_hints = True build_target(target_name, ctx, args) - def save_defconfig(target_name: str, ctx: Context, args: PropertyDict, menu_labels: bool) -> None: - if menu_labels: + def save_defconfig(target_name: str, ctx: Context, args: PropertyDict, add_menu_labels: bool) -> None: + if add_menu_labels: os.environ['ESP_IDF_KCONFIG_MIN_LABELS'] = '1' else: # unset variable From 6a3cf1faa21f0a71dbdcdce4af31f9d0bdc3680d Mon Sep 17 00:00:00 2001 From: Marius Vikhammer Date: Sat, 21 Oct 2023 12:40:02 +0800 Subject: [PATCH 2/2] ci(build): add idf.py and idf.py actions as trigger for build-system test --- .gitlab/ci/rules.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab/ci/rules.yml b/.gitlab/ci/rules.yml index 89280b4e56..d7207e9dea 100644 --- a/.gitlab/ci/rules.yml +++ b/.gitlab/ci/rules.yml @@ -58,6 +58,8 @@ .patterns-build_system: &patterns-build_system - "tools/cmake/**/*" - "tools/kconfig_new/**/*" + - "tools/idf.py" + - "tools/idf_py_actions/**/*" - "tools/requirements.json" - "tools/ci/test_build_system*.sh" - "tools/ci/test_build_system*.py"