From d065cc5ce4e7d0e8c81f97fc550ad667b8f4846d Mon Sep 17 00:00:00 2001 From: "nilesh.kale" Date: Mon, 30 Dec 2024 14:01:43 +0530 Subject: [PATCH] fix(esp_http_client): fixed memory leak issue while preparing HTTP digest authentication This commit avoid memory leak while preparing basic HTTP digest authentication. Closes https://github.com/espressif/esp-idf/issues/14885 --- components/esp_http_client/esp_http_client.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/components/esp_http_client/esp_http_client.c b/components/esp_http_client/esp_http_client.c index a1e648e323..ef581df9fb 100644 --- a/components/esp_http_client/esp_http_client.c +++ b/components/esp_http_client/esp_http_client.c @@ -636,6 +636,8 @@ static esp_err_t esp_http_client_prepare_digest_auth(esp_http_client_handle_t cl char *auth_response = NULL; esp_err_t ret = ESP_FAIL; + // Freeing the allocated memory for auth_data->uri and setting it to NULL to prevent potential memory leaks + free(client->auth_data->uri); client->auth_data->uri = NULL; ESP_GOTO_ON_FALSE_DEBUG(http_utils_assign_string(&client->auth_data->uri, client->connection_info.path, -1), ESP_ERR_NO_MEM, error, TAG, "failed to assign string");