From 3d1508db9deff78dbed8d83365fc681dc5fc721c Mon Sep 17 00:00:00 2001 From: Roland Dobai Date: Fri, 8 Jul 2022 18:39:36 +0200 Subject: [PATCH 1/2] Tools: Make espcoredump.py executable Closes https://github.com/espressif/esp-idf/issues/9319 --- components/espcoredump/espcoredump.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 components/espcoredump/espcoredump.py diff --git a/components/espcoredump/espcoredump.py b/components/espcoredump/espcoredump.py old mode 100644 new mode 100755 From e6a76c7e99b1b4c694d1ea06820362e422afaf4e Mon Sep 17 00:00:00 2001 From: Roland Dobai Date: Mon, 11 Jul 2022 10:22:09 +0200 Subject: [PATCH 2/2] CI: Check file is executable if in the list of executables --- tools/ci/check_executables.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tools/ci/check_executables.py b/tools/ci/check_executables.py index 439aff5244..9e1c6cf4eb 100755 --- a/tools/ci/check_executables.py +++ b/tools/ci/check_executables.py @@ -35,11 +35,14 @@ def check_executable_list(): def check_executables(files): ret = 0 for fn in files: - if not is_executable(fn): - continue - if fn not in known_executables: + fn_executable = is_executable(fn) + fn_in_list = fn in known_executables + if fn_executable and not fn_in_list: print('"{}" is not in {}'.format(fn, EXECUTABLE_LIST_FN)) ret = 1 + if not fn_executable and fn_in_list: + print('"{}" is not executable but is in {}'.format(fn, EXECUTABLE_LIST_FN)) + ret = 1 return ret