feedc0de/esp-idf
1
0
Fork 0
forked from espressif/esp-idf
Code Pull Requests Activity

Merge branch 'fix/nvs_sec_provider_coverity_issues' into 'master'

Browse Source 
fix (nvs_sec_provider): Fix memory leakage reported by coverity

See merge request espressif/esp-idf!24555
This commit is contained in:
Mahavir Jain
2023-07-04 22:29:08 +08:00
parent 8b5eea8519 bfaeb075a6
commit de9cb53bc1
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
components/nvs_sec_provider/nvs_sec_provider.c
View File

@@ -63,12 +63,15 @@ esp_err_t nvs_sec_provider_register_flash_enc(const nvs_sec_config_flash_enc_t *
sec_scheme->scheme_data = calloc(1, sizeof(nvs_sec_config_flash_enc_t)); sec_scheme->scheme_data = calloc(1, sizeof(nvs_sec_config_flash_enc_t));
if (sec_scheme->scheme_data == NULL) { if (sec_scheme->scheme_data == NULL) {
free(sec_scheme);
return ESP_ERR_NO_MEM; return ESP_ERR_NO_MEM;
} }
memcpy(sec_scheme->scheme_data, (void *)sec_scheme_cfg, sizeof(nvs_sec_config_flash_enc_t)); memcpy(sec_scheme->scheme_data, (void *)sec_scheme_cfg, sizeof(nvs_sec_config_flash_enc_t));
esp_err_t err = nvs_flash_register_security_scheme(sec_scheme); esp_err_t err = nvs_flash_register_security_scheme(sec_scheme);
if (err != ESP_OK) { if (err != ESP_OK) {
free(sec_scheme->scheme_data);
free(sec_scheme);
return err; return err;
} }
@@ -230,6 +233,7 @@ esp_err_t nvs_sec_provider_register_hmac(const nvs_sec_config_hmac_t *sec_scheme
sec_scheme->scheme_data = calloc(1, sizeof(nvs_sec_config_hmac_t)); sec_scheme->scheme_data = calloc(1, sizeof(nvs_sec_config_hmac_t));
if (sec_scheme->scheme_data == NULL) { if (sec_scheme->scheme_data == NULL) {
free(sec_scheme);
return ESP_ERR_NO_MEM; return ESP_ERR_NO_MEM;
} }
@@ -237,6 +241,8 @@ esp_err_t nvs_sec_provider_register_hmac(const nvs_sec_config_hmac_t *sec_scheme
esp_err_t err = nvs_flash_register_security_scheme(sec_scheme); esp_err_t err = nvs_flash_register_security_scheme(sec_scheme);
if (err != ESP_OK) { if (err != ESP_OK) {
free(sec_scheme->scheme_data);
free(sec_scheme);
return err; return err;
} }