feedc0de/esp-idf
1
0
Fork 0
forked from espressif/esp-idf
Code Pull Requests Activity

Don't return NULL on 0 length input

Browse Source 
A 0 length string is still a valid input and should be treated as such, a NULL return should be reserved for when errors occur during line editing or EOF is reached.

Merges https://github.com/espressif/esp-idf/pull/4926
This commit is contained in:
MadnessASAP
2020-03-12 14:57:27 -07:00
committed by Ivan Grokhotkov
parent 4d53c137e6
commit dfd4227e7a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
components/console/linenoise/linenoise.c
View File

@@ -979,11 +979,11 @@ char *linenoise(const char *prompt) {
} else { } else {
count = linenoiseDumb(buf, LINENOISE_MAX_LINE, prompt); count = linenoiseDumb(buf, LINENOISE_MAX_LINE, prompt);
} }
if (count > 0) { if (count >= 0) {
sanitize(buf); sanitize(buf);
count = strlen(buf); count = strlen(buf);
} }
if (count <= 0) { if (count < 0) {
free(buf); free(buf);
return NULL; return NULL;
} }