feedc0de/esp-idf
1
0
Fork 0
forked from espressif/esp-idf
Code Pull Requests Activity

Merge branch 'contrib/github_pr_8419' into 'master'

Browse Source 
Added typing to serial_write() (GitHub PR)

Closes IDFGH-6792

See merge request espressif/esp-idf!17193
This commit is contained in:
Roland Dobai
2022-02-17 19:46:06 +00:00
parent 41e1eea9a9 9f97e5c84e
commit e18fb46bc0
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tools/idf_monitor.py
View File

@@ -178,7 +178,7 @@ class Monitor:
pass pass
normal_print('\n') normal_print('\n')
def serial_write(self, *args, **kwargs): # type: ignore def serial_write(self, *args: str, **kwargs: str) -> None:
raise NotImplementedError raise NotImplementedError
def check_gdb_stub_and_run(self, line: bytes) -> None: def check_gdb_stub_and_run(self, line: bytes) -> None:
@@ -237,7 +237,7 @@ class SerialMonitor(Monitor):
self.gdb_helper.gdb_exit = False self.gdb_helper.gdb_exit = False
self.serial_handler.start_cmd_sent = False self.serial_handler.start_cmd_sent = False
def serial_write(self, *args, **kwargs): # type: ignore def serial_write(self, *args: str, **kwargs: str) -> None:
self.serial: serial.Serial self.serial: serial.Serial
try: try:
self.serial.write(*args, **kwargs) self.serial.write(*args, **kwargs)
@@ -268,7 +268,7 @@ class LinuxMonitor(Monitor):
self.console_reader.start() self.console_reader.start()
self.serial_reader.start() self.serial_reader.start()
def serial_write(self, *args, **kwargs): # type: ignore def serial_write(self, *args: str, **kwargs: str) -> None:
self.serial.stdin.write(*args, **kwargs) self.serial.stdin.write(*args, **kwargs)
def check_gdb_stub_and_run(self, line: bytes) -> None: def check_gdb_stub_and_run(self, line: bytes) -> None: