feedc0de/esp-idf
1
0
Fork 0
forked from espressif/esp-idf
Code Pull Requests Activity

feat(tools): sanitize all fixtures using test names

Browse Source 
The parametrization include `[` and `]` in names. This is not
possible to use within path. Expand the sanitization into all
fixtures using request.node.name.
This commit is contained in:
Marek Fiala
2024-08-16 15:31:30 +02:00
parent ccbb415be8
commit e95aff7ca9
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tools/test_build_system/conftest.py
View File

@@ -133,7 +133,9 @@ def test_app_copy(func_work_dir: Path, request: FixtureRequest) -> typing.Genera
@pytest.fixture @pytest.fixture
def test_git_template_app(func_work_dir: Path, request: FixtureRequest) -> typing.Generator[Path, None, None]: def test_git_template_app(func_work_dir: Path, request: FixtureRequest) -> typing.Generator[Path, None, None]:
copy_to = request.node.name + '_app' # sanitize test name in case pytest.mark.parametrize was used
test_name_sanitized = request.node.name.replace('[', '_').replace(']', '')
copy_to = test_name_sanitized + '_app'
path_to = func_work_dir / copy_to path_to = func_work_dir / copy_to
logging.debug(f'cloning git-template app to {path_to}') logging.debug(f'cloning git-template app to {path_to}')
@@ -156,11 +158,13 @@ def test_git_template_app(func_work_dir: Path, request: FixtureRequest) -> typin
@pytest.fixture @pytest.fixture
def idf_copy(func_work_dir: Path, request: FixtureRequest) -> typing.Generator[Path, None, None]: def idf_copy(func_work_dir: Path, request: FixtureRequest) -> typing.Generator[Path, None, None]:
copy_to = request.node.name + '_idf' # sanitize test name in case pytest.mark.parametrize was used
test_name_sanitized = request.node.name.replace('[', '_').replace(']', '')
copy_to = test_name_sanitized + '_idf'
# allow overriding the destination via pytest.mark.idf_copy_with_space so the destination contain space # allow overriding the destination via pytest.mark.idf_copy_with_space so the destination contain space
mark_with_space = request.node.get_closest_marker('idf_copy_with_space') mark_with_space = request.node.get_closest_marker('idf_copy_with_space')
if mark_with_space: if mark_with_space:
copy_to = request.node.name + ' idf' copy_to = test_name_sanitized + ' idf'
# allow overriding the destination via pytest.mark.idf_copy() # allow overriding the destination via pytest.mark.idf_copy()
mark = request.node.get_closest_marker('idf_copy') mark = request.node.get_closest_marker('idf_copy')