From 32b86e8dcde788ede4a3e047b0f3c7dad071d329 Mon Sep 17 00:00:00 2001 From: Kabir Waraich <90755626+kabirwbt@users.noreply.github.com> Date: Wed, 13 Nov 2024 18:28:47 +0530 Subject: [PATCH 1/2] Update slave.c to fix the mode There is an issue in the lines that I have changed. I think it was copied over from the enum by mistake. --- examples/protocols/modbus/serial/mb_slave/main/slave.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/protocols/modbus/serial/mb_slave/main/slave.c b/examples/protocols/modbus/serial/mb_slave/main/slave.c index 1edd4a9392..166008a8de 100644 --- a/examples/protocols/modbus/serial/mb_slave/main/slave.c +++ b/examples/protocols/modbus/serial/mb_slave/main/slave.c @@ -101,9 +101,9 @@ void app_main(void) // Setup communication parameters and start stack #if CONFIG_MB_COMM_MODE_ASCII - comm_info.mode = MB_MODE_ASCII, + comm_info.mode = MB_MODE_ASCII; #elif CONFIG_MB_COMM_MODE_RTU - comm_info.mode = MB_MODE_RTU, + comm_info.mode = MB_MODE_RTU; #endif comm_info.slave_addr = MB_SLAVE_ADDR; comm_info.port = MB_PORT_NUM; From 395ad7cd63a949380b5232b051b42bbfd39921f6 Mon Sep 17 00:00:00 2001 From: aleks Date: Mon, 2 Dec 2024 14:20:11 +0100 Subject: [PATCH 2/2] fix(modbus): Fix the mode setup in modbus slave https://github.com/espressif/esp-idf/pull/14878 --- examples/protocols/modbus/serial/mb_slave/main/slave.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/protocols/modbus/serial/mb_slave/main/slave.c b/examples/protocols/modbus/serial/mb_slave/main/slave.c index 166008a8de..0a78252f89 100644 --- a/examples/protocols/modbus/serial/mb_slave/main/slave.c +++ b/examples/protocols/modbus/serial/mb_slave/main/slave.c @@ -99,7 +99,7 @@ void app_main(void) ESP_ERROR_CHECK(mbc_slave_init(MB_PORT_SERIAL_SLAVE, &mbc_slave_handler)); // Initialization of Modbus controller - // Setup communication parameters and start stack + // Setup communication mode and start stack #if CONFIG_MB_COMM_MODE_ASCII comm_info.mode = MB_MODE_ASCII; #elif CONFIG_MB_COMM_MODE_RTU