From f1ba2b3e3a37f5d6dde90b79bff3f57e6d699f44 Mon Sep 17 00:00:00 2001 From: Alex Henrie Date: Tue, 20 Jul 2021 13:52:53 -0600 Subject: [PATCH 1/2] Fix memory leak on error path in md5_printf --- components/esp_http_client/lib/http_auth.c | 1 + 1 file changed, 1 insertion(+) diff --git a/components/esp_http_client/lib/http_auth.c b/components/esp_http_client/lib/http_auth.c index ef30dc4043..0a1e46526a 100644 --- a/components/esp_http_client/lib/http_auth.c +++ b/components/esp_http_client/lib/http_auth.c @@ -51,6 +51,7 @@ static int md5_printf(char *md, const char *fmt, ...) va_start(ap, fmt); len = vasprintf((char **)&buf, fmt, ap); if (buf == NULL) { + va_end(ap); return ESP_FAIL; } From 5401610a4eb3c03ec2780aba36a782e86f128781 Mon Sep 17 00:00:00 2001 From: Alex Henrie Date: Tue, 20 Jul 2021 13:52:53 -0600 Subject: [PATCH 2/2] Fix memory leak on error path in http_header_set_format --- components/esp_http_client/lib/http_header.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/esp_http_client/lib/http_header.c b/components/esp_http_client/lib/http_header.c index 0e41786ec7..265bbbe7aa 100644 --- a/components/esp_http_client/lib/http_header.c +++ b/components/esp_http_client/lib/http_header.c @@ -161,8 +161,8 @@ int http_header_set_format(http_header_handle_t header, const char *key, const c char *buf = NULL; va_start(argptr, format); len = vasprintf(&buf, format, argptr); - HTTP_MEM_CHECK(TAG, buf, return 0); va_end(argptr); + HTTP_MEM_CHECK(TAG, buf, return 0); if (buf == NULL) { return 0; }