From 845c2a3a1e112af5dbe5f3a9ee8f6adb92a03757 Mon Sep 17 00:00:00 2001
From: Axel Lin <axel.lin@ingics.com>
Date: Mon, 9 Nov 2020 16:04:27 +0800
Subject: [PATCH] mqtt: Fix missing MQTT_API_UNLOCK in esp_mqtt_client_stop
 error path

Fixes: 5e17dcaeb257 ("MQTT: Fix esp_mqtt_client_stop deadlock")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 mqtt_client.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mqtt_client.c b/mqtt_client.c
index fed7e7b..94c6158 100644
--- a/mqtt_client.c
+++ b/mqtt_client.c
@@ -1494,6 +1494,7 @@ esp_err_t esp_mqtt_client_stop(esp_mqtt_client_handle_t client)
         /* A running client cannot be stopped from the MQTT task/event handler */
         TaskHandle_t running_task = xTaskGetCurrentTaskHandle();
         if (running_task == client->task_handle) {
+            MQTT_API_UNLOCK(client);
             ESP_LOGE(TAG, "Client cannot be stopped from MQTT task");
             return ESP_FAIL;
         }