feedc0de/esp-mqtt
1
0
Fork 0
forked from espressif/esp-mqtt
Code Pull Requests Activity

outbox: suppress clang-tidy warning of using ptr after free (no possible for STAILQ structure), removed unnecessary print

Browse Source
This commit is contained in:
David Cermak
2019-05-31 15:33:12 +02:00
parent a4d1ef8d79
commit 971bf47e14
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/mqtt_outbox.c
View File

@ -152,7 +152,6 @@ int outbox_delete_expired(outbox_handle_t outbox, int current_tick, int timeout)
STAILQ_FOREACH_SAFE(item, outbox, next, tmp) { STAILQ_FOREACH_SAFE(item, outbox, next, tmp) {
if (current_tick - item->tick > timeout) { if (current_tick - item->tick > timeout) {
STAILQ_REMOVE(outbox, item, outbox_item, next); STAILQ_REMOVE(outbox, item, outbox_item, next);
printf("free message\n");
free(item->buffer); free(item->buffer);
free(item); free(item);
deleted_items ++; deleted_items ++;
@ -167,7 +166,9 @@ int outbox_get_size(outbox_handle_t outbox)
int siz = 0; int siz = 0;
outbox_item_handle_t item; outbox_item_handle_t item;
STAILQ_FOREACH(item, outbox, next) { STAILQ_FOREACH(item, outbox, next) {
siz += item->len; // Suppressing "use after free" warning as this could happen only if queue is in inconsistent state
// which never happens if STAILQ interface used
siz += item->len; // NOLINT(clang-analyzer-unix.Malloc)
} }
return siz; return siz;
} }