feedc0de/esp-nimble-cpp
1
0 Fork 0
forked from h2zero/esp-nimble-cpp
Code Pull Requests Activity

Refactor NimBLERemoteCharacteristic::subscribe

Browse Source 
* Rearrange subscribe parameters to remove requirement of specifying write response to register a callback.
This commit is contained in:
h2zero committed 2020-07-08 21:10:11 -06:00
1 parent 2af26fad1f
commit 6df7b1331a
2 files changed
+12 -12
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/NimBLERemoteCharacteristic.h
+4 -4
View File
@@ -104,9 +104,9 @@ public:
}
bool subscribe(bool notifications = true,
bool response = true,
notify_callback notifyCallback = nullptr);
bool unsubscribe(bool response = true);
notify_callback notifyCallback = nullptr,
bool response = false);
bool unsubscribe(bool response = false);
bool registerForNotify(notify_callback notifyCallback,
bool notifications = true,
bool response = true)
@@ -138,7 +138,7 @@ private:
friend class NimBLERemoteDescriptor;
// Private member functions
bool setNotify(uint16_t val, bool response = true, notify_callback notifyCallback = nullptr);
bool setNotify(uint16_t val, notify_callback notifyCallback = nullptr, bool response = true);
bool retrieveDescriptors(const NimBLEUUID *uuid_filter = nullptr);
static int onReadCB(uint16_t conn_handle, const struct ble_gatt_error *error,
struct ble_gatt_attr *attr, void *arg);