feedc0de/esp-protocols
1
0
Fork 0
forked from espressif/esp-protocols
Code Pull Requests Activity

fix(modem): Fix DUAL_MODE regression from cb6e03ac

Browse Source 
In the recent DTE refactoring (cb6e03ac) we install terminal callbacks
in the constructor, but the change missed initializing modem_state
in DTE constructors which take two terminals as arguments to work in
DUAL mode.
This commit is contained in:
David Cermak
2023-10-12 12:49:41 +02:00
parent 93dd56750e
commit 2aada0f308
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
components/esp_modem/src/esp_modem_dte.cpp
View File

@ -33,7 +33,7 @@ DTE::DTE(std::unique_ptr<Terminal> terminal):
DTE::DTE(const esp_modem_dte_config *config, std::unique_ptr<Terminal> t, std::unique_ptr<Terminal> s): DTE::DTE(const esp_modem_dte_config *config, std::unique_ptr<Terminal> t, std::unique_ptr<Terminal> s):
buffer(config->dte_buffer_size), buffer(config->dte_buffer_size),
cmux_term(nullptr), primary_term(std::move(t)), secondary_term(std::move(s)), cmux_term(nullptr), primary_term(std::move(t)), secondary_term(std::move(s)),
mode(modem_mode::UNDEF) mode(modem_mode::DUAL_MODE)
{ {
set_command_callbacks(); set_command_callbacks();
} }
@ -41,7 +41,7 @@ DTE::DTE(const esp_modem_dte_config *config, std::unique_ptr<Terminal> t, std::u
DTE::DTE(std::unique_ptr<Terminal> t, std::unique_ptr<Terminal> s): DTE::DTE(std::unique_ptr<Terminal> t, std::unique_ptr<Terminal> s):
buffer(dte_default_buffer_size), buffer(dte_default_buffer_size),
cmux_term(nullptr), primary_term(std::move(t)), secondary_term(std::move(s)), cmux_term(nullptr), primary_term(std::move(t)), secondary_term(std::move(s)),
mode(modem_mode::UNDEF) mode(modem_mode::DUAL_MODE)
{ {
set_command_callbacks(); set_command_callbacks();
} }