feedc0de/esp-protocols
1
0
Fork 0
forked from espressif/esp-protocols
Code Pull Requests Activity

fix(mdns): Fix name mangling not to use strcpy()

Browse Source 
Since it was flagged by clang-tidy as insecture API
This commit is contained in:
David Cermak
2025-01-13 14:55:35 +01:00
parent f5be2f4115
commit 99b54ac384
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
components/mdns/mdns.c
View File

@ -253,12 +253,13 @@ static char *_mdns_mangle_name(char *in)
} }
sprintf(ret, "%s-2", in); sprintf(ret, "%s-2", in);
} else { } else {
ret = malloc(strlen(in) + 2); //one extra byte in case 9-10 or 99-100 etc size_t in_len = strlen(in);
ret = malloc(in_len + 2); //one extra byte in case 9-10 or 99-100 etc
if (ret == NULL) { if (ret == NULL) {
HOOK_MALLOC_FAILED; HOOK_MALLOC_FAILED;
return NULL; return NULL;
} }
strcpy(ret, in); memcpy(ret, in, in_len);
int baseLen = p - in; //length of 'bla' in 'bla-123' int baseLen = p - in; //length of 'bla' in 'bla-123'
//overwrite suffix with new suffix //overwrite suffix with new suffix
sprintf(ret + baseLen, "-%d", suffix + 1); sprintf(ret + baseLen, "-%d", suffix + 1);