feedc0de/fmt
1
0
Fork 0
forked from fmtlib/fmt
Code Pull Requests Activity

Fix a segfault in test on glibc 2.26 #551

Browse Source
This commit is contained in:
Victor Zverovich
2018-02-02 19:34:08 -08:00
parent a9f810c188
commit 5d8ba816de
1 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
test/util-test.cc
View File

@ -743,9 +743,22 @@ TEST(UtilTest, FormatSystemError) {
fmt::format_system_error(message, EDOM, "test"); fmt::format_system_error(message, EDOM, "test");
EXPECT_EQ(fmt::format("test: {}", get_system_error(EDOM)), EXPECT_EQ(fmt::format("test: {}", get_system_error(EDOM)),
to_string(message)); to_string(message));
message.resize(0); message = fmt::memory_buffer();
fmt::format_system_error(
message, EDOM, fmt::string_view(0, std::numeric_limits<size_t>::max())); // Check if std::allocator throws on allocating max size_t / 2 chars.
size_t max_size = std::numeric_limits<size_t>::max() / 2;
bool throws_on_alloc = false;
try {
std::allocator<char> alloc;
alloc.deallocate(alloc.allocate(max_size), max_size);
} catch (std::bad_alloc) {
throws_on_alloc = true;
}
if (!throws_on_alloc) {
fmt::print("warning: std::allocator allocates {} chars", max_size);
return;
}
fmt::format_system_error(message, EDOM, fmt::string_view(0, max_size));
EXPECT_EQ(fmt::format("error {}", EDOM), to_string(message)); EXPECT_EQ(fmt::format("error {}", EDOM), to_string(message));
} }