feedc0de/fmt
1
0
Fork 0
forked from fmtlib/fmt
Code Pull Requests Activity

Suppress warning C4127 in chrono.h (conditional expression is constant) (#2518)

Browse Source
This commit is contained in:
Jonathan W
2021-09-30 18:14:38 +02:00
committed by GitHub
parent 927dbd134d
commit ae9bbe1169
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
include/fmt/chrono.h
View File

@ -44,7 +44,7 @@ FMT_CONSTEXPR To lossless_integral_conversion(const From from, int& ec) {
static_assert(T::is_integer, "To must be integral"); static_assert(T::is_integer, "To must be integral");
// A and B are both signed, or both unsigned. // A and B are both signed, or both unsigned.
if (F::digits <= T::digits) { if (detail::const_check(F::digits <= T::digits)) {
// From fits in To without any problem. // From fits in To without any problem.
} else { } else {
// From does not always fit in To, resort to a dynamic check. // From does not always fit in To, resort to a dynamic check.
@ -79,14 +79,14 @@ FMT_CONSTEXPR To lossless_integral_conversion(const From from, int& ec) {
return {}; return {};
} }
// From is positive. Can it always fit in To? // From is positive. Can it always fit in To?
if (F::digits > T::digits && if (detail::const_check(F::digits > T::digits) &&
from > static_cast<From>(detail::max_value<To>())) { from > static_cast<From>(detail::max_value<To>())) {
ec = 1; ec = 1;
return {}; return {};
} }
} }
if (!F::is_signed && T::is_signed && F::digits >= T::digits && if (detail::const_check(!F::is_signed && T::is_signed && F::digits >= T::digits) &&
from > static_cast<From>(detail::max_value<To>())) { from > static_cast<From>(detail::max_value<To>())) {
ec = 1; ec = 1;
return {}; return {};
@ -243,7 +243,7 @@ To safe_duration_cast(std::chrono::duration<FromRep, FromPeriod> from,
} }
// multiply with Factor::num without overflow or underflow // multiply with Factor::num without overflow or underflow
if (Factor::num != 1) { if (detail::const_check(Factor::num != 1)) {
constexpr auto max1 = detail::max_value<IntermediateRep>() / constexpr auto max1 = detail::max_value<IntermediateRep>() /
static_cast<IntermediateRep>(Factor::num); static_cast<IntermediateRep>(Factor::num);
if (count > max1) { if (count > max1) {
@ -260,7 +260,7 @@ To safe_duration_cast(std::chrono::duration<FromRep, FromPeriod> from,
} }
// this can't go wrong, right? den>0 is checked earlier. // this can't go wrong, right? den>0 is checked earlier.
if (Factor::den != 1) { if (detail::const_check(Factor::den != 1)) {
using common_t = typename std::common_type<IntermediateRep, intmax_t>::type; using common_t = typename std::common_type<IntermediateRep, intmax_t>::type;
count /= static_cast<common_t>(Factor::den); count /= static_cast<common_t>(Factor::den);
} }