feedc0de/fmt
1
0
Fork 0
forked from fmtlib/fmt
Code Pull Requests Activity

fix fmt::get for some GCC versions and legacy Clang (#2144)

Browse Source 
fixes https://github.com/fmtlib/fmt/issues/2140

- some GCC versions decay function pointers to `const void*`, exactly like
  MSVC does
- legacy Clang (prior to 7.0) treats function pointers also as `const T*`
  pointers, but unable to convert them
This commit is contained in:
Alexey Ochapov
2021-02-23 18:18:30 +03:00
committed by GitHub
parent 2797588be1
commit d8e1c9f175
1 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
include/fmt/format.h
View File

@ -3833,21 +3833,16 @@ FMT_CONSTEXPR void advance_to(
auto s = fmt::format("{}", fmt::ptr(p)); auto s = fmt::format("{}", fmt::ptr(p));
\endrst \endrst
*/ */
template <typename T> inline const void* ptr(const T* p) { return p; } template <typename T> const void* ptr(T p) {
template <typename T> inline const void* ptr(const std::unique_ptr<T>& p) { static_assert(std::is_pointer<T>::value, "");
return detail::bit_cast<const void*>(p);
}
template <typename T> const void* ptr(const std::unique_ptr<T>& p) {
return p.get(); return p.get();
} }
template <typename T> inline const void* ptr(const std::shared_ptr<T>& p) { template <typename T> const void* ptr(const std::shared_ptr<T>& p) {
return p.get(); return p.get();
} }
#if !FMT_MSC_VER
// MSVC lets function pointers decay to void pointers, so this
// overload is unnecessary.
template <typename T, typename... Args>
inline const void* ptr(T (*fn)(Args...)) {
return detail::bit_cast<const void*>(fn);
}
#endif
class bytes { class bytes {
private: private: