feedc0de/fmt
1
0
Fork 0
forked from fmtlib/fmt
Code Pull Requests Activity

Refactor Improvement on umul128 function

Browse Source 
- Removal of direct access to members of uint128_fallback and instead
  create the values at the callsite and pass them via the constructor of
  uint128_fallback on the return statement.
This commit is contained in:
Mathew Benson
2023-08-25 13:21:52 +03:00
parent 2b20d7be6f
commit e786824053
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
include/fmt/format.h
View File

@ -376,9 +376,6 @@ class uint128_fallback {
constexpr uint64_t high() const noexcept { return hi_; } constexpr uint64_t high() const noexcept { return hi_; }
constexpr uint64_t low() const noexcept { return lo_; } constexpr uint64_t low() const noexcept { return lo_; }
uint64_t& high() { return hi_; }
uint64_t& low() { return lo_; }
template <typename T, FMT_ENABLE_IF(std::is_integral<T>::value)> template <typename T, FMT_ENABLE_IF(std::is_integral<T>::value)>
constexpr explicit operator T() const { constexpr explicit operator T() const {
return static_cast<T>(lo_); return static_cast<T>(lo_);
@ -1489,9 +1486,9 @@ inline uint128_fallback umul128(uint64_t x, uint64_t y) noexcept {
auto p = static_cast<uint128_opt>(x) * static_cast<uint128_opt>(y); auto p = static_cast<uint128_opt>(x) * static_cast<uint128_opt>(y);
return {static_cast<uint64_t>(p >> 64), static_cast<uint64_t>(p)}; return {static_cast<uint64_t>(p >> 64), static_cast<uint64_t>(p)};
#elif defined(_MSC_VER) && defined(_M_X64) #elif defined(_MSC_VER) && defined(_M_X64)
auto result = uint128_fallback(); auto hi = uint64_t{};
result.low() = _umul128(x, y, &result.high()); auto lo = _umul128(x, y, &hi);
return result; return {hi, lo};
#else #else
const uint64_t mask = static_cast<uint64_t>(max_value<uint32_t>()); const uint64_t mask = static_cast<uint64_t>(max_value<uint32_t>());